Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53842/?format=api
{ "id": 53842, "url": "http://patches.dpdk.org/api/patches/53842/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/77b02a2256d992f23a74514796d6c8bb655bd174.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<77b02a2256d992f23a74514796d6c8bb655bd174.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/77b02a2256d992f23a74514796d6c8bb655bd174.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:31:00", "name": "[14/25] hash: use new tailq locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c029c28c75bab21d5ff8c5e197d5823a482d9566", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/77b02a2256d992f23a74514796d6c8bb655bd174.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53842/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F13651B9DD;\n\tWed, 29 May 2019 18:31:46 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 311A01B9BE\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:39 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:38 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Yipeng Wang <yipeng1.wang@intel.com>,\n\tSameh Gobriel <sameh.gobriel@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>, stephen@networkplumber.org,\n\tthomas@monjalon.net, david.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:31:00 +0100", "Message-Id": "<77b02a2256d992f23a74514796d6c8bb655bd174.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 14/25] hash: use new tailq locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_hash/rte_cuckoo_hash.c | 16 ++++++++--------\n lib/librte_hash/rte_fbk_hash.c | 14 +++++++-------\n lib/librte_kni/rte_kni.c | 16 ++++++++--------\n 3 files changed, 23 insertions(+), 23 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c\nindex 2dc423fba..ffe649411 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.c\n+++ b/lib/librte_hash/rte_cuckoo_hash.c\n@@ -52,13 +52,13 @@ rte_hash_find_existing(const char *name)\n \n \thash_list = RTE_TAILQ_CAST(rte_hash_tailq.head, rte_hash_list);\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, hash_list, next) {\n \t\th = (struct rte_hash *) te->data;\n \t\tif (strncmp(name, h->name, RTE_HASH_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \n \tif (te == NULL) {\n \t\trte_errno = ENOENT;\n@@ -239,7 +239,7 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \n \tsnprintf(hash_name, sizeof(hash_name), \"HT_%s\", params->name);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* guarantee there's no existing: this is normally already checked\n \t * by ring creation above */\n@@ -437,11 +437,11 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \n \tte->data = (void *) h;\n \tTAILQ_INSERT_TAIL(hash_list, te, next);\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn h;\n err_unlock:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n err:\n \trte_ring_free(r);\n \trte_ring_free(r_ext);\n@@ -466,7 +466,7 @@ rte_hash_free(struct rte_hash *h)\n \n \thash_list = RTE_TAILQ_CAST(rte_hash_tailq.head, rte_hash_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* find out tailq entry */\n \tTAILQ_FOREACH(te, hash_list, next) {\n@@ -475,13 +475,13 @@ rte_hash_free(struct rte_hash *h)\n \t}\n \n \tif (te == NULL) {\n-\t\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\t\trte_eal_mcfg_tailq_write_unlock();\n \t\treturn;\n \t}\n \n \tTAILQ_REMOVE(hash_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \tif (h->use_local_cache)\n \t\trte_free(h->local_free_slots);\ndiff --git a/lib/librte_hash/rte_fbk_hash.c b/lib/librte_hash/rte_fbk_hash.c\nindex 9360f7981..54a8596ab 100644\n--- a/lib/librte_hash/rte_fbk_hash.c\n+++ b/lib/librte_hash/rte_fbk_hash.c\n@@ -50,13 +50,13 @@ rte_fbk_hash_find_existing(const char *name)\n \tfbk_hash_list = RTE_TAILQ_CAST(rte_fbk_hash_tailq.head,\n \t\t\t\t rte_fbk_hash_list);\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, fbk_hash_list, next) {\n \t\th = (struct rte_fbk_hash_table *) te->data;\n \t\tif (strncmp(name, h->name, RTE_FBK_HASH_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \tif (te == NULL) {\n \t\trte_errno = ENOENT;\n \t\treturn NULL;\n@@ -103,7 +103,7 @@ rte_fbk_hash_create(const struct rte_fbk_hash_params *params)\n \n \tsnprintf(hash_name, sizeof(hash_name), \"FBK_%s\", params->name);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* guarantee there's no existing */\n \tTAILQ_FOREACH(te, fbk_hash_list, next) {\n@@ -165,7 +165,7 @@ rte_fbk_hash_create(const struct rte_fbk_hash_params *params)\n \tTAILQ_INSERT_TAIL(fbk_hash_list, te, next);\n \n exit:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn ht;\n }\n@@ -188,7 +188,7 @@ rte_fbk_hash_free(struct rte_fbk_hash_table *ht)\n \tfbk_hash_list = RTE_TAILQ_CAST(rte_fbk_hash_tailq.head,\n \t\t\t\t rte_fbk_hash_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* find out tailq entry */\n \tTAILQ_FOREACH(te, fbk_hash_list, next) {\n@@ -197,13 +197,13 @@ rte_fbk_hash_free(struct rte_fbk_hash_table *ht)\n \t}\n \n \tif (te == NULL) {\n-\t\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\t\trte_eal_mcfg_tailq_write_unlock();\n \t\treturn;\n \t}\n \n \tTAILQ_REMOVE(fbk_hash_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \trte_free(ht);\n \trte_free(te);\ndiff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex e6507b07d..d0884aeb9 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -214,7 +214,7 @@ rte_kni_alloc(struct rte_mempool *pktmbuf_pool,\n \t\treturn NULL;\n \t}\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \tkni = __rte_kni_get(conf->name);\n \tif (kni != NULL) {\n@@ -313,7 +313,7 @@ rte_kni_alloc(struct rte_mempool *pktmbuf_pool,\n \tkni_list = RTE_TAILQ_CAST(rte_kni_tailq.head, rte_kni_list);\n \tTAILQ_INSERT_TAIL(kni_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \t/* Allocate mbufs and then put them into alloc_q */\n \tkni_allocate_mbufs(kni);\n@@ -327,7 +327,7 @@ rte_kni_alloc(struct rte_mempool *pktmbuf_pool,\n kni_fail:\n \trte_free(te);\n unlock:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn NULL;\n }\n@@ -390,7 +390,7 @@ rte_kni_release(struct rte_kni *kni)\n \n \tkni_list = RTE_TAILQ_CAST(rte_kni_tailq.head, rte_kni_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \tTAILQ_FOREACH(te, kni_list, next) {\n \t\tif (te->data == kni)\n@@ -408,7 +408,7 @@ rte_kni_release(struct rte_kni *kni)\n \n \tTAILQ_REMOVE(kni_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \t/* mbufs in all fifo should be released, except request/response */\n \n@@ -432,7 +432,7 @@ rte_kni_release(struct rte_kni *kni)\n \treturn 0;\n \n unlock:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn -1;\n }\n@@ -649,11 +649,11 @@ rte_kni_get(const char *name)\n \tif (name == NULL || name[0] == '\\0')\n \t\treturn NULL;\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \n \tkni = __rte_kni_get(name);\n \n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \n \treturn kni;\n }\n", "prefixes": [ "14/25" ] }