Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53836/?format=api
{ "id": 53836, "url": "http://patches.dpdk.org/api/patches/53836/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/054978abf98eec80fcdcb8b03526f79158cb29f9.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<054978abf98eec80fcdcb8b03526f79158cb29f9.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/054978abf98eec80fcdcb8b03526f79158cb29f9.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:30:54", "name": "[08/25] vfio: use new memory locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "148f9762971c63911528d490f0eb82f450538ee5", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/054978abf98eec80fcdcb8b03526f79158cb29f9.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53836/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 381781B9B3;\n\tWed, 29 May 2019 18:31:35 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id B707F1B998\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:27 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:27 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:30:54 +0100", "Message-Id": "<054978abf98eec80fcdcb8b03526f79158cb29f9.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 08/25] vfio: use new memory locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linux/eal/eal_vfio.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c\nindex 6892a2c14..36f0d1ca7 100644\n--- a/lib/librte_eal/linux/eal/eal_vfio.c\n+++ b/lib/librte_eal/linux/eal/eal_vfio.c\n@@ -635,8 +635,6 @@ int\n rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\tint *vfio_dev_fd, struct vfio_device_info *device_info)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\trte_rwlock_t *mem_lock = &mcfg->memory_hotplug_lock;\n \tstruct vfio_group_status group_status = {\n \t\t\t.argsz = sizeof(group_status)\n \t};\n@@ -739,7 +737,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\t\t/* lock memory hotplug before mapping and release it\n \t\t\t * after registering callback, to prevent races\n \t\t\t */\n-\t\t\trte_rwlock_read_lock(mem_lock);\n+\t\t\trte_eal_mcfg_mem_read_lock();\n \t\t\tif (vfio_cfg == default_vfio_cfg)\n \t\t\t\tret = t->dma_map_func(vfio_container_fd);\n \t\t\telse\n@@ -750,7 +748,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\t\t\t\tdev_addr, errno, strerror(errno));\n \t\t\t\tclose(vfio_group_fd);\n \t\t\t\trte_vfio_clear_group(vfio_group_fd);\n-\t\t\t\trte_rwlock_read_unlock(mem_lock);\n+\t\t\t\trte_eal_mcfg_mem_read_unlock();\n \t\t\t\treturn -1;\n \t\t\t}\n \n@@ -781,7 +779,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\t\t\t\t\t\tmap->len);\n \t\t\t\t\trte_spinlock_recursive_unlock(\n \t\t\t\t\t\t\t&user_mem_maps->lock);\n-\t\t\t\t\trte_rwlock_read_unlock(mem_lock);\n+\t\t\t\t\trte_eal_mcfg_mem_read_unlock();\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t}\n@@ -795,7 +793,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\t\telse\n \t\t\t\tret = 0;\n \t\t\t/* unlock memory hotplug */\n-\t\t\trte_rwlock_read_unlock(mem_lock);\n+\t\t\trte_eal_mcfg_mem_read_unlock();\n \n \t\t\tif (ret && rte_errno != ENOTSUP) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not install memory event callback for VFIO\\n\");\n@@ -862,8 +860,6 @@ int\n rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,\n \t\t int vfio_dev_fd)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\trte_rwlock_t *mem_lock = &mcfg->memory_hotplug_lock;\n \tstruct vfio_group_status group_status = {\n \t\t\t.argsz = sizeof(group_status)\n \t};\n@@ -876,7 +872,7 @@ rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,\n \t * VFIO device, because this might be the last device and we might need\n \t * to unregister the callback.\n \t */\n-\trte_rwlock_read_lock(mem_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \n \t/* get group number */\n \tret = rte_vfio_get_group_num(sysfs_base, dev_addr, &iommu_group_num);\n@@ -947,7 +943,7 @@ rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,\n \tret = 0;\n \n out:\n-\trte_rwlock_read_unlock(mem_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \treturn ret;\n }\n \n", "prefixes": [ "08/25" ] }