Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53834/?format=api
{ "id": 53834, "url": "http://patches.dpdk.org/api/patches/53834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9c7c20340a166f9a40e6ed84ce0f73b7a944c802.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9c7c20340a166f9a40e6ed84ce0f73b7a944c802.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9c7c20340a166f9a40e6ed84ce0f73b7a944c802.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:30:52", "name": "[06/25] mem: use new memory locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3115b1a2b1d20f193d62171e70cd2976df2e8f56", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9c7c20340a166f9a40e6ed84ce0f73b7a944c802.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53834/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 702EB1B9A1;\n\tWed, 29 May 2019 18:31:30 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id EF1A81B95C\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:24 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:24 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:30:52 +0100", "Message-Id": "<9c7c20340a166f9a40e6ed84ce0f73b7a944c802.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 06/25] mem: use new memory locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_memory.c | 43 ++++++++++-------------\n 1 file changed, 18 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 3baa2f23a..db44078fd 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -596,13 +596,12 @@ rte_memseg_contig_walk_thread_unsafe(rte_memseg_contig_walk_t func, void *arg)\n int __rte_experimental\n rte_memseg_contig_walk(rte_memseg_contig_walk_t func, void *arg)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tint ret = 0;\n \n \t/* do not allow allocations/frees/init while we iterate */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tret = rte_memseg_contig_walk_thread_unsafe(func, arg);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \n \treturn ret;\n }\n@@ -638,13 +637,12 @@ rte_memseg_walk_thread_unsafe(rte_memseg_walk_t func, void *arg)\n int __rte_experimental\n rte_memseg_walk(rte_memseg_walk_t func, void *arg)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tint ret = 0;\n \n \t/* do not allow allocations/frees/init while we iterate */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tret = rte_memseg_walk_thread_unsafe(func, arg);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \n \treturn ret;\n }\n@@ -671,13 +669,12 @@ rte_memseg_list_walk_thread_unsafe(rte_memseg_list_walk_t func, void *arg)\n int __rte_experimental\n rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tint ret = 0;\n \n \t/* do not allow allocations/frees/init while we iterate */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tret = rte_memseg_list_walk_thread_unsafe(func, arg);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \n \treturn ret;\n }\n@@ -755,12 +752,11 @@ rte_memseg_get_fd_thread_unsafe(const struct rte_memseg *ms)\n int __rte_experimental\n rte_memseg_get_fd(const struct rte_memseg *ms)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tint ret;\n \n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tret = rte_memseg_get_fd_thread_unsafe(ms);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \n \treturn ret;\n }\n@@ -811,12 +807,11 @@ rte_memseg_get_fd_offset_thread_unsafe(const struct rte_memseg *ms,\n int __rte_experimental\n rte_memseg_get_fd_offset(const struct rte_memseg *ms, size_t *offset)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tint ret;\n \n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \tret = rte_memseg_get_fd_offset_thread_unsafe(ms, offset);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \n \treturn ret;\n }\n@@ -837,7 +832,7 @@ rte_extmem_register(void *va_addr, size_t len, rte_iova_t iova_addrs[],\n \t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n-\trte_rwlock_write_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_lock();\n \n \t/* make sure the segment doesn't already exist */\n \tif (malloc_heap_find_external_seg(va_addr, len) != NULL) {\n@@ -866,14 +861,13 @@ rte_extmem_register(void *va_addr, size_t len, rte_iova_t iova_addrs[],\n \t/* memseg list successfully created - increment next socket ID */\n \tmcfg->next_socket_id++;\n unlock:\n-\trte_rwlock_write_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_unlock();\n \treturn ret;\n }\n \n int __rte_experimental\n rte_extmem_unregister(void *va_addr, size_t len)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tstruct rte_memseg_list *msl;\n \tint ret = 0;\n \n@@ -881,7 +875,7 @@ rte_extmem_unregister(void *va_addr, size_t len)\n \t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n-\trte_rwlock_write_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_lock();\n \n \t/* find our segment */\n \tmsl = malloc_heap_find_external_seg(va_addr, len);\n@@ -893,14 +887,13 @@ rte_extmem_unregister(void *va_addr, size_t len)\n \n \tret = malloc_heap_destroy_external_seg(msl);\n unlock:\n-\trte_rwlock_write_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_unlock();\n \treturn ret;\n }\n \n static int\n sync_memory(void *va_addr, size_t len, bool attach)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tstruct rte_memseg_list *msl;\n \tint ret = 0;\n \n@@ -908,7 +901,7 @@ sync_memory(void *va_addr, size_t len, bool attach)\n \t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n-\trte_rwlock_write_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_lock();\n \n \t/* find our segment */\n \tmsl = malloc_heap_find_external_seg(va_addr, len);\n@@ -923,7 +916,7 @@ sync_memory(void *va_addr, size_t len, bool attach)\n \t\tret = rte_fbarray_detach(&msl->memseg_arr);\n \n unlock:\n-\trte_rwlock_write_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_write_unlock();\n \treturn ret;\n }\n \n@@ -951,7 +944,7 @@ rte_eal_memory_init(void)\n \t\treturn -1;\n \n \t/* lock mem hotplug here, to prevent races while we init */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_lock();\n \n \tif (rte_eal_memseg_init() < 0)\n \t\tgoto fail;\n@@ -970,6 +963,6 @@ rte_eal_memory_init(void)\n \n \treturn 0;\n fail:\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_eal_mcfg_mem_read_unlock();\n \treturn -1;\n }\n", "prefixes": [ "06/25" ] }