Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53736/?format=api
http://patches.dpdk.org/api/patches/53736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-3-lukaszx.krakowiak@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190528120553.2992-3-lukaszx.krakowiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190528120553.2992-3-lukaszx.krakowiak@intel.com", "date": "2019-05-28T12:05:28", "name": "[02/27] sched: update subport and pipe data structures", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a98299d3d8365ed3a5ff69e65fc10ca0a4b03c7f", "submitter": { "id": 1221, "url": "http://patches.dpdk.org/api/people/1221/?format=api", "name": "Lukasz Krakowiak", "email": "lukaszx.krakowiak@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190528120553.2992-3-lukaszx.krakowiak@intel.com/mbox/", "series": [ { "id": 4794, "url": "http://patches.dpdk.org/api/series/4794/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4794", "date": "2019-05-28T12:05:26", "name": "sched: feature enhancements", "version": 1, "mbox": "http://patches.dpdk.org/series/4794/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53736/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53736/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CCCEE1B953;\n\tTue, 28 May 2019 14:08:16 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id D177A4C9D\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 14:08:09 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 05:08:08 -0700", "from lkrakowx-mobl.ger.corp.intel.com ([10.103.104.99])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 May 2019 05:08:07 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lukasz Krakowiak <lukaszx.krakowiak@intel.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org, Jasvinder Singh <jasvinder.singh@intel.com>,\n\tAbraham Tovar <abrahamx.tovar@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 28 May 2019 14:05:28 +0200", "Message-Id": "<20190528120553.2992-3-lukaszx.krakowiak@intel.com>", "X-Mailer": "git-send-email 2.19.2.windows.1", "In-Reply-To": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "References": "<20190528120553.2992-1-lukaszx.krakowiak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/27] sched: update subport and pipe data\n\tstructures", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jasvinder Singh <jasvinder.singh@intel.com>\n\nUpdate public data structures for subport and pipe to allow configuration\nflexiblity for pipe traffic classes and queues, and subport level\nconfiguration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n app/test/test_sched.c | 2 +-\n examples/qos_sched/init.c | 2 +-\n lib/librte_sched/rte_sched.h | 76 ++++++++++++++++++++++--------------\n 3 files changed, 49 insertions(+), 31 deletions(-)", "diff": "diff --git a/app/test/test_sched.c b/app/test/test_sched.c\nindex 4eed8dbde..460eb53ec 100644\n--- a/app/test/test_sched.c\n+++ b/app/test/test_sched.c\n@@ -40,7 +40,7 @@ static struct rte_sched_pipe_params pipe_profile[] = {\n \t\t.tc_rate = {305175, 305175, 305175, 305175},\n \t\t.tc_period = 40,\n \n-\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},\n+\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1},\n \t},\n };\n \ndiff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c\nindex 37c2b95fd..f44a07cd6 100644\n--- a/examples/qos_sched/init.c\n+++ b/examples/qos_sched/init.c\n@@ -186,7 +186,7 @@ static struct rte_sched_pipe_params pipe_profiles[RTE_SCHED_PIPE_PROFILES_PER_PO\n \t\t.tc_ov_weight = 1,\n #endif\n \n-\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},\n+\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1},\n \t},\n };\n \ndiff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h\nindex cf7695f27..71728f725 100644\n--- a/lib/librte_sched/rte_sched.h\n+++ b/lib/librte_sched/rte_sched.h\n@@ -117,6 +117,33 @@ extern \"C\" {\n #define RTE_SCHED_FRAME_OVERHEAD_DEFAULT 24\n #endif\n \n+/*\n+ * Pipe configuration parameters. The period and credits_per_period\n+ * parameters are measured in bytes, with one byte meaning the time\n+ * duration associated with the transmission of one byte on the\n+ * physical medium of the output port, with pipe or pipe traffic class\n+ * rate (measured as percentage of output port rate) determined as\n+ * credits_per_period divided by period. One credit represents one\n+ * byte.\n+ */\n+struct rte_sched_pipe_params {\n+\t/* Pipe token bucket */\n+\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n+\tuint32_t tb_size; /**< Size (measured in credits) */\n+\n+\t/* Pipe traffic classes */\n+\tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\t/**< Traffic class rates (measured in bytes per second) */\n+\tuint32_t tc_period;\n+\t/**< Enforcement period (measured in milliseconds) */\n+#ifdef RTE_SCHED_SUBPORT_TC_OV\n+\tuint8_t tc_ov_weight; /**< Weight Traffic class 3 oversubscription */\n+#endif\n+\n+\t/* Pipe queues */\n+\tuint8_t wrr_weights[RTE_SCHED_WRR_QUEUES_PER_PIPE]; /**< WRR weights */\n+};\n+\n /*\n * Subport configuration parameters. The period and credits_per_period\n * parameters are measured in bytes, with one byte meaning the time\n@@ -128,14 +155,32 @@ extern \"C\" {\n */\n struct rte_sched_subport_params {\n \t/* Subport token bucket */\n-\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n-\tuint32_t tb_size; /**< Size (measured in credits) */\n+\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n+\tuint32_t tb_size; /**< Size (measured in credits) */\n \n \t/* Subport traffic classes */\n \tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \t/**< Traffic class rates (measured in bytes per second) */\n \tuint32_t tc_period;\n \t/**< Enforcement period for rates (measured in milliseconds) */\n+\n+\tuint32_t n_subport_pipes; /**< Number of subport_pipes */\n+\tuint16_t qsize[RTE_SCHED_QUEUES_PER_PIPE];\n+\t/**< Packet queue size for each traffic class.\n+\t * All queues which are not needed, have zero size. All the pipes\n+\t * within the same subport share the similar configuration for the\n+\t * queues.\n+\t */\n+\tstruct rte_sched_pipe_params *pipe_profiles;\n+\t/**< Pipe profile table.\n+\t * Every pipe is configured using one of the profiles from this table.\n+\t */\n+\tuint32_t n_pipe_profiles; /**< Profiles in the pipe profile table */\n+#ifdef RTE_SCHED_RED\n+\tstruct rte_red_params\n+\t\tred_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];\n+\t\t/**< RED parameters */\n+#endif\n };\n \n /** Subport statistics */\n@@ -158,33 +203,6 @@ struct rte_sched_subport_stats {\n #endif\n };\n \n-/*\n- * Pipe configuration parameters. The period and credits_per_period\n- * parameters are measured in bytes, with one byte meaning the time\n- * duration associated with the transmission of one byte on the\n- * physical medium of the output port, with pipe or pipe traffic class\n- * rate (measured as percentage of output port rate) determined as\n- * credits_per_period divided by period. One credit represents one\n- * byte.\n- */\n-struct rte_sched_pipe_params {\n-\t/* Pipe token bucket */\n-\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n-\tuint32_t tb_size; /**< Size (measured in credits) */\n-\n-\t/* Pipe traffic classes */\n-\tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\t/**< Traffic class rates (measured in bytes per second) */\n-\tuint32_t tc_period;\n-\t/**< Enforcement period (measured in milliseconds) */\n-#ifdef RTE_SCHED_SUBPORT_TC_OV\n-\tuint8_t tc_ov_weight;\t\t /**< Weight Traffic class 3 oversubscription */\n-#endif\n-\n-\t/* Pipe queues */\n-\tuint8_t wrr_weights[RTE_SCHED_QUEUES_PER_PIPE]; /**< WRR weights */\n-};\n-\n /** Queue statistics */\n struct rte_sched_queue_stats {\n \t/* Packets */\n", "prefixes": [ "02/27" ] }{ "id": 53736, "url": "