Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53436,
    "url": "http://patches.dpdk.org/api/patches/53436/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190515160911.79543-1-roy.fan.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190515160911.79543-1-roy.fan.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190515160911.79543-1-roy.fan.zhang@intel.com",
    "date": "2019-05-15T16:09:11",
    "name": "vhost/crypto: fix inferred misuse of enum",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8305171c59287259fb91d15bded14f623d133c3a",
    "submitter": {
        "id": 304,
        "url": "http://patches.dpdk.org/api/people/304/?format=api",
        "name": "Fan Zhang",
        "email": "roy.fan.zhang@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190515160911.79543-1-roy.fan.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 4673,
            "url": "http://patches.dpdk.org/api/series/4673/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4673",
            "date": "2019-05-15T16:09:11",
            "name": "vhost/crypto: fix inferred misuse of enum",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4673/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53436/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53436/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 93E435B16;\n\tWed, 15 May 2019 18:13:43 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 70B185A44;\n\tWed, 15 May 2019 18:13:41 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 May 2019 09:13:40 -0700",
            "from silpixa00398673.ir.intel.com (HELO\n\tsilpixa00398673.ger.corp.intel.com) ([10.237.223.136])\n\tby fmsmga005.fm.intel.com with ESMTP; 15 May 2019 09:13:39 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Fan Zhang <roy.fan.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "maxime.coquelin@redhat.com, Fan Zhang <roy.fan.zhang@intel.com>,\n\tstable@dpdk.org",
        "Date": "Wed, 15 May 2019 17:09:11 +0100",
        "Message-Id": "<20190515160911.79543-1-roy.fan.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.14.5",
        "Subject": "[dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes the inferred misuse of enum of crypto\nalgorithms.\n\nCoverity issue: 325879\nFixes: e80a98708166 (\"vhost/crypto: add session message handler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n lib/librte_vhost/vhost_crypto.c | 93 ++++++++++++++++++-----------------------\n 1 file changed, 41 insertions(+), 52 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c\nindex 0edf12d52..b812661ef 100644\n--- a/lib/librte_vhost/vhost_crypto.c\n+++ b/lib/librte_vhost/vhost_crypto.c\n@@ -46,116 +46,107 @@\n \t((t)(uintptr_t)vhost_iova_to_vva(r->dev, r->vq, a, l, p))\n \n static int\n-cipher_algo_transform(uint32_t virtio_cipher_algo)\n+cipher_algo_transform(uint32_t virtio_cipher_algo,\n+\t\tenum rte_crypto_cipher_algorithm *algo)\n {\n-\tint ret;\n-\n \tswitch (virtio_cipher_algo) {\n \tcase VIRTIO_CRYPTO_CIPHER_AES_CBC:\n-\t\tret = RTE_CRYPTO_CIPHER_AES_CBC;\n+\t\t*algo = RTE_CRYPTO_CIPHER_AES_CBC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_AES_CTR:\n-\t\tret = RTE_CRYPTO_CIPHER_AES_CTR;\n+\t\t*algo = RTE_CRYPTO_CIPHER_AES_CTR;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_DES_ECB:\n-\t\tret = -VIRTIO_CRYPTO_NOTSUPP;\n+\t\t*algo = -VIRTIO_CRYPTO_NOTSUPP;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_DES_CBC:\n-\t\tret = RTE_CRYPTO_CIPHER_DES_CBC;\n+\t\t*algo = RTE_CRYPTO_CIPHER_DES_CBC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_3DES_ECB:\n-\t\tret = RTE_CRYPTO_CIPHER_3DES_ECB;\n+\t\t*algo = RTE_CRYPTO_CIPHER_3DES_ECB;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_3DES_CBC:\n-\t\tret = RTE_CRYPTO_CIPHER_3DES_CBC;\n+\t\t*algo = RTE_CRYPTO_CIPHER_3DES_CBC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_3DES_CTR:\n-\t\tret = RTE_CRYPTO_CIPHER_3DES_CTR;\n+\t\t*algo = RTE_CRYPTO_CIPHER_3DES_CTR;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_KASUMI_F8:\n-\t\tret = RTE_CRYPTO_CIPHER_KASUMI_F8;\n+\t\t*algo = RTE_CRYPTO_CIPHER_KASUMI_F8;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_SNOW3G_UEA2:\n-\t\tret = RTE_CRYPTO_CIPHER_SNOW3G_UEA2;\n+\t\t*algo = RTE_CRYPTO_CIPHER_SNOW3G_UEA2;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_AES_F8:\n-\t\tret = RTE_CRYPTO_CIPHER_AES_F8;\n+\t\t*algo = RTE_CRYPTO_CIPHER_AES_F8;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_AES_XTS:\n-\t\tret = RTE_CRYPTO_CIPHER_AES_XTS;\n+\t\t*algo = RTE_CRYPTO_CIPHER_AES_XTS;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_CIPHER_ZUC_EEA3:\n-\t\tret = RTE_CRYPTO_CIPHER_ZUC_EEA3;\n+\t\t*algo = RTE_CRYPTO_CIPHER_ZUC_EEA3;\n \t\tbreak;\n \tdefault:\n-\t\tret = -VIRTIO_CRYPTO_BADMSG;\n+\t\treturn -VIRTIO_CRYPTO_BADMSG;\n \t\tbreak;\n \t}\n \n-\treturn ret;\n+\treturn 0;\n }\n \n static int\n-auth_algo_transform(uint32_t virtio_auth_algo)\n+auth_algo_transform(uint32_t virtio_auth_algo,\n+\t\tenum rte_crypto_auth_algorithm *algo)\n {\n-\tint ret;\n-\n \tswitch (virtio_auth_algo) {\n-\n \tcase VIRTIO_CRYPTO_NO_MAC:\n-\t\tret = RTE_CRYPTO_AUTH_NULL;\n+\t\t*algo = RTE_CRYPTO_AUTH_NULL;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_MD5:\n-\t\tret = RTE_CRYPTO_AUTH_MD5_HMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_MD5_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_SHA1:\n-\t\tret = RTE_CRYPTO_AUTH_SHA1_HMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_SHA1_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_SHA_224:\n-\t\tret = RTE_CRYPTO_AUTH_SHA224_HMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_SHA224_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_SHA_256:\n-\t\tret = RTE_CRYPTO_AUTH_SHA256_HMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_SHA256_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_SHA_384:\n-\t\tret = RTE_CRYPTO_AUTH_SHA384_HMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_SHA384_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_HMAC_SHA_512:\n-\t\tret = RTE_CRYPTO_AUTH_SHA512_HMAC;\n-\t\tbreak;\n-\tcase VIRTIO_CRYPTO_MAC_CMAC_3DES:\n-\t\tret = -VIRTIO_CRYPTO_NOTSUPP;\n+\t\t*algo = RTE_CRYPTO_AUTH_SHA512_HMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_CMAC_AES:\n-\t\tret = RTE_CRYPTO_AUTH_AES_CMAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_AES_CMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_KASUMI_F9:\n-\t\tret = RTE_CRYPTO_AUTH_KASUMI_F9;\n+\t\t*algo = RTE_CRYPTO_AUTH_KASUMI_F9;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_SNOW3G_UIA2:\n-\t\tret = RTE_CRYPTO_AUTH_SNOW3G_UIA2;\n+\t\t*algo = RTE_CRYPTO_AUTH_SNOW3G_UIA2;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_GMAC_AES:\n-\t\tret = RTE_CRYPTO_AUTH_AES_GMAC;\n-\t\tbreak;\n-\tcase VIRTIO_CRYPTO_MAC_GMAC_TWOFISH:\n-\t\tret = -VIRTIO_CRYPTO_NOTSUPP;\n+\t\t*algo = RTE_CRYPTO_AUTH_AES_GMAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_CBCMAC_AES:\n-\t\tret = RTE_CRYPTO_AUTH_AES_CBC_MAC;\n-\t\tbreak;\n-\tcase VIRTIO_CRYPTO_MAC_CBCMAC_KASUMI_F9:\n-\t\tret = -VIRTIO_CRYPTO_NOTSUPP;\n+\t\t*algo = RTE_CRYPTO_AUTH_AES_CBC_MAC;\n \t\tbreak;\n \tcase VIRTIO_CRYPTO_MAC_XCBC_AES:\n-\t\tret = RTE_CRYPTO_AUTH_AES_XCBC_MAC;\n+\t\t*algo = RTE_CRYPTO_AUTH_AES_XCBC_MAC;\n \t\tbreak;\n+\tcase VIRTIO_CRYPTO_MAC_CMAC_3DES:\n+\tcase VIRTIO_CRYPTO_MAC_GMAC_TWOFISH:\n+\tcase VIRTIO_CRYPTO_MAC_CBCMAC_KASUMI_F9:\n+\t\treturn -VIRTIO_CRYPTO_NOTSUPP;\n \tdefault:\n-\t\tret = -VIRTIO_CRYPTO_BADMSG;\n-\t\tbreak;\n+\t\treturn -VIRTIO_CRYPTO_BADMSG;\n \t}\n \n-\treturn ret;\n+\treturn 0;\n }\n \n static int get_iv_len(enum rte_crypto_cipher_algorithm algo)\n@@ -242,12 +233,11 @@ transform_cipher_param(struct rte_crypto_sym_xform *xform,\n {\n \tint ret;\n \n-\tret = cipher_algo_transform(param->cipher_algo);\n+\tret = cipher_algo_transform(param->cipher_algo, &xform->cipher.algo);\n \tif (unlikely(ret < 0))\n \t\treturn ret;\n \n \txform->type = RTE_CRYPTO_SYM_XFORM_CIPHER;\n-\txform->cipher.algo = (enum rte_crypto_cipher_algorithm)ret;\n \txform->cipher.key.length = param->cipher_key_len;\n \tif (xform->cipher.key.length > 0)\n \t\txform->cipher.key.data = param->cipher_key_buf;\n@@ -293,11 +283,11 @@ transform_chain_param(struct rte_crypto_sym_xform *xforms,\n \t}\n \n \t/* cipher */\n-\tret = cipher_algo_transform(param->cipher_algo);\n+\tret = cipher_algo_transform(param->cipher_algo,\n+\t\t\t&xform_cipher->cipher.algo);\n \tif (unlikely(ret < 0))\n \t\treturn ret;\n \txform_cipher->type = RTE_CRYPTO_SYM_XFORM_CIPHER;\n-\txform_cipher->cipher.algo = (enum rte_crypto_cipher_algorithm)ret;\n \txform_cipher->cipher.key.length = param->cipher_key_len;\n \txform_cipher->cipher.key.data = param->cipher_key_buf;\n \tret = get_iv_len(xform_cipher->cipher.algo);\n@@ -308,10 +298,9 @@ transform_chain_param(struct rte_crypto_sym_xform *xforms,\n \n \t/* auth */\n \txform_auth->type = RTE_CRYPTO_SYM_XFORM_AUTH;\n-\tret = auth_algo_transform(param->hash_algo);\n+\tret = auth_algo_transform(param->hash_algo, &xform_auth->auth.algo);\n \tif (unlikely(ret < 0))\n \t\treturn ret;\n-\txform_auth->auth.algo = (enum rte_crypto_auth_algorithm)ret;\n \txform_auth->auth.digest_length = param->digest_len;\n \txform_auth->auth.key.length = param->auth_key_len;\n \txform_auth->auth.key.data = param->auth_key_buf;\n",
    "prefixes": []
}