Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53241/?format=api
{ "id": 53241, "url": "http://patches.dpdk.org/api/patches/53241/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com", "date": "2019-05-03T11:50:50", "name": "[3/3] ipc: add warnings about correct API usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5cf78114b28afdf0766f7f10f4e8ecef8881a07d", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4552, "url": "http://patches.dpdk.org/api/series/4552/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4552", "date": "2019-05-03T11:50:48", "name": "[1/3] doc: fix typo in ipc doc", "version": 1, "mbox": "http://patches.dpdk.org/series/4552/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53241/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7A2D45A44;\n\tFri, 3 May 2019 13:50:59 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id AE9C24C77;\n\tFri, 3 May 2019 13:50:55 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2019 04:50:54 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 03 May 2019 04:50:53 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,425,1549958400\"; d=\"scan'208\";a=\"321118209\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>, stable@dpdk.org", "Date": "Fri, 3 May 2019 12:50:50 +0100", "Message-Id": "<d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<c5b98a67c6f0b66b3ef0534dc1b9ed553d4d7340.1556883753.git.anatoly.burakov@intel.com>", "<c5b98a67c6f0b66b3ef0534dc1b9ed553d4d7340.1556883753.git.anatoly.burakov@intel.com>" ], "References": [ "<c5b98a67c6f0b66b3ef0534dc1b9ed553d4d7340.1556883753.git.anatoly.burakov@intel.com>", "<c5b98a67c6f0b66b3ef0534dc1b9ed553d4d7340.1556883753.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 3/3] ipc: add warnings about correct API usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When handling synchronous or asynchronous requests, the reply\nmust be sent explicitly even if the result of the operation is\nan error, to avoid the other side timing out. Make note of this\nin documentation explicitly.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n doc/guides/prog_guide/multi_proc_support.rst | 7 +++++++\n lib/librte_eal/common/include/rte_eal.h | 15 +++++++++++++++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst\nindex 665474a4c..b9758d3fb 100644\n--- a/doc/guides/prog_guide/multi_proc_support.rst\n+++ b/doc/guides/prog_guide/multi_proc_support.rst\n@@ -309,6 +309,13 @@ If a response is required, a new ``rte_mp_msg`` message descriptor must be\n constructed and sent via ``rte_mp_reply()`` function, along with ``peer``\n pointer. The resulting response will then be delivered to the correct requestor.\n \n+.. warning::\n+ Simply returning a value when processing a request callback will not send a\n+ response to the request - it must always be explicitly sent even in case\n+ of errors. Implementation of error signalling rests with the application,\n+ there is no built-in way to indicate success or error for a request. Failing\n+ to do so will cause the requestor to time out while waiting on a response.\n+\n Misc considerations\n ~~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex 7db022532..82ee50fd5 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -226,6 +226,11 @@ struct rte_mp_reply {\n * As we create socket channel for primary/secondary communication, use\n * this function typedef to register action for coming messages.\n *\n+ * @note When handling IPC request callbacks, the reply must be sent even in\n+ * cases of error handling. Simply retuning success or failure will *not* send\n+ * a response to the requestor. Implementation of error signalling mechanism\n+ * is up to the application.\n+ *\n * @note No memory allocations should take place inside the callback.\n */\n typedef int (*rte_mp_t)(const struct rte_mp_msg *msg, const void *peer);\n@@ -237,6 +242,11 @@ typedef int (*rte_mp_t)(const struct rte_mp_msg *msg, const void *peer);\n * this function typedef to register action for coming responses to asynchronous\n * requests.\n *\n+ * @note When handling IPC request callbacks, the reply must be sent even in\n+ * cases of error handling. Simply retuning success or failure will *not* send\n+ * a response to the requestor. Implementation of error signalling mechanism\n+ * is up to the application.\n+ *\n * @note No memory allocations should take place inside the callback.\n */\n typedef int (*rte_mp_async_reply_t)(const struct rte_mp_msg *request,\n@@ -368,6 +378,11 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,\n * This function will send a reply message in response to a request message\n * received previously.\n *\n+ * @note When handling IPC request callbacks, the reply must be sent even in\n+ * cases of error handling. Simply retuning success or failure will *not* send\n+ * a response to the requestor. Implementation of error signalling mechanism\n+ * is up to the application.\n+ *\n * @param msg\n * The msg argument contains the customized message.\n *\n", "prefixes": [ "3/3" ] }