Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53148,
    "url": "http://patches.dpdk.org/api/patches/53148/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/6b8908ab3f0d662c803dba10eba2cae989f8ef4f.1556546216.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<6b8908ab3f0d662c803dba10eba2cae989f8ef4f.1556546216.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/6b8908ab3f0d662c803dba10eba2cae989f8ef4f.1556546216.git.anatoly.burakov@intel.com",
    "date": "2019-04-29T13:59:28",
    "name": "ipc: handle more invalid parameter cases",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0867b8715ac517d750fca7fdc07cfb212c892470",
    "submitter": {
        "id": 4,
        "url": "http://patches.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/6b8908ab3f0d662c803dba10eba2cae989f8ef4f.1556546216.git.anatoly.burakov@intel.com/mbox/",
    "series": [
        {
            "id": 4502,
            "url": "http://patches.dpdk.org/api/series/4502/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4502",
            "date": "2019-04-29T13:59:28",
            "name": "ipc: handle more invalid parameter cases",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4502/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53148/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53148/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B2501B112;\n\tMon, 29 Apr 2019 15:59:33 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id AA3721B111;\n\tMon, 29 Apr 2019 15:59:31 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Apr 2019 06:59:30 -0700",
            "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Apr 2019 06:59:29 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,409,1549958400\"; d=\"scan'208\";a=\"168957279\"",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "keith.wiles@intel.com,\n\therakliusz.lipiec@intel.com,\n\tstable@dpdk.org",
        "Date": "Mon, 29 Apr 2019 14:59:28 +0100",
        "Message-Id": "<6b8908ab3f0d662c803dba10eba2cae989f8ef4f.1556546216.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] ipc: handle more invalid parameter cases",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Length of buffer and number of fd's to send are signed values, so\nthey can be negative, but the API doesn't check for that. Fix it\nby checking for negative values as well.\n\nFixes: bacaa2754017 (\"eal: add channel for multi-process communication\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_proc.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex b46d644b3..42df2b3bf 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -758,6 +758,18 @@ check_input(const struct rte_mp_msg *msg)\n \tif (validate_action_name(msg->name))\n \t\treturn false;\n \n+\tif (msg->len_param < 0) {\n+\t\tRTE_LOG(ERR, EAL, \"Message data length is negative\\n\");\n+\t\trte_errno = EINVAL;\n+\t\treturn false;\n+\t}\n+\n+\tif (msg->num_fds < 0) {\n+\t\tRTE_LOG(ERR, EAL, \"Number of fd's is negative\\n\");\n+\t\trte_errno = EINVAL;\n+\t\treturn false;\n+\t}\n+\n \tif (msg->len_param > RTE_MP_MAX_PARAM_LEN) {\n \t\tRTE_LOG(ERR, EAL, \"Message data is too long\\n\");\n \t\trte_errno = E2BIG;\n",
    "prefixes": []
}