Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52958/?format=api
{ "id": 52958, "url": "http://patches.dpdk.org/api/patches/52958/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190419100113.31284-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190419100113.31284-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190419100113.31284-2-bruce.richardson@intel.com", "date": "2019-04-19T10:01:13", "name": "[2/2] crypto/aesni_mb: cleanup of version check code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7cde113b08be92d01b9d7e290a606ac39ee6da2", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190419100113.31284-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4395, "url": "http://patches.dpdk.org/api/series/4395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4395", "date": "2019-04-19T10:01:12", "name": "[1/2] crypto/aesni_gcm: add dependency version check", "version": 1, "mbox": "http://patches.dpdk.org/series/4395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52958/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5AF661BBA1;\n\tFri, 19 Apr 2019 12:01:31 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id CC7BC1B9A3\n\tfor <dev@dpdk.org>; Fri, 19 Apr 2019 12:01:29 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Apr 2019 03:01:29 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga007.jf.intel.com with ESMTP; 19 Apr 2019 03:01:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,369,1549958400\"; d=\"scan'208\";a=\"132688598\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 19 Apr 2019 11:01:13 +0100", "Message-Id": "<20190419100113.31284-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190419100113.31284-1-bruce.richardson@intel.com>", "References": "<20190419100113.31284-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] crypto/aesni_mb: cleanup of version check\n\tcode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The version check for the IPSec_MB library present in the aesni_gcm\nlibrary's meson.build file is a little cleaner than that given here,\nso update this one so that both work identically.\n\nWhile one could use the checks done in the other right now, potentially in\nfuture they may have different version dependencies, or may be compiled in\ndifferent orders, so keep the code duplicated for safety, since it's only a\nfew lines.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/crypto/aesni_mb/meson.build | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_mb/meson.build b/drivers/crypto/aesni_mb/meson.build\nindex fbc4878af..7c1eb3f86 100644\n--- a/drivers/crypto/aesni_mb/meson.build\n+++ b/drivers/crypto/aesni_mb/meson.build\n@@ -1,25 +1,25 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Intel Corporation\n-IPSec_MB_ver_0_52 = '0.52.0'\n+\n+IMB_required_ver = '0.52.0'\n lib = cc.find_library('IPSec_MB', required: false)\n if not lib.found()\n \tbuild = false\n else\n \text_deps += lib\n \n-\timb_arr = cc.get_define('IMB_VERSION_STR',\n-\t\tprefix : '#include<intel-ipsec-mb.h>').split('\"')\n-\n-\timb_ver = ''.join(imb_arr)\n+\t# version comes with quotes, so we split based on \" and take the middle\n+\timb_ver = cc.get_define('IMB_VERSION_STR',\n+\t\tprefix : '#include<intel-ipsec-mb.h>').split('\"')[1]\n \n-\tif (imb_ver == '') or (imb_ver.version_compare('<' + IPSec_MB_ver_0_52))\n-\t\tmessage('IPSec_MB version >= 0.52 is required')\n+\tif (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))\n+\t\tmessage('IPSec_MB version >= @0@ is required, found version @1@'.format(\n+\t\t\t\tIMB_required_ver, imb_ver))\n \t\tbuild = false\n-\telse\n-\t\tsources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')\n \tendif\n \n endif\n \n+sources = files('rte_aesni_mb_pmd.c', 'rte_aesni_mb_pmd_ops.c')\n allow_experimental_apis = true\n deps += ['bus_vdev']\n", "prefixes": [ "2/2" ] }