Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5278,
    "url": "http://patches.dpdk.org/api/patches/5278/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1433760090-17110-8-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433760090-17110-8-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433760090-17110-8-git-send-email-konstantin.ananyev@intel.com",
    "date": "2015-06-08T10:41:29",
    "name": "[dpdk-dev,PATCHv2,7/8] acl: fix ambiguity between ACL rules in UT.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7bd44b254e7ca9bbc646947e69bf6968168cf4b7",
    "submitter": {
        "id": 33,
        "url": "http://patches.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1433760090-17110-8-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/5278/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/5278/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CCBF45A52;\n\tMon,  8 Jun 2015 12:41:45 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id AAFCC12A8\n\tfor <dev@dpdk.org>; Mon,  8 Jun 2015 12:41:41 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 08 Jun 2015 03:41:39 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 08 Jun 2015 03:41:39 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt58AfbOI029645; Mon, 8 Jun 2015 11:41:37 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t58AfbGL017596;\n\tMon, 8 Jun 2015 11:41:37 +0100",
            "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with  id t58Afbvb017590;\n\tMon, 8 Jun 2015 11:41:37 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,573,1427785200\"; d=\"scan'208\";a=\"583972362\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  8 Jun 2015 11:41:29 +0100",
        "Message-Id": "<1433760090-17110-8-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1433760090-17110-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1433373024-5558-2-git-send-email-konstantin.ananyev@intel.com>\n\t<1433760090-17110-1-git-send-email-konstantin.ananyev@intel.com>",
        "Subject": "[dpdk-dev] [PATCHv2 7/8] acl: fix ambiguity between ACL rules in UT.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Some test rules had equal priority for the same category.\nThat can cause an ambiguity in build trie and test results.\nSpecify different priority value for each rule from the same category.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n app/test/test_acl.h | 52 ++++++++++++++++++++++++++--------------------------\n 1 file changed, 26 insertions(+), 26 deletions(-)",
    "diff": "diff --git a/app/test/test_acl.h b/app/test/test_acl.h\nindex 4af457d..4e8ff34 100644\n--- a/app/test/test_acl.h\n+++ b/app/test/test_acl.h\n@@ -105,7 +105,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling to 192.168.0.0/16 */\n \t\t{\n \t\t\t\t.data = {.userdata = 1, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 230},\n \t\t\t\t.dst_addr = IPv4(192,168,0,0),\n \t\t\t\t.dst_mask_len = 16,\n \t\t\t\t.src_port_low = 0,\n@@ -116,7 +116,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling to 192.168.1.0/24 */\n \t\t{\n \t\t\t\t.data = {.userdata = 2, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 330},\n \t\t\t\t.dst_addr = IPv4(192,168,1,0),\n \t\t\t\t.dst_mask_len = 24,\n \t\t\t\t.src_port_low = 0,\n@@ -127,7 +127,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling to 192.168.1.50 */\n \t\t{\n \t\t\t\t.data = {.userdata = 3, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 230},\n \t\t\t\t.dst_addr = IPv4(192,168,1,50),\n \t\t\t\t.dst_mask_len = 32,\n \t\t\t\t.src_port_low = 0,\n@@ -140,7 +140,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling from 10.0.0.0/8 */\n \t\t{\n \t\t\t\t.data = {.userdata = 4, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 240},\n \t\t\t\t.src_addr = IPv4(10,0,0,0),\n \t\t\t\t.src_mask_len = 8,\n \t\t\t\t.src_port_low = 0,\n@@ -151,7 +151,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling from 10.1.1.0/24 */\n \t\t{\n \t\t\t\t.data = {.userdata = 5, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 340},\n \t\t\t\t.src_addr = IPv4(10,1,1,0),\n \t\t\t\t.src_mask_len = 24,\n \t\t\t\t.src_port_low = 0,\n@@ -162,7 +162,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets traveling from 10.1.1.1 */\n \t\t{\n \t\t\t\t.data = {.userdata = 6, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 240},\n \t\t\t\t.src_addr = IPv4(10,1,1,1),\n \t\t\t\t.src_mask_len = 32,\n \t\t\t\t.src_port_low = 0,\n@@ -175,7 +175,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with lower 7 bytes of VLAN tag equal to 0x64  */\n \t\t{\n \t\t\t\t.data = {.userdata = 7, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 260},\n \t\t\t\t.vlan = 0x64,\n \t\t\t\t.vlan_mask = 0x7f,\n \t\t\t\t.src_port_low = 0,\n@@ -186,7 +186,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with VLAN tags that have 0x5 in them */\n \t\t{\n \t\t\t\t.data = {.userdata = 8, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 260},\n \t\t\t\t.vlan = 0x5,\n \t\t\t\t.vlan_mask = 0x5,\n \t\t\t\t.src_port_low = 0,\n@@ -197,7 +197,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with VLAN tag 5 */\n \t\t{\n \t\t\t\t.data = {.userdata = 9, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 360},\n \t\t\t\t.vlan = 0x5,\n \t\t\t\t.vlan_mask = 0xffff,\n \t\t\t\t.src_port_low = 0,\n@@ -210,7 +210,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with lower 7 bytes of domain equal to 0x64  */\n \t\t{\n \t\t\t\t.data = {.userdata = 10, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 250},\n \t\t\t\t.domain = 0x64,\n \t\t\t\t.domain_mask = 0x7f,\n \t\t\t\t.src_port_low = 0,\n@@ -221,7 +221,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with domains that have 0x5 in them */\n \t\t{\n \t\t\t\t.data = {.userdata = 11, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 350},\n \t\t\t\t.domain = 0x5,\n \t\t\t\t.domain_mask = 0x5,\n \t\t\t\t.src_port_low = 0,\n@@ -232,7 +232,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with domain 5 */\n \t\t{\n \t\t\t\t.data = {.userdata = 12, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 350},\n \t\t\t\t.domain = 0x5,\n \t\t\t\t.domain_mask = 0xffff,\n \t\t\t\t.src_port_low = 0,\n@@ -245,7 +245,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with dst port 80 */\n \t\t{\n \t\t\t\t.data = {.userdata = 13, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 310},\n \t\t\t\t.dst_port_low = 80,\n \t\t\t\t.dst_port_high = 80,\n \t\t\t\t.src_port_low = 0,\n@@ -254,7 +254,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with dst port 22-1023 */\n \t\t{\n \t\t\t\t.data = {.userdata = 14, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 210},\n \t\t\t\t.dst_port_low = 22,\n \t\t\t\t.dst_port_high = 1023,\n \t\t\t\t.src_port_low = 0,\n@@ -263,7 +263,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with dst port 1020 */\n \t\t{\n \t\t\t\t.data = {.userdata = 15, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 310},\n \t\t\t\t.dst_port_low = 1020,\n \t\t\t\t.dst_port_high = 1020,\n \t\t\t\t.src_port_low = 0,\n@@ -272,7 +272,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with dst portrange  1000-2000 */\n \t\t{\n \t\t\t\t.data = {.userdata = 16, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 210},\n \t\t\t\t.dst_port_low = 1000,\n \t\t\t\t.dst_port_high = 2000,\n \t\t\t\t.src_port_low = 0,\n@@ -283,7 +283,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with src port 80 */\n \t\t{\n \t\t\t\t.data = {.userdata = 17, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 320},\n \t\t\t\t.src_port_low = 80,\n \t\t\t\t.src_port_high = 80,\n \t\t\t\t.dst_port_low = 0,\n@@ -292,7 +292,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with src port 22-1023 */\n \t\t{\n \t\t\t\t.data = {.userdata = 18, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 220},\n \t\t\t\t.src_port_low = 22,\n \t\t\t\t.src_port_high = 1023,\n \t\t\t\t.dst_port_low = 0,\n@@ -301,7 +301,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with src port 1020 */\n \t\t{\n \t\t\t\t.data = {.userdata = 19, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 320},\n \t\t\t\t.src_port_low = 1020,\n \t\t\t\t.src_port_high = 1020,\n \t\t\t\t.dst_port_low = 0,\n@@ -310,7 +310,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches everything with src portrange  1000-2000 */\n \t\t{\n \t\t\t\t.data = {.userdata = 20, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 220},\n \t\t\t\t.src_port_low = 1000,\n \t\t\t\t.src_port_high = 2000,\n \t\t\t\t.dst_port_low = 0,\n@@ -321,7 +321,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with protocol number either 0x64 or 0xE4 */\n \t\t{\n \t\t\t\t.data = {.userdata = 21, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 2},\n+\t\t\t\t\t\t.priority = 270},\n \t\t\t\t.proto = 0x64,\n \t\t\t\t.proto_mask = 0x7f,\n \t\t\t\t.src_port_low = 0,\n@@ -343,7 +343,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t/* matches all packets with protocol 5 */\n \t\t{\n \t\t\t\t.data = {.userdata = 23, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 3},\n+\t\t\t\t\t\t.priority = 370},\n \t\t\t\t.proto = 0x5,\n \t\t\t\t.proto_mask = 0xff,\n \t\t\t\t.src_port_low = 0,\n@@ -355,7 +355,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n /* rules combining various fields */\n \t\t{\n \t\t\t\t.data = {.userdata = 24, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 4},\n+\t\t\t\t\t\t.priority = 400},\n \t\t\t\t/** make sure that unmasked bytes don't fail! */\n \t\t\t\t.dst_addr = IPv4(1,2,3,4),\n \t\t\t\t.dst_mask_len = 16,\n@@ -374,7 +374,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t},\n \t\t{\n \t\t\t\t.data = {.userdata = 25, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 4},\n+\t\t\t\t\t\t.priority = 400},\n \t\t\t\t.dst_addr = IPv4(5,6,7,8),\n \t\t\t\t.dst_mask_len = 24,\n \t\t\t\t.src_addr = IPv4(1,2,3,4),\n@@ -392,7 +392,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t},\n \t\t{\n \t\t\t\t.data = {.userdata = 26, .category_mask = ACL_ALLOW_MASK,\n-\t\t\t\t\t\t.priority = 5},\n+\t\t\t\t\t\t.priority = 500},\n \t\t\t\t.dst_addr = IPv4(1,2,3,4),\n \t\t\t\t.dst_mask_len = 8,\n \t\t\t\t.src_addr = IPv4(5,6,7,8),\n@@ -408,7 +408,7 @@ struct rte_acl_ipv4vlan_rule acl_test_rules[] = {\n \t\t},\n \t\t{\n \t\t\t\t.data = {.userdata = 27, .category_mask = ACL_DENY_MASK,\n-\t\t\t\t\t\t.priority = 5},\n+\t\t\t\t\t\t.priority = 500},\n \t\t\t\t.dst_addr = IPv4(5,6,7,8),\n \t\t\t\t.dst_mask_len = 32,\n \t\t\t\t.src_addr = IPv4(1,2,3,4),\n",
    "prefixes": [
        "dpdk-dev",
        "PATCHv2",
        "7/8"
    ]
}