Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52740/?format=api
{ "id": 52740, "url": "http://patches.dpdk.org/api/patches/52740/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412232451.30197-6-yskoh@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412232451.30197-6-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412232451.30197-6-yskoh@mellanox.com", "date": "2019-04-12T23:24:50", "name": "[5/6] build: add option for armv8 crypto extension", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8126708504cd2f6d7b6caccfa1b8993c87c387ea", "submitter": { "id": 636, "url": "http://patches.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412232451.30197-6-yskoh@mellanox.com/mbox/", "series": [ { "id": 4296, "url": "http://patches.dpdk.org/api/series/4296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4296", "date": "2019-04-12T23:24:45", "name": "build: fix build for arm64", "version": 1, "mbox": "http://patches.dpdk.org/series/4296/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52740/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FEF11B3FC;\n\tSat, 13 Apr 2019 01:25:20 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 595D71B41B\n\tfor <dev@dpdk.org>; Sat, 13 Apr 2019 01:25:11 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 13 Apr 2019 02:25:10 +0300", "from mtibiz05-l.mti.labs.mlnx. (mtibiz05-l.mti.labs.mlnx\n\t[10.20.10.109])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3CNOrWK006596;\n\tSat, 13 Apr 2019 02:25:08 +0300" ], "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "bruce.richardson@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com,\n\tshahafs@mellanox.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com,\n\tHonnappa.Nagarahalli@arm.com", "Date": "Fri, 12 Apr 2019 16:24:50 -0700", "Message-Id": "<20190412232451.30197-6-yskoh@mellanox.com>", "X-Mailer": "git-send-email 2.21.0.196.g041f5ea", "In-Reply-To": "<20190412232451.30197-1-yskoh@mellanox.com>", "References": "<20190412232451.30197-1-yskoh@mellanox.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/6] build: add option for armv8 crypto extension", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Per armv8 crypto extension support, make build always enable it by default\nas long as compiler supports the feature while meson build only enables it\nfor 'default' machine of generic armv8 architecture. For example,\nspecifying '-mcpu=cortex-a72' doesn't enable it but '+crypto' is required\nin order to enable the feature.\n\nIt is also known that not all the armv8 platforms have the crypto\nextension. For example, Mellanox BlueField has a variant which doesn't have\nit. If crypto enabled binary runs on such a platform, rte_eal_init() fails.\n\nTherefore, an option to control this feature is necessary. It is still\nenabled by default but can be selectively disabled by vendors.\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n config/arm/meson.build | 16 +++++++++-------\n config/common_armv8a_linux | 1 +\n drivers/crypto/armv8/Makefile | 4 ++++\n meson_options.txt | 2 ++\n mk/machine/armv8a/rte.vars.mk | 4 ++++\n 5 files changed, 20 insertions(+), 7 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 73c581948c..762d222ed5 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -7,6 +7,8 @@ march_opt = '-march=@0@'.format(machine)\n \n arm_force_native_march = false\n \n+crypto_flag = get_option('enable_armv8_crypto') ? '+crypto' : ''\n+\n flags_common_default = [\n \t# Accelarate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest)\n \t# to determine the best threshold in code. Refer to notes in source file\n@@ -70,14 +72,14 @@ flags_octeontx2_extra = [\n \t['RTE_USE_C11_MEM_MODEL', true]]\n \n machine_args_generic = [\n-\t['default', ['-march=armv8-a+crc+crypto']],\n+\t['default', ['-march=armv8-a+crc' + crypto_flag]],\n \t['native', ['-march=native']],\n-\t['0xd03', ['-mcpu=cortex-a53']],\n-\t['0xd04', ['-mcpu=cortex-a35']],\n-\t['0xd07', ['-mcpu=cortex-a57']],\n-\t['0xd08', ['-mcpu=cortex-a72'], flags_cortex_a72_extra],\n-\t['0xd09', ['-mcpu=cortex-a73']],\n-\t['0xd0a', ['-mcpu=cortex-a75']]]\n+\t['0xd03', ['-mcpu=cortex-a53' + crypto_flag]],\n+\t['0xd04', ['-mcpu=cortex-a35' + crypto_flag]],\n+\t['0xd07', ['-mcpu=cortex-a57' + crypto_flag]],\n+\t['0xd08', ['-mcpu=cortex-a72' + crypto_flag], flags_cortex_a72_extra],\n+\t['0xd09', ['-mcpu=cortex-a73' + crypto_flag]],\n+\t['0xd0a', ['-mcpu=cortex-a75' + crypto_flag]]]\n \n machine_args_cavium = [\n \t['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],\ndiff --git a/config/common_armv8a_linux b/config/common_armv8a_linux\nindex 72091de1c7..0efa3e2eb2 100644\n--- a/config/common_armv8a_linux\n+++ b/config/common_armv8a_linux\n@@ -5,6 +5,7 @@\n #include \"common_linux\"\n \n CONFIG_RTE_MACHINE=\"armv8a\"\n+CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y\n \n CONFIG_RTE_ARCH=\"arm64\"\n CONFIG_RTE_ARCH_ARM64=y\ndiff --git a/drivers/crypto/armv8/Makefile b/drivers/crypto/armv8/Makefile\nindex f71f6b14a4..867a5206cf 100644\n--- a/drivers/crypto/armv8/Makefile\n+++ b/drivers/crypto/armv8/Makefile\n@@ -4,6 +4,10 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ifneq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y)\n+$(error \"Please enable CONFIG_RTE_ENABLE_ARMV8_CRYPTO\")\n+endif\n+\n ifneq ($(MAKECMDGOALS),clean)\n ifneq ($(MAKECMDGOALS),config)\n ifeq ($(ARMV8_CRYPTO_LIB_PATH),)\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 16d9f92c65..4ca09771de 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -4,6 +4,8 @@ option('allow_invalid_socket_id', type: 'boolean', value: false,\n \tdescription: 'allow out-of-range NUMA socket id\\'s for platforms that don\\'t report the value correctly')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n \tdescription: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n+option('enable_armv8_crypto', type: 'boolean', value: true,\n+\tdescription: 'enable armv8 crypto extension')\n option('enable_docs', type: 'boolean', value: false,\n \tdescription: 'build documentation')\n option('enable_kmods', type: 'boolean', value: true,\ndiff --git a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk\nindex 8252efbb7b..4893d01a2d 100644\n--- a/mk/machine/armv8a/rte.vars.mk\n+++ b/mk/machine/armv8a/rte.vars.mk\n@@ -28,4 +28,8 @@\n # CPU_LDFLAGS =\n # CPU_ASFLAGS =\n \n+ifeq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y)\n MACHINE_CFLAGS += -march=armv8-a+crc+crypto\n+else\n+MACHINE_CFLAGS += -march=armv8-a+crc\n+endif\n", "prefixes": [ "5/6" ] }