Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52594/?format=api
{ "id": 52594, "url": "http://patches.dpdk.org/api/patches/52594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554900829-16180-4-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554900829-16180-4-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554900829-16180-4-git-send-email-david.marchand@redhat.com", "date": "2019-04-10T12:53:48", "name": "[3/4] net/bonding: fix unicast packets filtering when not in promisc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e318ecbf1eccb9b030a2bc346e567f63fdc2671b", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554900829-16180-4-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4240, "url": "http://patches.dpdk.org/api/series/4240/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4240", "date": "2019-04-10T12:53:45", "name": "lacp rx/tx handlers fixes for bonding pmd", "version": 1, "mbox": "http://patches.dpdk.org/series/4240/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52594/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52594/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 265FD1B13B;\n\tWed, 10 Apr 2019 14:54:20 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id ACEAF1B118;\n\tWed, 10 Apr 2019 14:54:08 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 13A633001244;\n\tWed, 10 Apr 2019 12:54:08 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C4B5261B7F;\n\tWed, 10 Apr 2019 12:54:06 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\tp.oltarzewski@gmail.com,\n\tstable@dpdk.org", "Date": "Wed, 10 Apr 2019 14:53:48 +0200", "Message-Id": "<1554900829-16180-4-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1554900829-16180-1-git-send-email-david.marchand@redhat.com>", "References": "<1554900829-16180-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.45]); Wed, 10 Apr 2019 12:54:08 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 3/4] net/bonding: fix unicast packets filtering\n\twhen not in promisc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By default, the 802.3ad code enables promisc mode on all slaves.\nTo avoid all packets going to the application (unless the application\nasked for promiscuous mode), all frames are supposed to be filtered in\nthe rx burst handler.\n\nHowever the incriminated commit broke this because non pure ethernet\nframes (basically any unicast Ether()/IP() packet) are not filtered\nanymore.\n\nFixes: 71b7b37ec959 (\"net/bonding: use ptype flags for LACP Rx filtering\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 7 -------\n 1 file changed, 7 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 989be5c..9ef0717 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -305,13 +305,6 @@\n \n \t\t/* Handle slow protocol packets. */\n \t\twhile (j < num_rx_total) {\n-\n-\t\t\t/* If packet is not pure L2 and is known, skip it */\n-\t\t\tif ((bufs[j]->packet_type & ~RTE_PTYPE_L2_ETHER) != 0) {\n-\t\t\t\tj++;\n-\t\t\t\tcontinue;\n-\t\t\t}\n-\n \t\t\tif (j + 3 < num_rx_total)\n \t\t\t\trte_prefetch0(rte_pktmbuf_mtod(bufs[j + 3], void *));\n \n", "prefixes": [ "3/4" ] }