Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52573/?format=api
{ "id": 52573, "url": "http://patches.dpdk.org/api/patches/52573/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f9cc02c3c9a362a3631ba994ae4aba97e026c871.1554894242.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f9cc02c3c9a362a3631ba994ae4aba97e026c871.1554894242.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f9cc02c3c9a362a3631ba994ae4aba97e026c871.1554894242.git.igor.russkikh@aquantia.com", "date": "2019-04-10T11:19:06", "name": "[07/10] net/atlantic: interrupt handling of macsec events", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "83725526269681b99bff58e2f20fe4d893332e0a", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f9cc02c3c9a362a3631ba994ae4aba97e026c871.1554894242.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4234, "url": "http://patches.dpdk.org/api/series/4234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4234", "date": "2019-04-10T11:18:35", "name": "add MACSEC hw offload to atlantic PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/4234/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52573/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3469D5F3B;\n\tWed, 10 Apr 2019 13:19:11 +0200 (CEST)", "from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr820058.outbound.protection.outlook.com [40.107.82.58])\n\tby dpdk.org (Postfix) with ESMTP id 3A64B5F3B\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 13:19:08 +0200 (CEST)", "from BN8PR11MB3618.namprd11.prod.outlook.com (20.178.219.85) by\n\tBN8PR11MB3540.namprd11.prod.outlook.com (20.178.218.78) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.21; Wed, 10 Apr 2019 11:19:06 +0000", "from BN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489]) by\n\tBN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489%3]) with mapi id 15.20.1771.016;\n\tWed, 10 Apr 2019 11:19:06 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=udffeqgbtO0LympPSHEp25yMitGXwIuFX+5JC1ih4YI=;\n\tb=bAhleyRW0N39WFLkrN+PTwIHMO4jpmUoBZC9okzx29gbhGaNdHH+5cp3jtY3J8czFXYMr4SImJp/fzZMYwIIr7d88Nl65OcOm/U4eVLr9vFz3kYnHmDyGO/I2gsuOTL+oSyRQsWvMk7zeMtrdVWcbmg/5mZgkmT0Yi8PzhKAO4c=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Wenzhuo Lu\n\t<wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard\n\tIremonger <bernard.iremonger@intel.com>, John McNamara\n\t<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew\n\tRybchenko <arybchenko@solarflare.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 07/10] net/atlantic: interrupt handling of macsec events", "Thread-Index": "AQHU7482sZt/+MRXU0u99ZqemArkog==", "Date": "Wed, 10 Apr 2019 11:19:06 +0000", "Message-ID": "<f9cc02c3c9a362a3631ba994ae4aba97e026c871.1554894242.git.igor.russkikh@aquantia.com>", "References": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR05CA0061.namprd05.prod.outlook.com\n\t(2603:10b6:a03:74::38) To BN8PR11MB3618.namprd11.prod.outlook.com\n\t(2603:10b6:408:85::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "6599ff26-e09c-46e9-0a8c-08d6bda65832", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:BN8PR11MB3540; ", "x-ms-traffictypediagnostic": "BN8PR11MB3540:", "x-microsoft-antispam-prvs": "<BN8PR11MB35408247B1BD8B89C1C4F72D982E0@BN8PR11MB3540.namprd11.prod.outlook.com>", "x-forefront-prvs": "00032065B2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(39850400004)(376002)(366004)(136003)(346002)(199004)(189003)(486006)(107886003)(6506007)(316002)(2616005)(386003)(54906003)(7416002)(53936002)(8936002)(68736007)(446003)(6916009)(476003)(72206003)(2501003)(105586002)(11346002)(44832011)(99286004)(2351001)(52116002)(186003)(26005)(118296001)(106356001)(14454004)(102836004)(76176011)(71200400001)(81156014)(7736002)(14444005)(8676002)(81166006)(25786009)(256004)(6116002)(5660300002)(71190400001)(1730700003)(5640700003)(2906002)(66066001)(6512007)(478600001)(6486002)(50226002)(305945005)(97736004)(4326008)(3846002)(36756003)(6436002)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3540;\n\tH:BN8PR11MB3618.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "Q4lhObe/fgAHG6q0p7A8NIuOnHsnIc38xX14MzIWTB5SwKJfyKXgrMYlh1T7yjA8kxcydQcXkTApt6ygUMdPBrJIat5dIOBpPBYKskWuzx0JQ3Aci9lY3t7U2q4gxk2WcfS2o7zrntTx5xkooJ6wTmx2Rb2DbKmHdetWMwDX+QJHE8BVV7NrSMGK7YN9I1QU4DNkQLjZOiNEQ6k0q/Dal2gTKEwuY/1mTe5LBUJEhq54jErVb6Xy/VPTCYz9ddvfBgcvvPTcyRSLcia970PTaOzE7g5sl3tfLOrBXQWvH8epA32riMnPbBgT53dAAKBINkGmAqwSPnXw+fd3anlwnusP/vaRGG9Iv7/KR+ko+Rbu2F8M4qkyspWoAqqVElp4fhY2bp+OxGmQpqxGImr+39+Y2Y6airQtW3Fwo8O4bhY=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "6599ff26-e09c-46e9-0a8c-08d6bda65832", "X-MS-Exchange-CrossTenant-originalarrivaltime": "10 Apr 2019 11:19:06.7163\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR11MB3540", "Subject": "[dpdk-dev] [PATCH 07/10] net/atlantic: interrupt handling of macsec\n\tevents", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nMACSEC should be configured only after link up event, thus we use\nlink interrupt to file an alarm for configuration.\n\nFW also uses link interrupt line to indicate incoming events from\nMACSEC. These may include key expiration, packet counter wrap, etc.\nWe pass these events to the upper layers.\n\nSigned-off-by: Pavel Belous <pavel.belous@aquantia.com>\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_ethdev.c | 66 ++++++++++++++++++++++++++-----\n drivers/net/atlantic/atl_ethdev.h | 2 +-\n 2 files changed, 57 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\r\nindex 502ef5308b4d..4a6975dcf104 100644\r\n--- a/drivers/net/atlantic/atl_ethdev.c\r\n+++ b/drivers/net/atlantic/atl_ethdev.c\r\n@@ -4,6 +4,7 @@\r\n \r\n #include <rte_string_fns.h>\r\n #include <rte_ethdev_pci.h>\r\n+#include <rte_alarm.h>\r\n \r\n #include \"atl_ethdev.h\"\r\n #include \"atl_common.h\"\r\n@@ -1089,13 +1090,20 @@ atl_dev_supported_ptypes_get(struct rte_eth_dev *dev)\r\n \treturn NULL;\r\n }\r\n \r\n+static void\r\n+atl_dev_delayed_handler(void *param)\r\n+{\r\n+\tstruct rte_eth_dev *dev = (struct rte_eth_dev *)param;\r\n+\r\n+\tatl_dev_configure_macsec(dev);\r\n+}\r\n+\r\n+\r\n /* return 0 means link status changed, -1 means not changed */\r\n static int\r\n atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n {\r\n \tstruct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n-\tstruct atl_interrupt *intr =\r\n-\t\tATL_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\r\n \tstruct rte_eth_link link, old;\r\n \tint err = 0;\r\n \r\n@@ -1122,8 +1130,6 @@ atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n \t\treturn 0;\r\n \t}\r\n \r\n-\tintr->flags &= ~ATL_FLAG_NEED_LINK_CONFIG;\r\n-\r\n \tlink.link_status = ETH_LINK_UP;\r\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\r\n \tlink.link_speed = hw->aq_link_status.mbps;\r\n@@ -1133,6 +1139,10 @@ atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n \tif (link.link_status == old.link_status)\r\n \t\treturn -1;\r\n \r\n+\tif (rte_eal_alarm_set(1000 * 1000,\r\n+\t\t\t atl_dev_delayed_handler, (void *)dev) < 0)\r\n+\t\tPMD_DRV_LOG(ERR, \"rte_eal_alarm_set fail\");\r\n+\r\n \treturn 0;\r\n }\r\n \r\n@@ -1210,8 +1220,9 @@ atl_dev_interrupt_get_status(struct rte_eth_dev *dev)\r\n \thw_atl_b0_hw_irq_read(hw, &cause);\r\n \r\n \tatl_disable_intr(hw);\r\n-\tintr->flags = cause & BIT(ATL_IRQ_CAUSE_LINK) ?\r\n-\t\t\tATL_FLAG_NEED_LINK_UPDATE : 0;\r\n+\r\n+\tif (cause & BIT(ATL_IRQ_CAUSE_LINK))\r\n+\t\tintr->flags |= ATL_FLAG_NEED_LINK_UPDATE;\r\n \r\n \treturn 0;\r\n }\r\n@@ -1276,15 +1287,50 @@ atl_dev_interrupt_action(struct rte_eth_dev *dev,\r\n {\r\n \tstruct atl_interrupt *intr =\r\n \t\tATL_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\r\n+\tstruct atl_adapter *adapter =\r\n+\t\t(struct atl_adapter *)dev->data->dev_private;\r\n+\tstruct aq_hw_s *hw = &adapter->hw;\r\n+\r\n+\tif (!(intr->flags & ATL_FLAG_NEED_LINK_UPDATE))\r\n+\t\tgoto done;\r\n \r\n-\tif (intr->flags & ATL_FLAG_NEED_LINK_UPDATE) {\r\n-\t\tatl_dev_link_update(dev, 0);\r\n-\t\tintr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;\r\n+\tintr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;\r\n+\r\n+\t/* Notify userapp if link status changed */\r\n+\tif (!atl_dev_link_update(dev, 0)) {\r\n \t\tatl_dev_link_status_print(dev);\r\n \t\t_rte_eth_dev_callback_process(dev,\r\n \t\t\tRTE_ETH_EVENT_INTR_LSC, NULL);\r\n+\t} else {\r\n+\t\tif (hw->aq_fw_ops->send_macsec_req == NULL)\r\n+\t\t\tgoto done;\r\n+\r\n+\t\t/* Check macsec Keys expired */\r\n+\t\tstruct get_stats req = { 0 };\r\n+\t\tstruct macsec_msg_fw_request msg = { 0 };\r\n+\t\tstruct macsec_msg_fw_response resp = { 0 };\r\n+\r\n+\t\treq.ingress_sa_index = 0x0;\r\n+\t\treq.egress_sc_index = 0x0;\r\n+\t\treq.egress_sa_index = 0x0;\r\n+\t\tmsg.msg_type = macsec_get_stats_msg;\r\n+\t\tmsg.stats = req;\r\n+\r\n+\t\tint err = hw->aq_fw_ops->send_macsec_req(hw, &msg, &resp);\r\n+\t\tif (err) {\r\n+\t\t\tPMD_DRV_LOG(ERR, \"send_macsec_req fail\");\r\n+\t\t\tgoto done;\r\n+\t\t}\r\n+\t\tif (resp.stats.egress_threshold_expired ||\r\n+\t\t resp.stats.ingress_threshold_expired ||\r\n+\t\t resp.stats.egress_expired ||\r\n+\t\t resp.stats.ingress_expired) {\r\n+\t\t\tPMD_DRV_LOG(INFO, \"RTE_ETH_EVENT_MACSEC\");\r\n+\t\t\t_rte_eth_dev_callback_process(dev,\r\n+\t\t\t\tRTE_ETH_EVENT_MACSEC, NULL);\r\n+\t\t}\r\n \t}\r\n-\r\n+done:\r\n \tatl_enable_intr(dev);\r\n \trte_intr_enable(intr_handle);\r\n \r\ndiff --git a/drivers/net/atlantic/atl_ethdev.h b/drivers/net/atlantic/atl_ethdev.h\r\nindex 1e29999b539c..cdb48e79472d 100644\r\n--- a/drivers/net/atlantic/atl_ethdev.h\r\n+++ b/drivers/net/atlantic/atl_ethdev.h\r\n@@ -34,7 +34,7 @@\r\n \t(&((struct atl_adapter *)adapter)->hw_cfg)\r\n \r\n #define ATL_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)\r\n-#define ATL_FLAG_NEED_LINK_CONFIG (uint32_t)(4 << 0)\r\n+#define ATL_FLAG_MACSEC (uint32_t)(4 << 0)\r\n \r\n struct atl_interrupt {\r\n \tuint32_t flags;\r\n", "prefixes": [ "07/10" ] }