Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52254/?format=api
{ "id": 52254, "url": "http://patches.dpdk.org/api/patches/52254/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/b036af0fba4b8ccf9c7554d02bebf374d2ef6f9e.1554354506.git.shahafs@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b036af0fba4b8ccf9c7554d02bebf374d2ef6f9e.1554354506.git.shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b036af0fba4b8ccf9c7554d02bebf374d2ef6f9e.1554354506.git.shahafs@mellanox.com", "date": "2019-04-04T05:14:42", "name": "[v2,2/3] app/testpmd: support creation of no IOVA contig mempools", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e31672fcdfe8b34c4f9ce6e3cd5ddb4861f4fb99", "submitter": { "id": 634, "url": "http://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/b036af0fba4b8ccf9c7554d02bebf374d2ef6f9e.1554354506.git.shahafs@mellanox.com/mbox/", "series": [ { "id": 4104, "url": "http://patches.dpdk.org/api/series/4104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4104", "date": "2019-04-04T05:14:43", "name": "DMA map anonymous memory to eth devices", "version": 2, "mbox": "http://patches.dpdk.org/series/4104/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52254/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 38A554CA6;\n\tThu, 4 Apr 2019 07:15:01 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 6A97D4C96\n\tfor <dev@dpdk.org>; Thu, 4 Apr 2019 07:14:55 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tshahafs@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 4 Apr 2019 08:14:50 +0300", "from unicorn01.mtl.labs.mlnx. (unicorn01.mtl.labs.mlnx\n\t[10.7.12.62])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x345Eogl010614;\n\tThu, 4 Apr 2019 08:14:50 +0300" ], "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com", "Cc": "dev@dpdk.org, rasland@mellanox.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com", "Date": "Thu, 4 Apr 2019 08:14:42 +0300", "Message-Id": "<b036af0fba4b8ccf9c7554d02bebf374d2ef6f9e.1554354506.git.shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<cover.1554354506.git.shahafs@mellanox.com>", "References": "<cover.1554114165.git.shahafs@mellanox.com>\n\t<cover.1554354506.git.shahafs@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 2/3] app/testpmd: support creation of no IOVA\n\tcontig mempools", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "providing a command line parameter to set the mempool flags accordingly.\nThis mode is relevant only when creating an empty mempool and then\npopulating with memory.\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n app/test-pmd/parameters.c | 13 +++++++++++++\n app/test-pmd/testpmd.c | 3 ++-\n app/test-pmd/testpmd.h | 2 ++\n doc/guides/testpmd_app_ug/run_app.rst | 5 +++++\n 4 files changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 7b6b60905d..7f18b3e748 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -202,6 +202,8 @@ usage(char* progname)\n \tprintf(\" --noisy-lkup-num-writes=N: do N random writes per packet\\n\");\n \tprintf(\" --noisy-lkup-num-reads=N: do N random reads per packet\\n\");\n \tprintf(\" --noisy-lkup-num-writes=N: do N random reads and writes per packet\\n\");\n+\tprintf(\" --no-iova-contig: mempool memory can be IOVA non contiguous. \"\n+\t \"valid only with --mp-alloc=anon\\n\");\n }\n \n #ifdef RTE_LIBRTE_CMDLINE\n@@ -651,6 +653,7 @@ launch_args_parse(int argc, char** argv)\n \t\t{ \"noisy-lkup-num-writes\",\t1, 0, 0 },\n \t\t{ \"noisy-lkup-num-reads\",\t1, 0, 0 },\n \t\t{ \"noisy-lkup-num-reads-writes\", 1, 0, 0 },\n+\t\t{ \"no-iova-contig\", 0, 0, 0 },\n \t\t{ 0, 0, 0, 0 },\n \t};\n \n@@ -1242,6 +1245,8 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t \"noisy-lkup-num-reads-writes must be >= 0\\n\");\n \t\t\t}\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"no-iova-contig\"))\n+\t\t\t\tmempool_flags = MEMPOOL_F_NO_IOVA_CONTIG;\n \t\t\tbreak;\n \t\tcase 'h':\n \t\t\tusage(argv[0]);\n@@ -1258,4 +1263,12 @@ launch_args_parse(int argc, char** argv)\n \t/* Set offload configuration from command line parameters. */\n \trx_mode.offloads = rx_offloads;\n \ttx_mode.offloads = tx_offloads;\n+\n+\tif (mempool_flags & MEMPOOL_F_NO_IOVA_CONTIG &&\n+\t mp_alloc_type != MP_ALLOC_ANON) {\n+\t\tTESTPMD_LOG(WARNING, \"cannot use no-iova-contig without \"\n+\t\t\t\t \"mp-alloc=anon. mempool no-iova-contig is \"\n+\t\t\t\t \"ignored\\n\");\n+\t\tmempool_flags = 0;\n+\t}\n }\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 5c68eb9ec6..dd449a9859 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -189,6 +189,7 @@ struct fwd_engine * fwd_engines[] = {\n };\n \n struct rte_mempool *mempools[RTE_MAX_NUMA_NODES];\n+uint16_t mempool_flags;\n \n struct fwd_config cur_fwd_config;\n struct fwd_engine *cur_fwd_eng = &io_fwd_engine; /**< IO mode by default. */\n@@ -867,7 +868,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,\n \t\t\trte_mp = rte_mempool_create_empty(pool_name, nb_mbuf,\n \t\t\t\tmb_size, (unsigned int) mb_mempool_cache,\n \t\t\t\tsizeof(struct rte_pktmbuf_pool_private),\n-\t\t\t\tsocket_id, 0);\n+\t\t\t\tsocket_id, mempool_flags);\n \t\t\tif (rte_mp == NULL)\n \t\t\t\tgoto err;\n \ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 84ce8ffa2f..46d26181dd 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -266,6 +266,8 @@ extern struct fwd_engine * fwd_engines[]; /**< NULL terminated array. */\n \n extern struct rte_mempool *mempools[RTE_MAX_NUMA_NODES];\n \n+extern uint16_t mempool_flags;\n+\n /**\n * Forwarding Configuration\n *\ndiff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst\nindex b717b8c7b7..7b4341647f 100644\n--- a/doc/guides/testpmd_app_ug/run_app.rst\n+++ b/doc/guides/testpmd_app_ug/run_app.rst\n@@ -427,3 +427,8 @@ The commandline options are:\n \n Set the number of r/w accesses to be done in noisy neighbour simulation memory buffer to N.\n Only available with the noisy forwarding mode. The default value is 0.\n+\n+* ``--no-iova-contig``\n+\n+ Enable to create mempool which is not IOVA contiguous. Valid only with --mp-alloc=anon.\n+ The default value is 0.\n", "prefixes": [ "v2", "2/3" ] }