Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52056/?format=api
{ "id": 52056, "url": "http://patches.dpdk.org/api/patches/52056/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554190805-376-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554190805-376-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554190805-376-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-04-02T07:40:05", "name": "[1/1] net/mlx5: fix typos in comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b75b42eb6a34642670248ff297c7e3ba946bd1a", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554190805-376-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 4046, "url": "http://patches.dpdk.org/api/series/4046/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4046", "date": "2019-04-02T07:40:05", "name": "[1/1] net/mlx5: fix typos in comments", "version": 1, "mbox": "http://patches.dpdk.org/series/4046/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52056/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/52056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE6152E81;\n\tTue, 2 Apr 2019 09:40:13 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id BAF7E2C36\n\tfor <dev@dpdk.org>; Tue, 2 Apr 2019 09:40:11 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 2 Apr 2019 10:40:07 +0300", "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x327e6sK004873;\n\tTue, 2 Apr 2019 10:40:06 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "shahafs@mellanox.com", "Date": "Tue, 2 Apr 2019 07:40:05 +0000", "Message-Id": "<1554190805-376-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 299d7dc28c37 (\"net/mlx5: add representor recognition on Linux 5.x\")\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 14 +++++++-------\n drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++-----------\n 2 files changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 96ad4c6..7d322b6 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -149,7 +149,7 @@ struct mlx5_dev_spawn_data {\n * port dedicated IB device, the context will be used by only given\n * port due to unification.\n *\n- * Routine first searches the context for the spesified IB device name,\n+ * Routine first searches the context for the specified IB device name,\n * if found the shared context assumed and reference counter is incremented.\n * If no context found the new one is created and initialized with specified\n * IB device context and parameters.\n@@ -179,7 +179,7 @@ struct mlx5_dev_spawn_data {\n \t\t\tgoto exit;\n \t\t}\n \t}\n-\t/* No device found, we have to create new sharted context. */\n+\t/* No device found, we have to create new shared context. */\n \tassert(spawn->max_port);\n \tsh = rte_zmalloc(\"ethdev shared ib context\",\n \t\t\t sizeof(struct mlx5_ibv_shared) +\n@@ -300,7 +300,7 @@ struct mlx5_dev_spawn_data {\n /**\n * Initialize DV/DR related data within private structure.\n * Routine checks the reference counter and does actual\n- * resources creation/iniialization only if counter is zero.\n+ * resources creation/initialization only if counter is zero.\n *\n * @param[in] priv\n * Pointer to the private device data structure.\n@@ -1228,7 +1228,7 @@ struct mlx5_dev_spawn_data {\n \t * Currently we support single E-Switch per PF configurations\n \t * only and vport_id field contains the vport index for\n \t * associated VF, which is deduced from representor port name.\n-\t * For exapmple, let's have the IB device port 10, it has\n+\t * For example, let's have the IB device port 10, it has\n \t * attached network device eth0, which has port name attribute\n \t * pf0vf2, we can deduce the VF number as 2, and set vport index\n \t * as 3 (2+1). This assigning schema should be changed if the\n@@ -1483,7 +1483,7 @@ struct mlx5_dev_spawn_data {\n \tmlx5_set_link_up(eth_dev);\n \t/*\n \t * Even though the interrupt handler is not installed yet,\n-\t * interrupts will still trigger on the asyn_fd from\n+\t * interrupts will still trigger on the async_fd from\n \t * Verbs context returned by ibv_open_device().\n \t */\n \tmlx5_link_update(eth_dev, 0);\n@@ -1656,7 +1656,7 @@ struct mlx5_dev_spawn_data {\n \t}\n \tibv_match[nd] = NULL;\n \tif (!nd) {\n-\t\t/* No device macthes, just complain and bail out. */\n+\t\t/* No device matches, just complain and bail out. */\n \t\tmlx5_glue->free_device_list(ibv_list);\n \t\tDRV_LOG(WARNING,\n \t\t\t\"no Verbs device matches PCI device \" PCI_PRI_FMT \",\"\n@@ -1689,7 +1689,7 @@ struct mlx5_dev_spawn_data {\n \n \tif (np > 1) {\n \t\t/*\n-\t\t * Signle IB device with multiple ports found,\n+\t\t * Single IB device with multiple ports found,\n \t\t * it may be E-Switch master device and representors.\n \t\t * We have to perform identification trough the ports.\n \t\t */\ndiff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c\nindex 3006f83..fc04c9d 100644\n--- a/drivers/net/mlx5/mlx5_flow_tcf.c\n+++ b/drivers/net/mlx5/mlx5_flow_tcf.c\n@@ -2916,7 +2916,7 @@ struct pedit_parser {\n * VXLAN VNI in 24-bit wire format.\n *\n * @return\n- * VXLAN VNI as a 32-bit integer value in network endian.\n+ * VXLAN VNI as a 32-bit integer value in network endianness.\n */\n static inline rte_be32_t\n vxlan_vni_as_be32(const uint8_t vni[3])\n@@ -4051,7 +4051,7 @@ struct pedit_parser {\n \tnlh->nlmsg_flags |= NLM_F_ACK;\n \tret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len);\n \tif (ret <= 0) {\n-\t\t/* Message send error occurres. */\n+\t\t/* Message send error occurred. */\n \t\trte_errno = errno;\n \t\treturn -rte_errno;\n \t}\n@@ -4307,7 +4307,7 @@ struct tcf_nlcb_context {\n * @param[in] tcf\n * Context object initialized by mlx5_flow_tcf_context_create().\n * @param[in] ifindex\n- * Network inferface index to perform cleanup.\n+ * Network interface index to perform cleanup.\n */\n static void\n flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf,\n@@ -4343,7 +4343,7 @@ struct tcf_nlcb_context {\n }\n \n /**\n- * Collect neigh permament rules on specified network device.\n+ * Collect neigh permanent rules on specified network device.\n * This is callback routine called by libmnl mnl_cb_run() in loop for\n * every message in received packet.\n *\n@@ -4392,7 +4392,7 @@ struct tcf_nlcb_context {\n \t}\n \tif (!na_mac || !na_ip)\n \t\treturn 1;\n-\t/* Neigh rule with permenent attribute found. */\n+\t/* Neigh rule with permanent attribute found. */\n \tsize = MNL_ALIGN(sizeof(struct nlmsghdr)) +\n \t MNL_ALIGN(sizeof(struct ndmsg)) +\n \t SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +\n@@ -4431,7 +4431,7 @@ struct tcf_nlcb_context {\n * @param[in] tcf\n * Context object initialized by mlx5_flow_tcf_context_create().\n * @param[in] ifindex\n- * Network inferface index to perform cleanup.\n+ * Network interface index to perform cleanup.\n */\n static void\n flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf,\n@@ -4599,7 +4599,7 @@ struct tcf_nlcb_context {\n * Note that an implicit route is maintained by the kernel due to the\n * presence of a peer address (IFA_ADDRESS).\n *\n- * These rules are used for encapsultion only and allow to assign\n+ * These rules are used for encapsulation only and allow to assign\n * the outer tunnel source IP address.\n *\n * @param[in] tcf\n@@ -5018,7 +5018,7 @@ struct tcf_nlcb_context {\n \n /**\n * Releases VXLAN encap rules container by pointer. Decrements the\n- * reference cointer and deletes the container if counter is zero.\n+ * reference counter and deletes the container if counter is zero.\n *\n * @param[in] irule\n * VXLAN rule container pointer to release.\n@@ -5042,7 +5042,7 @@ struct tcf_nlcb_context {\n * @param[in] tcf\n * Context object initialized by mlx5_flow_tcf_context_create().\n * @param[in] vtep\n- * Object represinting the network device to delete. Memory\n+ * Object representing the network device to delete. Memory\n * allocated for this object is freed by routine.\n */\n static void\n@@ -5268,7 +5268,7 @@ struct tcf_nlcb_context {\n }\n \n /**\n- * Aqcuire target interface index for VXLAN tunneling encapsulation.\n+ * Acquire target interface index for VXLAN tunneling encapsulation.\n *\n * @param[in] tcf\n * Context object initialized by mlx5_flow_tcf_context_create().\n@@ -5601,7 +5601,7 @@ struct tcf_nlcb_query {\n /**\n * Fetch the applied rule handle. This is callback routine called by\n * libmnl mnl_cb_run() in loop for every message in received packet.\n- * When the NLM_F_ECHO flag i sspecified the kernel sends the created\n+ * When the NLM_F_ECHO flag is specified the kernel sends the created\n * rule descriptor back to the application and we can retrieve the\n * actual rule handle from updated descriptor.\n *\n", "prefixes": [ "1/1" ] }