Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51905/?format=api
{ "id": 51905, "url": "http://patches.dpdk.org/api/patches/51905/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com", "date": "2019-03-29T10:57:08", "name": "fbarray: fix init unlock without lock", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5f1d3686246a559b8f2c80089c82e9e858e8a209", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 3994, "url": "http://patches.dpdk.org/api/series/3994/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3994", "date": "2019-03-29T10:57:08", "name": "fbarray: fix init unlock without lock", "version": 1, "mbox": "http://patches.dpdk.org/series/3994/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51905/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/51905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C9AB3977;\n\tFri, 29 Mar 2019 11:57:13 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 558264C9F\n\tfor <dev@dpdk.org>; Fri, 29 Mar 2019 11:57:11 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 03:57:10 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 29 Mar 2019 03:57:09 -0700", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx2TAv8CB017545; Fri, 29 Mar 2019 10:57:08 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x2TAv8BX001511;\n\tFri, 29 Mar 2019 10:57:08 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x2TAv8pD001506;\n\tFri, 29 Mar 2019 10:57:08 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,284,1549958400\"; d=\"scan'208\";a=\"146312056\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "dariusz.stojaczyk@intel.com, gavin.hu@arm.com", "Date": "Fri, 29 Mar 2019 10:57:08 +0000", "Message-Id": "<35fe9a105fbf7868fc34cef330745b33acd0527c.1553856703.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] fbarray: fix init unlock without lock", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Certain failure paths of rte_fbarray_init() will unlock the\nmem area lock without locking it first. Fix this by properly\nhandling the failures.\n\nFixes: 5b61c62cfd76 (\"fbarray: add internal tailq for mapped areas\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_fbarray.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c\nindex 0e7366e5e..f852c7f50 100644\n--- a/lib/librte_eal/common/eal_common_fbarray.c\n+++ b/lib/librte_eal/common/eal_common_fbarray.c\n@@ -736,15 +736,19 @@ rte_fbarray_init(struct rte_fbarray *arr, const char *name, unsigned int len,\n \t}\n \n \tpage_sz = sysconf(_SC_PAGESIZE);\n-\tif (page_sz == (size_t)-1)\n-\t\tgoto fail;\n+\tif (page_sz == (size_t)-1) {\n+\t\tfree(ma);\n+\t\treturn -1;\n+\t}\n \n \t/* calculate our memory limits */\n \tmmap_len = calc_data_size(page_sz, elt_sz, len);\n \n \tdata = eal_get_virtual_area(NULL, &mmap_len, page_sz, 0, 0);\n-\tif (data == NULL)\n-\t\tgoto fail;\n+\tif (data == NULL) {\n+\t\tfree(ma);\n+\t\treturn -1;\n+\t}\n \n \trte_spinlock_lock(&mem_area_lock);\n \n", "prefixes": [] }