Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51826/?format=api
{ "id": 51826, "url": "http://patches.dpdk.org/api/patches/51826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190328022115.4660-2-anand.rawat@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190328022115.4660-2-anand.rawat@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190328022115.4660-2-anand.rawat@intel.com", "date": "2019-03-28T02:21:08", "name": "[v6,1/8] eal: eal stub to add windows support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c065657ccfe481020e7773bb675c708b62dfa427", "submitter": { "id": 1231, "url": "http://patches.dpdk.org/api/people/1231/?format=api", "name": "Anand Rawat", "email": "anand.rawat@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190328022115.4660-2-anand.rawat@intel.com/mbox/", "series": [ { "id": 3962, "url": "http://patches.dpdk.org/api/series/3962/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3962", "date": "2019-03-28T02:21:09", "name": "HelloWorld example for windows", "version": 6, "mbox": "http://patches.dpdk.org/series/3962/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51826/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/51826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4051F5B2E;\n\tThu, 28 Mar 2019 03:21:35 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id C72C15B12\n\tfor <dev@dpdk.org>; Thu, 28 Mar 2019 03:21:17 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Mar 2019 19:21:16 -0700", "from anandraw-devbx.amr.corp.intel.com ([10.19.242.57])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Mar 2019 19:21:15 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,278,1549958400\"; d=\"scan'208\";a=\"331369606\"", "From": "Anand Rawat <anand.rawat@intel.com>", "To": "dev@dpdk.org", "Cc": "anand.rawat@intel.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, \n\tjeffrey.b.shaw@intel.com, bruce.richardson@intel.com, thomas@monjalon.net", "Date": "Wed, 27 Mar 2019 19:21:08 -0700", "Message-Id": "<20190328022115.4660-2-anand.rawat@intel.com>", "X-Mailer": "git-send-email 2.17.1.windows.2", "In-Reply-To": "<20190328022115.4660-1-anand.rawat@intel.com>", "References": "<20190306041634.12976-1-anand.rawat@intel.com>\n\t<20190328022115.4660-1-anand.rawat@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 1/8] eal: eal stub to add windows support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added initial stub source files for windows support\nand only the required meson changes for windows.\n\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nSigned-off-by: Anand Rawat <anand.rawat@intel.com>\nReviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n config/meson.build | 23 ++++++++++++------\n config/x86/meson.build | 14 ++++++-----\n lib/librte_eal/meson.build | 6 ++++-\n lib/librte_eal/windows/eal/eal.c | 14 +++++++++++\n lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++\n lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++\n lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++\n lib/librte_eal/windows/eal/meson.build | 10 ++++++++\n 8 files changed, 118 insertions(+), 14 deletions(-)\n create mode 100644 lib/librte_eal/windows/eal/eal.c\n create mode 100644 lib/librte_eal/windows/eal/eal_debug.c\n create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c\n create mode 100644 lib/librte_eal/windows/eal/eal_thread.c\n create mode 100644 lib/librte_eal/windows/eal/meson.build", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 30a7261a5..4bd73b1e9 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -1,5 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # set the major version, which might be used by drivers and libraries\n # depending on the configuration options\n@@ -80,18 +80,27 @@ dpdk_extra_ldflags += '-Wl,--no-as-needed'\n add_project_link_arguments('-pthread', language: 'c')\n dpdk_extra_ldflags += '-pthread'\n \n-# some libs depend on maths lib\n-add_project_link_arguments('-lm', language: 'c')\n-dpdk_extra_ldflags += '-lm'\n+# on some OS, maths functions are in a separate library\n+if cc.find_library('lm', required : false).found()\n+\t# some libs depend on maths lib\n+\tadd_project_link_arguments('-lm', language: 'c')\n+\tdpdk_extra_ldflags += '-lm'\n+endif\n \n # for linux link against dl, for bsd execinfo\n if host_machine.system() == 'linux'\n \tlink_lib = 'dl'\n-else\n+elif host_machine.system() == 'freebsd'\n \tlink_lib = 'execinfo'\n+else\n+\tlink_lib = ''\n+endif\n+\n+# if link_lib is empty, do not add it to project properties\n+if link_lib != ''\n+\tadd_project_link_arguments('-l' + link_lib, language: 'c')\n+\tdpdk_extra_ldflags += '-l' + link_lib\n endif\n-add_project_link_arguments('-l' + link_lib, language: 'c')\n-dpdk_extra_ldflags += '-l' + link_lib\n \n # check for libraries used in multiple places in DPDK\n has_libnuma = 0\ndiff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 7504cb9e5..558edfda9 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -1,15 +1,17 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # for checking defines we need to use the correct compiler flags\n march_opt = ['-march=@0@'.format(machine)]\n \n # get binutils version for the workaround of Bug 97\n-ldver = run_command('ld', '-v').stdout().strip()\n-if ldver.contains('2.30')\n-\tif cc.has_argument('-mno-avx512f')\n-\t\tmarch_opt += '-mno-avx512f'\n-\t\tmessage('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')\n+if host_machine.system() != 'windows'\n+\tldver = run_command('ld', '-v').stdout().strip()\n+\tif ldver.contains('2.30')\n+\t\tif cc.has_argument('-mno-avx512f')\n+\t\t\tmarch_opt += '-mno-avx512f'\n+\t\t\tmessage('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')\n+\t\tendif\n \tendif\n endif\n \ndiff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build\nindex c592c6747..c2249855a 100644\n--- a/lib/librte_eal/meson.build\n+++ b/lib/librte_eal/meson.build\n@@ -1,5 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # Custom EAL processing. EAL is complicated enough that it can't just\n # have a straight list of headers and source files.\n@@ -17,6 +17,10 @@ elif host_machine.system() == 'freebsd'\n \tdpdk_conf.set('RTE_EXEC_ENV_FREEBSD', 1)\n \tsubdir('freebsd/eal')\n \n+elif host_machine.system() == 'windows'\n+\tdpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1)\n+\tsubdir('windows/eal')\n+\n else\n \terror('unsupported system type \"@0@\"'.format(host_machine.system()))\n endif\ndiff --git a/lib/librte_eal/windows/eal/eal.c b/lib/librte_eal/windows/eal/eal.c\nnew file mode 100644\nindex 000000000..37ed42233\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/eal.c\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#include <rte_common.h>\n+\n+ /* Launch threads, called at application init(). */\n+int\n+rte_eal_init(int argc __rte_unused, char **argv __rte_unused)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\treturn 0;\n+}\ndiff --git a/lib/librte_eal/windows/eal/eal_debug.c b/lib/librte_eal/windows/eal/eal_debug.c\nnew file mode 100644\nindex 000000000..a9705e257\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/eal_debug.c\n@@ -0,0 +1,15 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#include <rte_common.h>\n+\n+ /* call abort(), it will generate a coredump if enabled */\n+void\n+__rte_panic(const char *funcname __rte_unused,\n+\t\tconst char *format __rte_unused, ...)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\tabort();\n+}\ndiff --git a/lib/librte_eal/windows/eal/eal_lcore.c b/lib/librte_eal/windows/eal/eal_lcore.c\nnew file mode 100644\nindex 000000000..e4fcb2615\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/eal_lcore.c\n@@ -0,0 +1,32 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#include <rte_common.h>\n+\n+ /* Get the cpu core id value */\n+unsigned int\n+eal_cpu_core_id(unsigned int lcore_id)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\treturn lcore_id;\n+}\n+\n+/* Check if a cpu is present by the presence of the cpu information for it */\n+int\n+eal_cpu_detected(unsigned int lcore_id __rte_unused)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\treturn 1;\n+}\n+\n+/* Get CPU socket id (NUMA node) for a logical core */\n+unsigned int\n+eal_cpu_socket_id(unsigned int cpu_id __rte_unused)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\treturn 0;\n+}\ndiff --git a/lib/librte_eal/windows/eal/eal_thread.c b/lib/librte_eal/windows/eal/eal_thread.c\nnew file mode 100644\nindex 000000000..f701443c3\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/eal_thread.c\n@@ -0,0 +1,18 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#include <windows.h>\n+\n+#include <rte_common.h>\n+\n+typedef uintptr_t eal_thread_t;\n+\n+/* function to create threads */\n+int\n+eal_thread_create(eal_thread_t *thread __rte_unused)\n+{\n+\t/* TODO */\n+\t/* This is a stub, not the expected result */\n+\treturn 0;\n+}\ndiff --git a/lib/librte_eal/windows/eal/meson.build b/lib/librte_eal/windows/eal/meson.build\nnew file mode 100644\nindex 000000000..8b1735623\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2019 Intel Corporation\n+\n+env_objs = []\n+env_headers = []\n+env_sources = files('eal.c',\n+\t'eal_debug.c',\n+\t'eal_lcore.c',\n+\t'eal_thread.c',\n+)\n", "prefixes": [ "v6", "1/8" ] }