Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 51726,
    "url": "http://patches.dpdk.org/api/patches/51726/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1553614522-12151-3-git-send-email-viacheslavo@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1553614522-12151-3-git-send-email-viacheslavo@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1553614522-12151-3-git-send-email-viacheslavo@mellanox.com",
    "date": "2019-03-26T15:35:11",
    "name": "[v3,02/13] net/mlx5: modify get ifindex routine for multiport IB",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f5c408d2265fae0dcb07ce3ed99fe06f8894e5f5",
    "submitter": {
        "id": 1102,
        "url": "http://patches.dpdk.org/api/people/1102/?format=api",
        "name": "Slava Ovsiienko",
        "email": "viacheslavo@mellanox.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patches.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1553614522-12151-3-git-send-email-viacheslavo@mellanox.com/mbox/",
    "series": [
        {
            "id": 3928,
            "url": "http://patches.dpdk.org/api/series/3928/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3928",
            "date": "2019-03-26T15:35:11",
            "name": "net/mlx5: add support for multiport IB devices",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/3928/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/51726/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/51726/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C67FA1B12A;\n\tTue, 26 Mar 2019 16:36:06 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 5E84C1B129\n\tfor <dev@dpdk.org>; Tue, 26 Mar 2019 16:36:05 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 26 Mar 2019 17:36:02 +0200",
            "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x2QFa1wP019637;\n\tTue, 26 Mar 2019 17:36:01 +0200"
        ],
        "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "shahafs@mellanox.com",
        "Date": "Tue, 26 Mar 2019 15:35:11 +0000",
        "Message-Id": "<1553614522-12151-3-git-send-email-viacheslavo@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1553614522-12151-1-git-send-email-viacheslavo@mellanox.com>",
        "References": "<1553533414-9911-1-git-send-email-viacheslavo@mellanox.com>\n\t<1553614522-12151-1-git-send-email-viacheslavo@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v3 02/13] net/mlx5: modify get ifindex routine\n\tfor multiport IB",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is the routine mlx5_nl_ifindex() returning the\nnetwork interface index associated with Infiniband device.\nWe are going to support multiport IB devices, now function\ntakes the IB port as argument and returns ifindex associated\nwith tuple <IB device, IB port>\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\nAcked-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c        |  2 +-\n drivers/net/mlx5/mlx5.h        |  2 +-\n drivers/net/mlx5/mlx5_ethdev.c |  2 +-\n drivers/net/mlx5/mlx5_nl.c     | 20 +++++++++++++-------\n 4 files changed, 16 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex aac1966..e8631a9 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1455,7 +1455,7 @@ struct mlx5_dev_spawn_data {\n \t\t\tlist[i].ifindex = 0;\n \t\telse\n \t\t\tlist[i].ifindex = mlx5_nl_ifindex\n-\t\t\t\t(nl_rdma, list[i].ibv_dev->name);\n+\t\t\t\t(nl_rdma, list[i].ibv_dev->name, 1);\n \t\tif (nl_route < 0 ||\n \t\t    !list[i].ifindex ||\n \t\t    mlx5_nl_switch_info(nl_route, list[i].ifindex,\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex a34e5cc..f359ed6 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -445,7 +445,7 @@ int mlx5_nl_mac_addr_remove(struct rte_eth_dev *dev, struct ether_addr *mac,\n void mlx5_nl_mac_addr_flush(struct rte_eth_dev *dev);\n int mlx5_nl_promisc(struct rte_eth_dev *dev, int enable);\n int mlx5_nl_allmulti(struct rte_eth_dev *dev, int enable);\n-unsigned int mlx5_nl_ifindex(int nl, const char *name);\n+unsigned int mlx5_nl_ifindex(int nl, const char *name, uint32_t pindex);\n int mlx5_nl_switch_info(int nl, unsigned int ifindex,\n \t\t\tstruct mlx5_switch_info *info);\n \ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 933839c..2b83898 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -222,7 +222,7 @@ struct ethtool_link_settings {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tunsigned int ifindex =\n \t\tpriv->nl_socket_rdma >= 0 ?\n-\t\tmlx5_nl_ifindex(priv->nl_socket_rdma, priv->ibdev_name) : 0;\n+\t\tmlx5_nl_ifindex(priv->nl_socket_rdma, priv->ibdev_name, 1) : 0;\n \n \tif (!ifindex) {\n \t\tif (!priv->representor)\ndiff --git a/drivers/net/mlx5/mlx5_nl.c b/drivers/net/mlx5/mlx5_nl.c\nindex d045b95..cdf6eb6 100644\n--- a/drivers/net/mlx5/mlx5_nl.c\n+++ b/drivers/net/mlx5/mlx5_nl.c\n@@ -85,11 +85,12 @@ struct mlx5_nl_mac_addr {\n \tint mac_n; /**< Number of addresses in the array. */\n };\n \n-/** Data structure used by mlx5_nl_ifindex_cb(). */\n+/** Data structure used by mlx5_nl_cmdget_cb(). */\n struct mlx5_nl_ifindex_data {\n \tconst char *name; /**< IB device name (in). */\n \tuint32_t ibindex; /**< IB device index (out). */\n \tuint32_t ifindex; /**< Network interface index (out). */\n+\tuint32_t portnum; /**< IB device max port number. */\n };\n \n /**\n@@ -695,12 +696,13 @@ struct mlx5_nl_ifindex_data {\n  *   0 on success, a negative errno value otherwise and rte_errno is set.\n  */\n static int\n-mlx5_nl_ifindex_cb(struct nlmsghdr *nh, void *arg)\n+mlx5_nl_cmdget_cb(struct nlmsghdr *nh, void *arg)\n {\n \tstruct mlx5_nl_ifindex_data *data = arg;\n \tsize_t off = NLMSG_HDRLEN;\n \tuint32_t ibindex = 0;\n \tuint32_t ifindex = 0;\n+\tuint32_t portnum = 0;\n \tint found = 0;\n \n \tif (nh->nlmsg_type !=\n@@ -725,6 +727,9 @@ struct mlx5_nl_ifindex_data {\n \t\tcase RDMA_NLDEV_ATTR_NDEV_INDEX:\n \t\t\tifindex = *(uint32_t *)payload;\n \t\t\tbreak;\n+\t\tcase RDMA_NLDEV_ATTR_PORT_INDEX:\n+\t\t\tportnum = *(uint32_t *)payload;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tbreak;\n \t\t}\n@@ -733,6 +738,7 @@ struct mlx5_nl_ifindex_data {\n \tif (found) {\n \t\tdata->ibindex = ibindex;\n \t\tdata->ifindex = ifindex;\n+\t\tdata->portnum = portnum;\n \t}\n \treturn 0;\n error:\n@@ -751,15 +757,15 @@ struct mlx5_nl_ifindex_data {\n  *   Netlink socket of the RDMA kind (NETLINK_RDMA).\n  * @param[in] name\n  *   IB device name.\n- *\n+ * @param[in] pindex\n+ *   IB device port index, starting from 1\n  * @return\n  *   A valid (nonzero) interface index on success, 0 otherwise and rte_errno\n  *   is set.\n  */\n unsigned int\n-mlx5_nl_ifindex(int nl, const char *name)\n+mlx5_nl_ifindex(int nl, const char *name, uint32_t pindex)\n {\n-\tstatic const uint32_t pindex = 1;\n \tuint32_t seq = random();\n \tstruct mlx5_nl_ifindex_data data = {\n \t\t.name = name,\n@@ -785,7 +791,7 @@ struct mlx5_nl_ifindex_data {\n \tret = mlx5_nl_send(nl, &req.nh, seq);\n \tif (ret < 0)\n \t\treturn 0;\n-\tret = mlx5_nl_recv(nl, seq, mlx5_nl_ifindex_cb, &data);\n+\tret = mlx5_nl_recv(nl, seq, mlx5_nl_cmdget_cb, &data);\n \tif (ret < 0)\n \t\treturn 0;\n \tif (!data.ibindex)\n@@ -808,7 +814,7 @@ struct mlx5_nl_ifindex_data {\n \tret = mlx5_nl_send(nl, &req.nh, seq);\n \tif (ret < 0)\n \t\treturn 0;\n-\tret = mlx5_nl_recv(nl, seq, mlx5_nl_ifindex_cb, &data);\n+\tret = mlx5_nl_recv(nl, seq, mlx5_nl_cmdget_cb, &data);\n \tif (ret < 0)\n \t\treturn 0;\n \tif (!data.ifindex)\n",
    "prefixes": [
        "v3",
        "02/13"
    ]
}