Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51388/?format=api
{ "id": 51388, "url": "http://patches.dpdk.org/api/patches/51388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1553082442-18850-5-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1553082442-18850-5-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1553082442-18850-5-git-send-email-david.marchand@redhat.com", "date": "2019-03-20T11:47:21", "name": "[4/5] net/bonding: fix incorrect packet count type for lacp", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "02280fb924d5a02af53d304e54425623f10cafc5", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1553082442-18850-5-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 3816, "url": "http://patches.dpdk.org/api/series/3816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3816", "date": "2019-03-20T11:47:17", "name": "bonding fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/3816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51388/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 79BE25F1B;\n\tWed, 20 Mar 2019 12:47:51 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E50FB5B2C;\n\tWed, 20 Mar 2019 12:47:46 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 55BD93168919;\n\tWed, 20 Mar 2019 11:47:46 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 008E21001E71;\n\tWed, 20 Mar 2019 11:47:44 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\tstable@dpdk.org", "Date": "Wed, 20 Mar 2019 12:47:21 +0100", "Message-Id": "<1553082442-18850-5-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1553082442-18850-1-git-send-email-david.marchand@redhat.com>", "References": "<1553082442-18850-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.41]); Wed, 20 Mar 2019 11:47:46 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 4/5] net/bonding: fix incorrect packet count type\n\tfor lacp", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Caught by code review, those variables are supposed to be on 16bits to\navoid endless loops in the (unlikely?) case where the application asks\nfor receiving more than 256 packets and the accumulated num_rx_total\ncount reaches 256:\n\nuint16_t num_rx_total = 0;\nuint8_t j, k;\n\nj = num_rx_total;\nnum_rx_total += rte_eth_rx_burst();\n\nfor (k = j; k < 2 && k < num_rx_total; k++)\n\trte_prefetch0(rte_pktmbuf_mtod(bufs[k], void *));\n\nwhile (j < num_rx_total) {\n\tj++;\n}\n\nFixes: 46fb43683679 (\"bond: add mode 4\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex bbe2568..ae66a70 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -405,8 +405,9 @@\n \tuint8_t collecting; /* current slave collecting status */\n \tconst uint8_t promisc = internals->promiscuous_en;\n \tuint8_t subtype;\n-\tuint8_t j, k;\n \tuint16_t i;\n+\tuint16_t j;\n+\tuint16_t k;\n \n \t/* Copy slave list to protect against slave up/down changes during tx\n \t * bursting */\n", "prefixes": [ "4/5" ] }