Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51134/?format=api
{ "id": 51134, "url": "http://patches.dpdk.org/api/patches/51134/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190312165114.23740-1-shshaikh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190312165114.23740-1-shshaikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190312165114.23740-1-shshaikh@marvell.com", "date": "2019-03-12T16:51:14", "name": "[1/1] net/qede: fix receive packet drop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a5eb679c67cd55bd054b5b73cf168a3ff3bebdf7", "submitter": { "id": 1210, "url": "http://patches.dpdk.org/api/people/1210/?format=api", "name": "Shahed Shaikh", "email": "shshaikh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190312165114.23740-1-shshaikh@marvell.com/mbox/", "series": [ { "id": 3721, "url": "http://patches.dpdk.org/api/series/3721/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3721", "date": "2019-03-12T16:51:14", "name": "[1/1] net/qede: fix receive packet drop", "version": 1, "mbox": "http://patches.dpdk.org/series/3721/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51134/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51134/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1567337B0;\n\tTue, 12 Mar 2019 17:52:45 +0100 (CET)", "from NAM05-BY2-obe.outbound.protection.outlook.com\n\t(mail-eopbgr710068.outbound.protection.outlook.com [40.107.71.68])\n\tby dpdk.org (Postfix) with ESMTP id AEE6211A4;\n\tTue, 12 Mar 2019 17:52:43 +0100 (CET)", "from CY1PR07CA0018.namprd07.prod.outlook.com\n\t(2a01:111:e400:c60a::28) by BL0PR07MB4019.namprd07.prod.outlook.com\n\t(2603:10b6:207:4b::21) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.20;\n\tTue, 12 Mar 2019 16:52:41 +0000", "from BY2NAM05FT051.eop-nam05.prod.protection.outlook.com\n\t(2a01:111:f400:7e52::202) by CY1PR07CA0018.outlook.office365.com\n\t(2a01:111:e400:c60a::28) with Microsoft SMTP Server (version=TLS1_2, \n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1686.18 via\n\tFrontend Transport; Tue, 12 Mar 2019 16:52:41 +0000", "from CAEXCH02.caveonetworks.com (199.233.58.38) by\n\tBY2NAM05FT051.mail.protection.outlook.com (10.152.100.188) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.1709.11 via Frontend Transport; Tue, 12 Mar 2019 16:52:40 +0000", "from dut1171.mv.qlogic.com (10.112.88.18) by\n\tCAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server\n\t(TLS) id 14.2.347.0; Tue, 12 Mar 2019 09:51:33 -0700", "from dut1171.mv.qlogic.com (localhost [127.0.0.1])\tby\n\tdut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x2CGpXMj023785;\n\tTue, 12 Mar 2019 09:51:33 -0700", "(from root@localhost)\tby dut1171.mv.qlogic.com\n\t(8.14.7/8.14.7/Submit) id x2CGpXda023784;\n\tTue, 12 Mar 2019 09:51:33 -0700" ], "Authentication-Results": "spf=fail (sender IP is 199.233.58.38)\n\tsmtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed)\n\theader.d=none; dpdk.org;\n\tdmarc=fail action=none header.from=marvell.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of marvell.com does not\n\tdesignate 199.233.58.38 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;", "From": "Shahed Shaikh <shshaikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<rmody@marvell.com>, <ferruh.yigit@intel.com>, <stable@dpdk.org>", "Date": "Tue, 12 Mar 2019 09:51:14 -0700", "Message-ID": "<20190312165114.23740-1-shshaikh@marvell.com>", "X-Mailer": "git-send-email 2.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131968831609500683;\n\t(abac79dc-c90b-41ba-8033-08d666125e47);\n\t(abac79dc-c90b-41ba-8033-08d666125e47)", "X-Forefront-Antispam-Report": "CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(346002)(39860400002)(376002)(136003)(396003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(86362001)(51416003)(36906005)(336012)(50466002)(16586007)(47776003)(97736004)(48376002)(54906003)(316002)(50226002)(6916009)(2906002)(85426001)(69596002)(4326008)(26005)(36756003)(5660300002)(450100002)(42186006)(81166006)(81156014)(476003)(6666004)(1076003)(87636003)(8676002)(305945005)(126002)(356004)(105606002)(2616005)(68736007)(498600001)(53936002)(8936002)(80596001)(486006)(2351001)(26826003)(106466001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4019;\n\tH:CAEXCH02.caveonetworks.com; \n\tFPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "3a0c14c9-7f82-4a27-6d1f-08d6a70b23f7", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);\n\tSRVR:BL0PR07MB4019; ", "X-MS-TrafficTypeDiagnostic": "BL0PR07MB4019:", "X-Microsoft-Antispam-PRVS": "<BL0PR07MB40195D791B28FF16C194B80FD3490@BL0PR07MB4019.namprd07.prod.outlook.com>", "X-Forefront-PRVS": "09749A275C", "X-Microsoft-Exchange-Diagnostics": "=?us-ascii?Q?1; BL0PR07MB4019;\n\t23:n28dKaLLlcMmg9YMQYsKiCkrIu5HtkcdZegjnIBsD?=\n\tcXbtxTjrKVYKkduraC1IkUZtGVYh1D9zFsp9Npqjz9BWm92W8+4c1QntTDDy/RY8BzZGL+q0yJA20vYz3w9kM3KX50pBhkLhCyTA/7EKaWqsculEWes9zpl84SCo7AIqi0gGAR1lYoXOACGv1RmwFH1qftZmW3nM8iYiR8fCku/AfyaFx8Pq6dNuf/iqlYhE7WpfQShpb5aWDNHrV07YTszq6/WpRnKzzQ6nXSrWxL2D4WBHnS/buPYhTr+PR6W3Ben4QVa2qWaS5bO5Yd+BqYNJF82eOV9zhe2TIS0hjPUVxveDgSlu4pJLVPFK0xRHJwKnHh8TSaDp5z5CHMFPiFDk1COFfV2pqbuEFEcWgEOmMTsmU+9tYq6YjMdk9zAhdJXtLI7P50VMo95XLglsPTDHyDOKMqDSg5b8OuOKrwoFrw9tTEClScJ9+YoLvtsYExgvLWCpzgzIlQhuP0SFC4iL14RiN3aMzgevA+wSY2FsX8AcUqPrSBLKyDsj4A56U0FzoNbB5ou4gy+4vNs71+lbiIZ2eUoO01nMHxudp989OVwHEWFctGKxEmuLLIpoEEwiH7+8PSe7guJMYiL8Df2UeufkRx4Dty9knM+8utwfomHlPLfWGyx4ffGWPc6EH7A5LCzqemZXxMm+MRo2OQzfkl2ulhQ1hLqzwLTz3Wknq8/W44emMyz6/VaHRJr5pvkJKAyesodVHm95QTnado3VJxcWEOAQx+xIjzgvq9AKeVUO29O5DX7cp8drc9ALgJVNG4UZv3Pk/7I79CommRGz+gvoS6wnst6G4hvtLbQGIK7iDpsRTjMilA1fPKa7JelcNINTP5kr/pg3cMqNromyUq1S7dV+ajVzaScLfELWrSFQ7ZAPpiATM3eCArCl+A8NnsZhwcZtVphJMg818x6fpTE/0jNcZxeDAQlJqtTrAXwb5cbZ+6w3HgwBugjbP4V2pmCa/EcUIGFKSdrY4RjjXh/5XDjzUL75Oj2bDBTKbnNEU+G1eA8shpoLfWYz2K3dduOPMuFLI0JoPn4vGuGIq4JFSVqwg52EJDCam9LxsmdNsO2np4cka4MvYYCQnXXFxaWQoBNpQ6HSY2vKrFrVTriPbWP6JgtQ2J58JeMnCTELE0RVUmNTxBqxbmKlxTY1KP3HhJ4uDoxK5JgHxPODf/KwrjSr2kLnO5R7c2epg==", "X-Microsoft-Antispam-Message-Info": "ug/Wb715QC38YiaGkAIlo0i9Fpmp+807tdWL/TeMDN0iykjayFxgc1TyBmt6deTQiF2eNI8H+vP/pmuk/Vh1ymUUBQvnGYBNHHZsaNktwDLe5sLJZJow5uSjEL44yI0UNCfUqpPy46NW8Cv+tFqY9p27plEc/bsK3BvANJggU+Qe6ukq9/Q/+8idkrhpW3Tt+bhoTJ4ewoNu1OVjhd5OxGtL3sQbs5Vi9xa6HLLQTqG8UF6SjGFXwQj4bWXh0SnBx+7h1yZPQSImCIaj7TSsR63HPsz35nm5TO7sPmfmTHhg7sqyAcerLZ+Fb0V8Llwn7ttacejKXuP4UNBapU0pOWBSfQSVlhoQyTL4cF3NKtPlIydhwF6eTqzANZwqvCYX01x5PGGvvrcimcr8ULC3hCYhVvVNVJzvyp7c585DS24=", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Mar 2019 16:52:40.6838\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "3a0c14c9-7f82-4a27-6d1f-08d6a70b23f7", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[199.233.58.38]; \n\tHelo=[CAEXCH02.caveonetworks.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL0PR07MB4019", "Subject": "[dpdk-dev] [PATCH 1/1] net/qede: fix receive packet drop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is a corner case in which driver won't post\nreceive buffers when driver has processed all received packets\nin single loop (i.e. hw_consumer == sw_consumer) and then\nHW will start dropping packets since it did not see new receive\nbuffers posted.\n\nThis corner case is seen when size of Rx ring is less than or equals\nRx packet burst count for dev->rx_pkt_burst().\n\nFixes: 8f2312474529 (\"net/qede: fix performance bottleneck in Rx path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\n---\n drivers/net/qede/qede_rxtx.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c\nindex 70c32e3..27bac09 100644\n--- a/drivers/net/qede/qede_rxtx.c\n+++ b/drivers/net/qede/qede_rxtx.c\n@@ -1420,13 +1420,6 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \tuint32_t rss_hash;\n \tint rx_alloc_count = 0;\n \n-\thw_comp_cons = rte_le_to_cpu_16(*rxq->hw_cons_ptr);\n-\tsw_comp_cons = ecore_chain_get_cons_idx(&rxq->rx_comp_ring);\n-\n-\trte_rmb();\n-\n-\tif (hw_comp_cons == sw_comp_cons)\n-\t\treturn 0;\n \n \t/* Allocate buffers that we used in previous loop */\n \tif (rxq->rx_alloc_count) {\n@@ -1447,6 +1440,14 @@ qede_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\trxq->rx_alloc_count = 0;\n \t}\n \n+\thw_comp_cons = rte_le_to_cpu_16(*rxq->hw_cons_ptr);\n+\tsw_comp_cons = ecore_chain_get_cons_idx(&rxq->rx_comp_ring);\n+\n+\trte_rmb();\n+\n+\tif (hw_comp_cons == sw_comp_cons)\n+\t\treturn 0;\n+\n \twhile (sw_comp_cons != hw_comp_cons) {\n \t\tol_flags = 0;\n \t\tpacket_type = RTE_PTYPE_UNKNOWN;\n", "prefixes": [ "1/1" ] }