Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50988/?format=api
{ "id": 50988, "url": "http://patches.dpdk.org/api/patches/50988/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1552031797-146710-2-git-send-email-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1552031797-146710-2-git-send-email-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1552031797-146710-2-git-send-email-gavin.hu@arm.com", "date": "2019-03-08T07:56:35", "name": "[v8,1/3] test/spinlock: remove 1us delay for correct benchmarking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dbd612d6eb803c0a067ea00192981458f89039ff", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1552031797-146710-2-git-send-email-gavin.hu@arm.com/mbox/", "series": [ { "id": 3676, "url": "http://patches.dpdk.org/api/series/3676/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3676", "date": "2019-03-08T07:56:34", "name": "generic spinlock optimization and test case enhancements", "version": 8, "mbox": "http://patches.dpdk.org/series/3676/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50988/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CE873324D;\n\tFri, 8 Mar 2019 08:57:03 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 547D12C17;\n\tFri, 8 Mar 2019 08:57:02 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0F6F15BE;\n\tThu, 7 Mar 2019 23:57:01 -0800 (PST)", "from net-arm-thunderx2.shanghai.arm.com\n\t(net-arm-thunderx2.shanghai.arm.com [10.169.40.121])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\tD07523F71D; Thu, 7 Mar 2019 23:56:59 -0800 (PST)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, thomas@monjalon.net, jerinj@marvell.com,\n\themant.agrawal@nxp.com, nipun.gupta@nxp.com,\n\tHonnappa.Nagarahalli@arm.com, \n\tgavin.hu@arm.com, i.maximets@samsung.com, chaozhu@linux.vnet.ibm.com, \n\tstable@dpdk.org", "Date": "Fri, 8 Mar 2019 15:56:35 +0800", "Message-Id": "<1552031797-146710-2-git-send-email-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1552031797-146710-1-git-send-email-gavin.hu@arm.com>", "<20181220104246.5590-1-gavin.hu@arm.com>" ], "References": [ "<1552031797-146710-1-git-send-email-gavin.hu@arm.com>", "<20181220104246.5590-1-gavin.hu@arm.com>" ], "Subject": "[dpdk-dev] [PATCH v8 1/3] test/spinlock: remove 1us delay for\n\tcorrect benchmarking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The test is to benchmark the performance of spinlock by counting the\nnumber of spinlock acquire and release operations within the specified\ntime.\nA typical pair of lock and unlock operations costs tens or hundreds of\nnano seconds, in comparison to this, delaying 1 us outside of the locked\nregion is too much, compromising the goal of benchmarking the lock and\nunlock performance.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ruifeng Wang <Ruifeng.Wang@arm.com>\nReviewed-by: Joyce Kong <Joyce.Kong@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nReviewed-by: Ola Liljedahl <Ola.Liljedahl@arm.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n app/test/test_spinlock.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c\nindex 73bff12..6795195 100644\n--- a/app/test/test_spinlock.c\n+++ b/app/test/test_spinlock.c\n@@ -120,8 +120,6 @@ load_loop_fn(void *func_param)\n \t\tlcount++;\n \t\tif (use_lock)\n \t\t\trte_spinlock_unlock(&lk);\n-\t\t/* delay to make lock duty cycle slighlty realistic */\n-\t\trte_delay_us(1);\n \t\ttime_diff = rte_get_timer_cycles() - begin;\n \t}\n \tlock_count[lcore] = lcount;\n", "prefixes": [ "v8", "1/3" ] }