Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50607/?format=api
{ "id": 50607, "url": "http://patches.dpdk.org/api/patches/50607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190228070317.17002-11-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190228070317.17002-11-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190228070317.17002-11-hyonkim@cisco.com", "date": "2019-02-28T07:03:12", "name": "[10/15] net/enic: initialize VXLAN port regardless of overlay offload", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5a1cef5da9763e8756071dce3fc6d759150952ab", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190228070317.17002-11-hyonkim@cisco.com/mbox/", "series": [ { "id": 3568, "url": "http://patches.dpdk.org/api/series/3568/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3568", "date": "2019-02-28T07:03:02", "name": "net/enic: 19.05 updates", "version": 1, "mbox": "http://patches.dpdk.org/series/3568/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50607/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CDE684CA0;\n\tThu, 28 Feb 2019 08:05:47 +0100 (CET)", "from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])\n\tby dpdk.org (Postfix) with ESMTP id 5B8C64CA0;\n\tThu, 28 Feb 2019 08:05:45 +0100 (CET)", "from alln-core-9.cisco.com ([173.36.13.129])\n\tby rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Feb 2019 07:05:44 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTP id x1S75ies017956;\n\tThu, 28 Feb 2019 07:05:44 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 18F3120F2001; Wed, 27 Feb 2019 23:05:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1454; q=dns/txt; s=iport;\n\tt=1551337545; x=1552547145;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=ugkcOu7f4kvORdbpVKyKEtAjKMfvS+Vwf79wlDxNUDg=;\n\tb=Oe2yWuVXmKu4xh0QGjtiRlXElRE1Db/yN4/O4QoKkkTKfISPTsZ5dcDW\n\tUp+7mo9uf4PvDZZVqCSBr9kJ2vSy/G+PCg4jobt283oqP/zCvNBlDZrpy\n\t5AjbgAo0JIsOsGsjaQ5wnEzG3PAtAju0C3+X04gUMdMcK0N1qsJ5TTT6l 8=;", "X-IronPort-AV": "E=Sophos;i=\"5.58,422,1544486400\"; d=\"scan'208\";a=\"529108229\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>,\n\tHyong Youb Kim <hyonkim@cisco.com>, stable@dpdk.org", "Date": "Wed, 27 Feb 2019 23:03:12 -0800", "Message-Id": "<20190228070317.17002-11-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20190228070317.17002-1-hyonkim@cisco.com>", "References": "<20190228070317.17002-1-hyonkim@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "alln-core-9.cisco.com", "Subject": "[dpdk-dev] [PATCH 10/15] net/enic: initialize VXLAN port regardless\n\tof overlay offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the driver resets the vxlan port register only if overlay\noffload is enabled. But, the register is actually tied to hardware\nvxlan parsing, which is an independent feature and is always enabled\neven if overlay offload is disabled. If left uninitialized, it can\naffect flow rules that match vxlan. So always reset the port number\nwhen HW vxlan parsing is available.\n\nFixes: 8a4efd17410c (\"net/enic: add handlers to add/delete vxlan port number\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\n---\n drivers/net/enic/enic_main.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex 2652949a2..ea9eb2edf 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -1714,8 +1714,15 @@ static int enic_dev_init(struct enic *enic)\n \t\t\tPKT_TX_OUTER_IP_CKSUM |\n \t\t\tPKT_TX_TUNNEL_MASK;\n \t\tenic->overlay_offload = true;\n-\t\tenic->vxlan_port = ENIC_DEFAULT_VXLAN_PORT;\n \t\tdev_info(enic, \"Overlay offload is enabled\\n\");\n+\t}\n+\t/*\n+\t * Reset the vxlan port if HW vxlan parsing is available. It\n+\t * is always enabled regardless of overlay offload\n+\t * enable/disable.\n+\t */\n+\tif (enic->vxlan) {\n+\t\tenic->vxlan_port = ENIC_DEFAULT_VXLAN_PORT;\n \t\t/*\n \t\t * Reset the vxlan port to the default, as the NIC firmware\n \t\t * does not reset it automatically and keeps the old setting.\n", "prefixes": [ "10/15" ] }