Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50524/?format=api
{ "id": 50524, "url": "http://patches.dpdk.org/api/patches/50524/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190226174637.27452-6-luca.boccassi@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190226174637.27452-6-luca.boccassi@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190226174637.27452-6-luca.boccassi@gmail.com", "date": "2019-02-26T17:46:37", "name": "[v8,6/6] build: use dependency for pcap and fallback to find_library", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "700ed43642b012ea7b96eedf8358e6c625337237", "submitter": { "id": 566, "url": "http://patches.dpdk.org/api/people/566/?format=api", "name": "Luca Boccassi", "email": "luca.boccassi@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190226174637.27452-6-luca.boccassi@gmail.com/mbox/", "series": [ { "id": 3552, "url": "http://patches.dpdk.org/api/series/3552/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3552", "date": "2019-02-26T17:46:32", "name": "[v8,1/6] build: bump minimum Meson version to 0.47.1", "version": 8, "mbox": "http://patches.dpdk.org/series/3552/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50524/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A860C4C93;\n\tTue, 26 Feb 2019 18:47:05 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 893A42BF5\n\tfor <dev@dpdk.org>; Tue, 26 Feb 2019 18:47:02 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id i12so14973321wrw.0\n\tfor <dev@dpdk.org>; Tue, 26 Feb 2019 09:47:02 -0800 (PST)", "from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336])\n\tby smtp.gmail.com with ESMTPSA id p1sm83911wmi.9.2019.02.26.09.47.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Feb 2019 09:47:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=M3bfXYkriF6V+9Eq5VxG7MBFN7RXgaCA0a7LvsOSQZo=;\n\tb=E14gI+8zCKj7LUr/XTTPVuBnUS1tU7GsudboDs6wobj8S0hb+eUzdYBvdjsACoA+ZQ\n\tM+lmkkQv0pBYkZIhMi+Uplc90GMKU/SFopwryqtjS6IirAl9NTTqEtCYLCrWK6HMxwMA\n\ty7RZ5lKugwQMvCT8ihNHcagXe0o+r1NXmJ5jCKumcevno2weRoPZYBlulATSrTb+yuy1\n\tBQ8TedF25ab4sr9ByFMumzXmqs2bFte8IS1ndO2hngkH5QQhvFN9wNEAU8Qg2rUXi/ZR\n\txXfAEPOOsI5/7tQsDImbXuRTxGIJ98AeHx85GD13vj1YomSH35tWbzXbyCmcUwjHgAGc\n\tr4+Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=M3bfXYkriF6V+9Eq5VxG7MBFN7RXgaCA0a7LvsOSQZo=;\n\tb=o8R6ExqMFubpYwXAU1PRp68koHUqXoFCEtDS/g1awKXPZ0oMMzvc+hTvL1zdlgXOr2\n\toonuB+TjHW+kHhuN5sYD4JYXqLKw4NLd5im0OrExSZ++2RhZdluud0SHEIlMsunP/aE7\n\t2zkGHy/jhf1cGxGWRqrER4S5ljBUFTTBy+vICWaiTJnzJ2B+8jaBupvOxb6iv5endxLy\n\tjvl29g0XCFc6wzYlCyvazfHHYs1c2h18XY1ZKQJ4MgBcrHhzuUURAow2ybGp4wMQ+FEs\n\t+GzlbGsyzlNDtAhhCRsuSqLBYr51JFGzZjqvAI2Cx2d4Ic7N2qNooDhL3v5O/d2oFk4O\n\tCziA==", "X-Gm-Message-State": "AHQUAuZqotmbR9Ew7xbjTAVKXtcy5YBir+1PcXLkZVx9Lgd9Hdnw8qGn\n\tdy1LLJbIeddlqAgoz3R87cPZnsuga0c=", "X-Google-Smtp-Source": "AHgI3IYJ1AFxUMsaribnnirGpHdMR75VwyLOEmM+byWqx0PnB2BbkzZawBy1yyca007F+GofC4/RSw==", "X-Received": "by 2002:adf:eac2:: with SMTP id o2mr17029015wrn.0.1551203221829; \n\tTue, 26 Feb 2019 09:47:01 -0800 (PST)", "From": "luca.boccassi@gmail.com", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com,\n\tthomas@monjalon.net", "Date": "Tue, 26 Feb 2019 17:46:37 +0000", "Message-Id": "<20190226174637.27452-6-luca.boccassi@gmail.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190226174637.27452-1-luca.boccassi@gmail.com>", "References": "<20190103175725.5836-1-bluca@debian.org>\n\t<20190226174637.27452-1-luca.boccassi@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and\n\tfallback to find_library", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Luca Boccassi <luca.boccassi@microsoft.com>\n\npcap has historically shipped a custom pcap-config binary tool which\ndoes the job of pkg-config. It was never compatible with cross\ncompilation.\nMeson uses it when using dependency(), which then means cross\ncompilation fails.\nSet pcap-config to empty in the meson cross compilation files so\nthat Meson will not use it, and add a fallback in case\ndependency() fails.\nlibpcap 1.9.0 finally ships a pkg-config file so everything will\nwork out of the box in the future.\n\nSigned-off-by: Luca Boccassi <luca.boccassi@microsoft.com>\n---\nv8: added back pcap change separately. Tested with bootlin\n cross-compilation toolchain, everything seems to work.\n\n config/arm/arm64_armv8_linuxapp_gcc | 1 +\n config/arm/arm64_dpaa2_linuxapp_gcc | 1 +\n config/arm/arm64_dpaa_linuxapp_gcc | 1 +\n config/arm/arm64_thunderx_linuxapp_gcc | 1 +\n drivers/net/pcap/meson.build | 16 ++++++++++++----\n 5 files changed, 16 insertions(+), 4 deletions(-)", "diff": "diff --git a/config/arm/arm64_armv8_linuxapp_gcc b/config/arm/arm64_armv8_linuxapp_gcc\nindex 987c02fbb..513760917 100644\n--- a/config/arm/arm64_armv8_linuxapp_gcc\n+++ b/config/arm/arm64_armv8_linuxapp_gcc\n@@ -3,6 +3,7 @@ c = 'aarch64-linux-gnu-gcc'\n cpp = 'aarch64-linux-gnu-cpp'\n ar = 'aarch64-linux-gnu-gcc-ar'\n strip = 'aarch64-linux-gnu-strip'\n+pcap-config = ''\n \n [host_machine]\n system = 'linux'\ndiff --git a/config/arm/arm64_dpaa2_linuxapp_gcc b/config/arm/arm64_dpaa2_linuxapp_gcc\nindex 7ec74ec4b..0df8c8f7d 100644\n--- a/config/arm/arm64_dpaa2_linuxapp_gcc\n+++ b/config/arm/arm64_dpaa2_linuxapp_gcc\n@@ -4,6 +4,7 @@ cpp = 'aarch64-linux-gnu-cpp'\n ar = 'aarch64-linux-gnu-ar'\n as = 'aarch64-linux-gnu-as'\n strip = 'aarch64-linux-gnu-strip'\n+pcap-config = ''\n \n [host_machine]\n system = 'linux'\ndiff --git a/config/arm/arm64_dpaa_linuxapp_gcc b/config/arm/arm64_dpaa_linuxapp_gcc\nindex 73a8f0b81..f4b85a84b 100644\n--- a/config/arm/arm64_dpaa_linuxapp_gcc\n+++ b/config/arm/arm64_dpaa_linuxapp_gcc\n@@ -4,6 +4,7 @@ cpp = 'aarch64-linux-gnu-cpp'\n ar = 'aarch64-linux-gnu-ar'\n as = 'aarch64-linux-gnu-as'\n strip = 'aarch64-linux-gnu-strip'\n+pcap-config = ''\n \n [host_machine]\n system = 'linux'\ndiff --git a/config/arm/arm64_thunderx_linuxapp_gcc b/config/arm/arm64_thunderx_linuxapp_gcc\nindex 967d9d46d..14b801998 100644\n--- a/config/arm/arm64_thunderx_linuxapp_gcc\n+++ b/config/arm/arm64_thunderx_linuxapp_gcc\n@@ -3,6 +3,7 @@ c = 'aarch64-linux-gnu-gcc'\n cpp = 'aarch64-linux-gnu-cpp'\n ar = 'aarch64-linux-gnu-gcc-ar'\n strip = 'aarch64-linux-gnu-strip'\n+pcap-config = ''\n \n [host_machine]\n system = 'linux'\ndiff --git a/drivers/net/pcap/meson.build b/drivers/net/pcap/meson.build\nindex 0c4e0201a..2c2fd11e4 100644\n--- a/drivers/net/pcap/meson.build\n+++ b/drivers/net/pcap/meson.build\n@@ -1,12 +1,20 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-pcap_dep = cc.find_library('pcap', required: false)\n-if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)\n+pcap_dep = dependency('pcap', required: false)\n+if pcap_dep.found()\n \tbuild = true\n else\n-\tbuild = false\n+\t# pcap got a pkg-config file only in 1.9.0 and before that meson uses\n+\t# an internal pcap-config finder, which is not compatible with\n+\t# cross-compilation, so try to fallback to find_library\n+\tpcap_dep = cc.find_library('pcap', required: false)\n+\tif pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)\n+\t\tbuild = true\n+\t\tpkgconfig_extra_libs += '-lpcap'\n+\telse\n+\t\tbuild = false\n+\tendif\n endif\n sources = files('rte_eth_pcap.c')\n ext_deps += pcap_dep\n-pkgconfig_extra_libs += '-lpcap'\n", "prefixes": [ "v8", "6/6" ] }