Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50424/?format=api
{ "id": 50424, "url": "http://patches.dpdk.org/api/patches/50424/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190221192444.30575-1-shshaikh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190221192444.30575-1-shshaikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190221192444.30575-1-shshaikh@marvell.com", "date": "2019-02-21T19:24:44", "name": "[1/1] net/bnx2x: fix segfaults due to stale interrupt status", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b8d552f2b863f56c1f5262d9552dd42b5f92c5e8", "submitter": { "id": 1210, "url": "http://patches.dpdk.org/api/people/1210/?format=api", "name": "Shahed Shaikh", "email": "shshaikh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190221192444.30575-1-shshaikh@marvell.com/mbox/", "series": [ { "id": 3503, "url": "http://patches.dpdk.org/api/series/3503/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3503", "date": "2019-02-21T19:24:44", "name": "[1/1] net/bnx2x: fix segfaults due to stale interrupt status", "version": 1, "mbox": "http://patches.dpdk.org/series/3503/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50424/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50424/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 263532B8C;\n\tThu, 21 Feb 2019 20:26:14 +0100 (CET)", "from NAM05-DM3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr730080.outbound.protection.outlook.com [40.107.73.80])\n\tby dpdk.org (Postfix) with ESMTP id A6AE61D7;\n\tThu, 21 Feb 2019 20:26:12 +0100 (CET)", "from BN8PR07CA0035.namprd07.prod.outlook.com (2603:10b6:408:ac::48)\n\tby CY4PR07MB2903.namprd07.prod.outlook.com (2603:10b6:903:26::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14;\n\tThu, 21 Feb 2019 19:26:11 +0000", "from CO1NAM05FT060.eop-nam05.prod.protection.outlook.com\n\t(2a01:111:f400:7e50::206) by BN8PR07CA0035.outlook.office365.com\n\t(2603:10b6:408:ac::48) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1643.16 via\n\tFrontend Transport; Thu, 21 Feb 2019 19:26:11 +0000", "from CAEXCH02.caveonetworks.com (199.233.58.38) by\n\tCO1NAM05FT060.mail.protection.outlook.com (10.152.96.178) with\n\tMicrosoft SMTP\n\tServer (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.1665.5 via Frontend Transport; Thu, 21 Feb 2019 19:26:10 +0000", "from dut1171.mv.qlogic.com (10.112.88.18) by\n\tCAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server\n\t(TLS) id 14.2.347.0; Thu, 21 Feb 2019 11:25:07 -0800", "from dut1171.mv.qlogic.com (localhost [127.0.0.1])\tby\n\tdut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x1LJP7NB030620;\n\tThu, 21 Feb 2019 11:25:07 -0800", "(from root@localhost)\tby dut1171.mv.qlogic.com\n\t(8.14.7/8.14.7/Submit) id x1LJP6o8030619;\n\tThu, 21 Feb 2019 11:25:06 -0800" ], "Authentication-Results": "spf=fail (sender IP is 199.233.58.38)\n\tsmtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed)\n\theader.d=none; dpdk.org;\n\tdmarc=fail action=none header.from=marvell.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of marvell.com does not\n\tdesignate 199.233.58.38 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;", "From": "Shahed Shaikh <shshaikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<rmody@marvell.com>, <ferruh.yigit@intel.com>, <stable@dpdk.org>", "Date": "Thu, 21 Feb 2019 11:24:44 -0800", "Message-ID": "<20190221192444.30575-1-shshaikh@marvell.com>", "X-Mailer": "git-send-email 2.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131952507708674512;\n\t(abac79dc-c90b-41ba-8033-08d666125e47);\n\t(abac79dc-c90b-41ba-8033-08d666125e47)", "X-Forefront-Antispam-Report": "CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(376002)(39860400002)(396003)(346002)(136003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(50226002)(105606002)(26826003)(8936002)(87636003)(336012)(498600001)(2616005)(1076003)(86362001)(316002)(476003)(450100002)(4326008)(14444005)(42186006)(16586007)(36906005)(50466002)(54906003)(68736007)(26005)(5660300002)(48376002)(47776003)(486006)(126002)(51416003)(106466001)(6666004)(356004)(6916009)(2351001)(305945005)(36756003)(2906002)(53936002)(81166006)(81156014)(80596001)(85426001)(8676002)(97736004)(69596002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB2903;\n\tH:CAEXCH02.caveonetworks.com; \n\tFPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "7783d50b-7a28-41ce-3d53-08d698326fa2", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(5600110)(711020)(4605104)(2017052603328);\n\tSRVR:CY4PR07MB2903; ", "X-MS-TrafficTypeDiagnostic": "CY4PR07MB2903:", "X-Microsoft-Antispam-PRVS": "<CY4PR07MB290357F23ECFB49DF27BBDB1D37E0@CY4PR07MB2903.namprd07.prod.outlook.com>", "X-Forefront-PRVS": "09555FB1AD", "X-Microsoft-Exchange-Diagnostics": "=?us-ascii?Q?1; CY4PR07MB2903;\n\t23:/km1veGfkqAX/hE7+2Wjt/HVZJ5JiHBKiElR8RJhJ?=\n\t9T50WsI/zX1qgFiAdboZozrMmqqaKg0/PRSpBpfYuQ7fgcnpwIEqsxsflu2CdfG7SPOYAH2NdSukEfBs4jdtb0yZDNObTszX//u80fnRHCxi3Vxrye7IGkH302dENCdk7YvuFkMHtKXC9saWAinfMG9L9Ao2v07hDSVOGxnkAyBBitEdXY5gjjuV00ieD8lZu1qk63jQvsbZg8cz0brfZj+C447Ar+I99ygRxZXn3YNgXBBxH+0Nqo4Pscgp9+NiHlcV6QJB2pfzjc1GbMWurz48PktcjMOuIJ6I+8NpVhtD5yqNEtxzR84EoVojS1KBfKBYIX8KRL4R+TyibrXmQxjPvY8b0kMxcAYH5skZsjup+4wQRSsmgAt5JhE3j+vZnKWAAmlif4D/OB4ygQs1XuLmgUJ473mcL4MGuOFJJyfnPTHdMp32glhe4KE4XvJIyiNkIXnWA+sUPpLWHNPOzKRKH7nJo4P/ZijnxOfMb0OsvbsMOvTdl3jmBmq+DbFq6zfisRtP6it3uOndofLS+nDTDLNJ7vDoFEqkdWc9S+2+KL/I2BrYFfLkd3+kYQGoLHpC1XKAO9TSm2SbwIAEI6Nn2yRzhuzAMy0eTPsERrJCcfar6VmbbVLsifJBuRObZvClUeds2Ci6BT6gOYUqniuWakuJpvuKbZJhPCyiEHfTCwMU938zegELzx/jvXjBaZ1xIGcLngV9rsvkeaMy/4sgNyXyTKaadQOekXJA1Xi2RQuhoQ6+7Qtxhrkr0tzc1p7YvMXAx1+aqBFZ2KX2h+40WYFH1A7xenwcm2Wd29/os2P/e12pTKIotMOkNZ2s8KH2rLJUV94XETi470KIJnyXIL2JxK6YZ1bDUeqO53z7jCY4eX+HXxl63OnD7YqfvHZZjDB94kHVKBDjO5fCu3QFCcSYejEOfC2RnIb+wGHBGe59zl0LLyoha8os9xDZI87+t8zsJ1VgpjFKVUUprNxM52FLAz0woOMZJn5WwNwDfdHsO+qS556FGPBmeeHK5lKwa3AcCZS6PoZcTELgMG+re/oF8RlxvjPucPb459YrMmUd6MYoAf5ims8AdMAjBF8pqZPQtZk1M/3UZwoykmQocemfhDCLq7Uf8WwYG1fbIUtW0MLY7ix5cDoHkYoCQCgbDLtJVZFVJ6Vy9kWBfU/Bm6nPnhjMFT7pX8PEv+TAw==", "X-Microsoft-Antispam-Message-Info": "4ij/hdqqi8BX0iS7KhGpNe/flmuEl1IDxoOV3YKSqeS9p9bRlnEfibl/qxfRE36yGK5kXXPQc4/h90y8CiZJncswCYsUmiBLtHpAj7yRqhTGcNkjVjSWrP4T9HZukvPGShX4LCkHnUo7Pexsueo7h3tM3S3BG3p2TlXA/DdbKcMkOwed0ivHNeULA51qD5qN46ezxbJDdL9DplsDDNHQ+HD0zbbpbJ0ZeKkQ7LNysVd0wqDoJqGI7haZb6BW2wB2Em7GdSI//VhmhOJrk17V0Mi+GK5Ic+X8C2UF0H4Ppb9gSkdZOMYMah4zW2/iHvcbUdpHlWza8c/cKCwl+jm8rBmm0PdYByFT6VoQr64NDvk736aEr1x+aNR5+Mp5gtzUu+YqRK3A/SZBLc7z683koEMeJ++AcKNtmPSgCva5JUQ=", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Feb 2019 19:26:10.5261\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "7783d50b-7a28-41ce-3d53-08d698326fa2", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[199.233.58.38]; \n\tHelo=[CAEXCH02.caveonetworks.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR07MB2903", "Subject": "[dpdk-dev] [PATCH 1/1] net/bnx2x: fix segfaults due to stale\n\tinterrupt status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous ungraceful exit may leave behind un-acked stale\ninterrupts for slowpath and fastpath.\n\nInterrupt status polling function is started before FLR is\ninitiated, so we don't have a real way to protect this polling\nfunction invoking an interrupt handler caused due to stale\ninterrupt status from previous ungraceful exit.\n\nSo, check uninitialized status block variables in interrupt\nhandling path which may lead to sefault.\n\nFixes: 540a211084a7 (\"bnx2x: driver core\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\n---\n drivers/net/bnx2x/bnx2x.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 4c775c1..26b3828 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -4201,6 +4201,9 @@ static uint16_t bnx2x_update_dsb_idx(struct bnx2x_softc *sc)\n \tstruct host_sp_status_block *def_sb = sc->def_sb;\n \tuint16_t rc = 0;\n \n+\tif (!def_sb)\n+\t\treturn 0;\n+\n \tmb();\t\t\t/* status block is written to by the chip */\n \n \tif (sc->def_att_idx != def_sb->atten_status_block.attn_bits_index) {\n@@ -4525,6 +4528,10 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp)\n \tstruct bnx2x_softc *sc = fp->sc;\n \tuint8_t more_rx = FALSE;\n \n+\t/* Make sure FP is initialized */\n+\tif (!fp->sb_running_index)\n+\t\treturn;\n+\n \tPMD_DEBUG_PERIODIC_LOG(DEBUG, sc,\n \t\t\t \"---> FP TASK QUEUE (%d) <--\", fp->index);\n \n", "prefixes": [ "1/1" ] }