Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50138/?format=api
{ "id": 50138, "url": "http://patches.dpdk.org/api/patches/50138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190205181941.10484-1-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190205181941.10484-1-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190205181941.10484-1-arkadiuszx.kusztal@intel.com", "date": "2019-02-05T18:19:41", "name": "[v2] cryptodev: rework mod exp and mod inv comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e2c27e0456176d470d02a19c4a5a7cf814a441a5", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190205181941.10484-1-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 3391, "url": "http://patches.dpdk.org/api/series/3391/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3391", "date": "2019-02-05T18:19:41", "name": "[v2] cryptodev: rework mod exp and mod inv comments", "version": 2, "mbox": "http://patches.dpdk.org/series/3391/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50138/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50138/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AA8DB5F29;\n\tTue, 5 Feb 2019 19:20:14 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 529182C54\n\tfor <dev@dpdk.org>; Tue, 5 Feb 2019 19:20:11 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Feb 2019 10:20:06 -0800", "from akusztax-mobl.ger.corp.intel.com ([10.104.116.169])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Feb 2019 10:20:04 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,336,1544515200\"; d=\"scan'208\";a=\"140917221\"", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com,\n\tshally.verma@caviumnetworks.com, sunila.sahu@caviumnetworks.com,\n\tashish.gupta@caviumnetworks.com, umesh.kartha@caviumnetworks.com,\n\tArek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Tue, 5 Feb 2019 19:19:41 +0100", "Message-Id": "<20190205181941.10484-1-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.19.1.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] cryptodev: rework mod exp and mod inv comments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch changes modular exponentiation and modular multiplicative\ninverse API comments to make it more precise.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\nv2:\n- grammar fixes\n\n lib/librte_cryptodev/rte_crypto_asym.h | 44 ++++++++++++++++++++++------------\n 1 file changed, 29 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h\nindex 5e185b2..9582ee3 100644\n--- a/lib/librte_cryptodev/rte_crypto_asym.h\n+++ b/lib/librte_cryptodev/rte_crypto_asym.h\n@@ -72,8 +72,8 @@ enum rte_crypto_asym_xform_type {\n \t * Refer to rte_crypto_asym_op_type\n \t */\n \tRTE_CRYPTO_ASYM_XFORM_MODINV,\n-\t/**< Modular Inverse\n-\t * Perform Modulus inverse b^(-1) mod n\n+\t/**< Modular Multiplicative Inverse\n+\t * Perform Modular Multiplicative Inverse b^(-1) mod n\n \t */\n \tRTE_CRYPTO_ASYM_XFORM_MODEX,\n \t/**< Modular Exponentiation\n@@ -233,29 +233,39 @@ struct rte_crypto_rsa_xform {\n struct rte_crypto_modex_xform {\n \trte_crypto_param modulus;\n \t/**< modulus\n-\t * Prime modulus of the modexp transform operation in octet-string\n-\t * network byte order format.\n+\t * Pointer to the modulus data for modexp transform operation\n+\t * in octet-string network byte order format, any positive integer\n+\t *\n+\t * In case this number is equal to zero the driver shall set\n+\t * the crypto op status field to RTE_CRYPTO_OP_STATUS_ERROR\n \t */\n \n \trte_crypto_param exponent;\n \t/**< exponent\n-\t * Private exponent of the modexp transform operation in\n-\t * octet-string network byte order format.\n+\t * Exponent of the modexp transform operation in\n+\t * octet-string network byte order format\n \t */\n };\n \n /**\n- * Asymmetric modular inverse transform operation\n+ * Asymmetric modular multiplicative inverse transform operation\n *\n- * Structure describing modulus inverse xform params\n+ * Structure describing modular multiplicative inverse transform\n *\n */\n struct rte_crypto_modinv_xform {\n \trte_crypto_param modulus;\n \t/**<\n-\t * Pointer to the prime modulus data for modular\n-\t * inverse operation in octet-string network byte\n-\t * order format.\n+\t * Pointer to the modulus data for modular multiplicative inverse\n+\t * operation in octet-string network byte order format,\n+\t * positive integer\n+\t *\n+\t * In case this number is equal to zero the driver shall set\n+\t * the crypto op status field to RTE_CRYPTO_OP_STATUS_ERROR\n+\t *\n+\t * This number shall be relatively prime to base\n+\t * in corresponding Modular Multiplicative Inverse\n+\t * rte_crypto_mod_op_param\n \t */\n };\n \n@@ -317,14 +327,18 @@ struct rte_crypto_dsa_xform {\n \n /**\n * Operations params for modular operations:\n- * exponentiation and invert\n+ * exponentiation and multiplicative inverse\n *\n */\n struct rte_crypto_mod_op_param {\n \trte_crypto_param base;\n \t/**<\n-\t * Pointer to base of modular exponentiation/inversion data in\n-\t * Octet-string network byte order format.\n+\t * Pointer to base of modular exponentiation/multiplicative\n+\t * inverse data in octet-string network byte order format.\n+\t *\n+\t * In case Multiplicative Inverse is used this number shall\n+\t * be relatively prime to modulus in corresponding Modular\n+\t * Multiplicative Inverse rte_crypto_modinv_xform\n \t */\n };\n \n@@ -348,7 +362,7 @@ struct rte_crypto_asym_xform {\n \t\t/**< Modular Exponentiation xform parameters */\n \n \t\tstruct rte_crypto_modinv_xform modinv;\n-\t\t/**< Modulus Inverse xform parameters */\n+\t\t/**< Modular Multiplicative Inverse xform parameters */\n \n \t\tstruct rte_crypto_dh_xform dh;\n \t\t/**< DH xform parameters */\n", "prefixes": [ "v2" ] }