Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50110/?format=api
{ "id": 50110, "url": "http://patches.dpdk.org/api/patches/50110/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190201100348.6730-1-jfreimann@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190201100348.6730-1-jfreimann@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190201100348.6730-1-jfreimann@redhat.com", "date": "2019-02-01T10:03:48", "name": "[v4] net/virtio: set offload flag for jumbo frames", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "54c941076e6282698b610cd3e9bdc97ac9212756", "submitter": { "id": 745, "url": "http://patches.dpdk.org/api/people/745/?format=api", "name": "Jens Freimann", "email": "jfreimann@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190201100348.6730-1-jfreimann@redhat.com/mbox/", "series": [ { "id": 3365, "url": "http://patches.dpdk.org/api/series/3365/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3365", "date": "2019-02-01T10:03:48", "name": "[v4] net/virtio: set offload flag for jumbo frames", "version": 4, "mbox": "http://patches.dpdk.org/series/3365/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50110/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F4601B4AD;\n\tFri, 1 Feb 2019 11:03:56 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 1D6241B4AB\n\tfor <dev@dpdk.org>; Fri, 1 Feb 2019 11:03:55 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 62973A0BF5;\n\tFri, 1 Feb 2019 10:03:54 +0000 (UTC)", "from localhost (unknown [10.36.118.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 920FB5D6AA;\n\tFri, 1 Feb 2019 10:03:49 +0000 (UTC)" ], "From": "Jens Freimann <jfreimann@redhat.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com,\n\tmaxime.coquelin@redhat.com", "Date": "Fri, 1 Feb 2019 11:03:48 +0100", "Message-Id": "<20190201100348.6730-1-jfreimann@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Fri, 01 Feb 2019 10:03:54 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v4] net/virtio: set offload flag for jumbo frames", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Port configuration fails because offload flags don't match the expected\nvalue when max-pkt-len is set to a value that should enable receive port\noffloading but doesn't.\n\nThere are two cases to consider:\n\n1. VIRTIO_NET_F_MTU is set. Then we need to check if the requested\n max-pkt-len fits into the MTU plus header. If yes we set the\n offload flag.\n2. VIRTIO_NET_F_MTU is not set. We can set the offload flag.\n\nFixes: a4996bd89c42 (\"ethdev: new Rx/Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jens Freimann <jfreimann@redhat.com>\n---\nv3->v4:\n * make use of hw-max_mtu which is calculated during device init. This\n way we don't have to re-read the mtu from config space again. This\n is safe because hw->max_mtu is not changed after init.\n\nv2->v3:\n * remove unnecessary brackets (Maxime)\n * fix commit message (David)\n\nv1->v2:\n * include virtnet hdr, ethernet header, vlan tag when comparing against\n max-rx-pkt-len (Maxime)\n\n drivers/net/virtio/virtio_ethdev.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 7c4c1df00..4cf91909d 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -2351,6 +2351,16 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tif ((host_features & tso_mask) == tso_mask)\n \t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO;\n \n+\tif (host_features & (1ULL << VIRTIO_NET_F_MTU)) {\n+\t\tuint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN +\n+\t\t\thw->vtnet_hdr_size;\n+\t\tif (dev->data->dev_conf.rxmode.max_rx_pkt_len <=\n+\t\t\t\thw->max_mtu + ether_hdr_len)\n+\t\t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t} else {\n+\t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t}\n+\n \tdev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS |\n \t\t\t\t DEV_TX_OFFLOAD_VLAN_INSERT;\n \tif (host_features & (1ULL << VIRTIO_NET_F_CSUM)) {\n", "prefixes": [ "v4" ] }