Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49500/?format=api
{ "id": 49500, "url": "http://patches.dpdk.org/api/patches/49500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/7b4ee39eb515cfebabefd43c77294ee55ab8092d.1546964889.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7b4ee39eb515cfebabefd43c77294ee55ab8092d.1546964889.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7b4ee39eb515cfebabefd43c77294ee55ab8092d.1546964889.git.anatoly.burakov@intel.com", "date": "2019-01-08T16:46:28", "name": "memalloc: fix pointer dereferencing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8653cc63045ef3e245b23f2ba202ecac034fa46e", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/7b4ee39eb515cfebabefd43c77294ee55ab8092d.1546964889.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 3050, "url": "http://patches.dpdk.org/api/series/3050/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3050", "date": "2019-01-08T16:46:28", "name": "memalloc: fix pointer dereferencing", "version": 1, "mbox": "http://patches.dpdk.org/series/3050/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49500/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/49500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B33211B55B;\n\tTue, 8 Jan 2019 17:46:33 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 3CBD51B54E;\n\tTue, 8 Jan 2019 17:46:31 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jan 2019 08:46:30 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 08 Jan 2019 08:46:29 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx08GkT6X032265; Tue, 8 Jan 2019 16:46:29 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x08GkSB1002279;\n\tTue, 8 Jan 2019 16:46:28 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x08GkSvn002275;\n\tTue, 8 Jan 2019 16:46:28 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,454,1539673200\"; d=\"scan'208\";a=\"136436337\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Tue, 8 Jan 2019 16:46:28 +0000", "Message-Id": "<7b4ee39eb515cfebabefd43c77294ee55ab8092d.1546964889.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] memalloc: fix pointer dereferencing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The original code was supposed to overwrite the value pointed to\nby the pointer, but the new one is instead overwriting the\npointer value itself, which has no effect outside that function.\nFix it by adding a pointer dereference.\n\nFixes: 582bed1e1d1d (\"mem: support mapping hugepages at runtime\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\nindex 60a0a680f..ccf268679 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n@@ -176,7 +176,7 @@ prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id)\n \t\tRTE_LOG(ERR, EAL,\n \t\t\t\"Failed to get current mempolicy: %s. \"\n \t\t\t\"Assuming MPOL_DEFAULT.\\n\", strerror(errno));\n-\t\toldpolicy = MPOL_DEFAULT;\n+\t\t*oldpolicy = MPOL_DEFAULT;\n \t}\n \tRTE_LOG(DEBUG, EAL,\n \t\t\"Setting policy MPOL_PREFERRED for socket %d\\n\",\n", "prefixes": [] }