Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4912/?format=api
{ "id": 4912, "url": "http://patches.dpdk.org/api/patches/4912/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1432687269-4696-1-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1432687269-4696-1-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1432687269-4696-1-git-send-email-konstantin.ananyev@intel.com", "date": "2015-05-27T00:41:09", "name": "[dpdk-dev,PATCHv2] mempool: fix pages computation to determine number of objects", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b506a2de3284501b73efbcc7ec182e6ba33e8179", "submitter": { "id": 33, "url": "http://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1432687269-4696-1-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/4912/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/4912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AFB9C5A97;\n\tWed, 27 May 2015 02:41:28 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 65F244A63\n\tfor <dev@dpdk.org>; Wed, 27 May 2015 02:41:27 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 May 2015 17:41:26 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 26 May 2015 17:41:25 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt4R0fOGU013581; Wed, 27 May 2015 01:41:24 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t4R0fOL3004800;\n\tWed, 27 May 2015 01:41:24 +0100", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t4R0fO4T004796;\n\tWed, 27 May 2015 01:41:24 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,502,1427785200\"; d=\"scan'208\";a=\"498628956\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 27 May 2015 01:41:09 +0100", "Message-Id": "<1432687269-4696-1-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1432571266-25840-2-git-send-email-adrien.mazarguil@6wind.com>", "References": "<1432571266-25840-2-git-send-email-adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCHv2] mempool: fix pages computation to determine\n\tnumber of objects", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "v2:\n- As suggested in comments use slightly different approach for the fix.\n\nIn rte_mempool_obj_iter(), when element boundary coincides with page boundary,\neven if a single page is required per object, a loop checks that the next page\nis contiguous and drops the first oneo therwise.\nThis commit checks subsequent pages only when several are required per object.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_mempool/rte_mempool.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 01972ba..ecb03b3 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -156,7 +156,7 @@ rte_mempool_obj_iter(void *vaddr, uint32_t elt_num, size_t elt_sz, size_t align,\n \trte_mempool_obj_iter_t obj_iter, void *obj_iter_arg)\n {\n \tuint32_t i, j, k;\n-\tuint32_t pgn;\n+\tuint32_t pgn, pgf;\n \tuintptr_t end, start, va;\n \tuintptr_t pg_sz;\n \n@@ -171,10 +171,14 @@ rte_mempool_obj_iter(void *vaddr, uint32_t elt_num, size_t elt_sz, size_t align,\n \t\tstart = RTE_ALIGN_CEIL(va, align);\n \t\tend = start + elt_sz;\n \n-\t\tpgn = (end >> pg_shift) - (start >> pg_shift);\n+\t\t/* index of the first page for the next element. */\n+\t\tpgf = (end >> pg_shift) - (start >> pg_shift);\n+\n+\t\t/* index of the last page for the current element. */\n+\t\tpgn = ((end - 1) >> pg_shift) - (start >> pg_shift);\n \t\tpgn += j;\n \n-\t\t/* do we have enough space left for the next element. */\n+\t\t/* do we have enough space left for the element. */\n \t\tif (pgn >= pg_num)\n \t\t\tbreak;\n \n@@ -194,7 +198,7 @@ rte_mempool_obj_iter(void *vaddr, uint32_t elt_num, size_t elt_sz, size_t align,\n \t\t\t\tobj_iter(obj_iter_arg, (void *)start,\n \t\t\t\t\t(void *)end, i);\n \t\t\tva = end;\n-\t\t\tj = pgn;\n+\t\t\tj += pgf;\n \t\t\ti++;\n \t\t} else {\n \t\t\tva = RTE_ALIGN_CEIL((va + 1), pg_sz);\n", "prefixes": [ "dpdk-dev", "PATCHv2" ] }