Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4759/?format=api
{ "id": 4759, "url": "http://patches.dpdk.org/api/patches/4759/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1431709847-5402-1-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1431709847-5402-1-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1431709847-5402-1-git-send-email-stephen@networkplumber.org", "date": "2015-05-15T17:10:47", "name": "[dpdk-dev] eal: reduce/change log severity levels", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7e153d37598e6564dbbc1c326849d8fb2c0875d2", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1431709847-5402-1-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/4759/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/4759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 712055A38;\n\tFri, 15 May 2015 19:10:50 +0200 (CEST)", "from mail-pa0-f52.google.com (mail-pa0-f52.google.com\n\t[209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 4D8255A30\n\tfor <dev@dpdk.org>; Fri, 15 May 2015 19:10:49 +0200 (CEST)", "by pabts4 with SMTP id ts4so18694583pab.3\n\tfor <dev@dpdk.org>; Fri, 15 May 2015 10:10:48 -0700 (PDT)", "from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by mx.google.com with ESMTPSA id\n\tte4sm2396649pbc.88.2015.05.15.10.10.45\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 15 May 2015 10:10:45 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=qTAxt1N33DL5hErNnj4/wyJPFRe07Bwv/S6ZIggwX2g=;\n\tb=X1UaHN2f8xxVo2okds8vzIIXireuPsYTJBql/CG6EcJ7/d4cVyWbPlpU3DyUpokLaT\n\tFH2o1MO96wB9GY+EmvnYs4YODw1TVCGSkglaD8f3mq2+52XZN8LYP2vJb+eKylVaEmNP\n\t0VQrhhY/oKF4KcEbzTVScHzzmh5ndNd1BcVzFwlXtGMTN4xOSDipvcSF7UKAs9xsYHww\n\tNnn/AV+qAeJIRERBfPhL4XkQqoPc3p1fnER+W6NK+WIUGRvuMqFVfajH+slZGOAOV98E\n\tZJizsW9/EoY11A7/dh7ARg7hFsNpW14cMv8Sw/UrCBBQ6OS9fD9LaYRmFtbjDaUqZ3br\n\tDeSA==", "X-Gm-Message-State": "ALoCoQlIdD7wgP/NQrUly/JuqEukMh0bt1RlHdqcCU955rZfYFoQY66H9IFi94J7q2AD+/nXl3ac", "X-Received": "by 10.70.88.170 with SMTP id bh10mr20273245pdb.62.1431709848738; \n\tFri, 15 May 2015 10:10:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Fri, 15 May 2015 10:10:47 -0700", "Message-Id": "<1431709847-5402-1-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "Subject": "[dpdk-dev] [PATCH] eal: reduce/change log severity levels", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the log level of startup messages. Anything that is\njust normal activity (like getting virtual areas) is changed\nto debug level. Anything that is a failure should be NOTICE\nor ERR severity.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 2 +-\n lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 11 +++++-----\n lib/librte_eal/linuxapp/eal/eal_memory.c | 27 +++++++++++++------------\n lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-\n lib/librte_eal/linuxapp/eal/eal_timer.c | 2 +-\n lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 6 +++---\n 6 files changed, 26 insertions(+), 24 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex bd770cf..8204102 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -797,7 +797,7 @@ rte_eal_init(int argc, char **argv)\n \trte_eal_mcfg_complete();\n \n \tTAILQ_FOREACH(solib, &solib_list, next) {\n-\t\tRTE_LOG(INFO, EAL, \"open shared lib %s\\n\", solib->name);\n+\t\tRTE_LOG(DEBUG, EAL, \"open shared lib %s\\n\", solib->name);\n \t\tsolib->lib_handle = dlopen(solib->name, RTLD_NOW);\n \t\tif (solib->lib_handle == NULL)\n \t\t\tRTE_LOG(WARNING, EAL, \"%s\\n\", dlerror());\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\nindex 028e309..b1eb39c 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\n@@ -214,7 +214,7 @@ clear_hugedir(const char * hugedir)\n \t/* open directory */\n \tdir = opendir(hugedir);\n \tif (!dir) {\n-\t\tRTE_LOG(INFO, EAL, \"Unable to open hugepage directory %s\\n\",\n+\t\tRTE_LOG(ERR, EAL, \"Unable to open hugepage directory %s\\n\",\n \t\t\t\thugedir);\n \t\tgoto error;\n \t}\n@@ -222,7 +222,7 @@ clear_hugedir(const char * hugedir)\n \n \tdirent = readdir(dir);\n \tif (!dirent) {\n-\t\tRTE_LOG(INFO, EAL, \"Unable to read hugepage directory %s\\n\",\n+\t\tRTE_LOG(ERR, EAL, \"Unable to read hugepage directory %s\\n\",\n \t\t\t\thugedir);\n \t\tgoto error;\n \t}\n@@ -262,7 +262,7 @@ error:\n \tif (dir)\n \t\tclosedir(dir);\n \n-\tRTE_LOG(INFO, EAL, \"Error while clearing hugepage dir: %s\\n\",\n+\tRTE_LOG(ERR, EAL, \"Error while clearing hugepage dir: %s\\n\",\n \t\tstrerror(errno));\n \n \treturn -1;\n@@ -297,8 +297,9 @@ eal_hugepage_info_init(void)\n \t\t\tif (hpi->hugedir == NULL){\n \t\t\t\tint32_t num_pages;\n \t\t\t\tif ((num_pages = get_num_hugepages(dirent->d_name)) > 0)\n-\t\t\t\t\tRTE_LOG(INFO, EAL, \"%u hugepages of size %llu reserved, \"\\\n-\t\t\t\t\t\t\t\"but no mounted hugetlbfs found for that size\\n\",\n+\t\t\t\t\tRTE_LOG(NOTICE, EAL,\n+\t\t\t\t\t\t\"%u hugepages of size %llu reserved, \"\n+\t\t\t\t\t\t\"but no mounted hugetlbfs found for that size\\n\",\n \t\t\t\t\t\t\t(unsigned)num_pages,\n \t\t\t\t\t\t\t(unsigned long long)hpi->hugepage_sz);\n \t\t\t} else {\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex 5f9f92e..aa373a8 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -239,7 +239,7 @@ get_virtual_area(size_t *size, size_t hugepage_sz)\n \t}\n \telse addr = NULL;\n \n-\tRTE_LOG(INFO, EAL, \"Ask a virtual area of 0x%zx bytes\\n\", *size);\n+\tRTE_LOG(DEBUG, EAL, \"Ask a virtual area of 0x%zx bytes\\n\", *size);\n \n \tfd = open(\"/dev/zero\", O_RDONLY);\n \tif (fd < 0){\n@@ -255,7 +255,8 @@ get_virtual_area(size_t *size, size_t hugepage_sz)\n \n \tif (addr == MAP_FAILED) {\n \t\tclose(fd);\n-\t\tRTE_LOG(INFO, EAL, \"Cannot get a virtual area\\n\");\n+\t\tRTE_LOG(ERR, EAL, \"Cannot get a virtual area: %s\\n\",\n+\t\t\tstrerror(errno));\n \t\treturn NULL;\n \t}\n \n@@ -268,7 +269,7 @@ get_virtual_area(size_t *size, size_t hugepage_sz)\n \taligned_addr &= (~(hugepage_sz - 1));\n \taddr = (void *)(aligned_addr);\n \n-\tRTE_LOG(INFO, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n+\tRTE_LOG(DEBUG, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n \t\taddr, *size);\n \n \t/* increment offset */\n@@ -604,7 +605,7 @@ find_numasocket(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)\n \n \tf = fopen(\"/proc/self/numa_maps\", \"r\");\n \tif (f == NULL) {\n-\t\tRTE_LOG(INFO, EAL, \"cannot open /proc/self/numa_maps,\"\n+\t\tRTE_LOG(NOTICE, EAL, \"cannot open /proc/self/numa_maps,\"\n \t\t\t\t\" consider that all memory is in socket_id 0\\n\");\n \t\treturn 0;\n \t}\n@@ -1001,7 +1002,7 @@ calc_num_pages_per_socket(uint64_t * memory,\n \t\t\t\t\t0x100000);\n \t\t\tavailable = requested -\n \t\t\t\t\t((unsigned) (memory[socket] / 0x100000));\n-\t\t\tRTE_LOG(INFO, EAL, \"Not enough memory available on socket %u! \"\n+\t\t\tRTE_LOG(ERR, EAL, \"Not enough memory available on socket %u! \"\n \t\t\t\t\t\"Requested: %uMB, available: %uMB\\n\", socket,\n \t\t\t\t\trequested, available);\n \t\t\treturn -1;\n@@ -1012,7 +1013,7 @@ calc_num_pages_per_socket(uint64_t * memory,\n \tif (total_mem > 0) {\n \t\trequested = (unsigned) (internal_config.memory / 0x100000);\n \t\tavailable = requested - (unsigned) (total_mem / 0x100000);\n-\t\tRTE_LOG(INFO, EAL, \"Not enough memory available! Requested: %uMB,\"\n+\t\tRTE_LOG(ERR, EAL, \"Not enough memory available! Requested: %uMB,\"\n \t\t\t\t\" available: %uMB\\n\", requested, available);\n \t\treturn -1;\n \t}\n@@ -1218,13 +1219,13 @@ rte_eal_hugepage_init(void)\n \tfor (i = 0; i < (int) internal_config.num_hugepage_sizes; i++) {\n \t\tfor (j = 0; j < RTE_MAX_NUMA_NODES; j++) {\n \t\t\tif (used_hp[i].num_pages[j] > 0) {\n-\t\t\t\tRTE_LOG(INFO, EAL,\n-\t\t\t\t\t\t\"Requesting %u pages of size %uMB\"\n-\t\t\t\t\t\t\" from socket %i\\n\",\n-\t\t\t\t\t\tused_hp[i].num_pages[j],\n-\t\t\t\t\t\t(unsigned)\n-\t\t\t\t\t\t\t(used_hp[i].hugepage_sz / 0x100000),\n-\t\t\t\t\t\tj);\n+\t\t\t\tRTE_LOG(DEBUG, EAL,\n+\t\t\t\t\t\"Requesting %u pages of size %uMB\"\n+\t\t\t\t\t\" from socket %i\\n\",\n+\t\t\t\t\tused_hp[i].num_pages[j],\n+\t\t\t\t\t(unsigned)\n+\t\t\t\t\t(used_hp[i].hugepage_sz / 0x100000),\n+\t\t\t\t\tj);\n \t\t\t}\n \t\t}\n \t}\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\nindex 426953a..284fa9f 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n@@ -899,7 +899,7 @@ pci_vfio_enable(void)\n \tif (vfio_cfg.vfio_container_fd != -1)\n \t\tvfio_cfg.vfio_enabled = 1;\n \telse\n-\t\tRTE_LOG(INFO, EAL, \"VFIO support could not be initialized\\n\");\n+\t\tRTE_LOG(NOTICE, EAL, \"VFIO support could not be initialized\\n\");\n \n \treturn 0;\n }\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c\nindex 169c6e1..94909ed 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_timer.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_timer.c\n@@ -188,7 +188,7 @@ rte_eal_hpet_init(int make_default)\n \tint fd, ret;\n \n \tif (internal_config.no_hpet) {\n-\t\tRTE_LOG(INFO, EAL, \"HPET is disabled\\n\");\n+\t\tRTE_LOG(NOTICE, EAL, \"HPET is disabled\\n\");\n \t\treturn -1;\n \t}\n \ndiff --git a/lib/librte_eal/linuxapp/eal/eal_xen_memory.c b/lib/librte_eal/linuxapp/eal/eal_xen_memory.c\nindex 9246f83..d228a9d 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_xen_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_xen_memory.c\n@@ -86,7 +86,7 @@ xen_get_virtual_area(size_t *size, size_t mem_size)\n \tint fd;\n \tlong aligned_addr;\n \n-\tRTE_LOG(INFO, EAL, \"Ask a virtual area of 0x%zu bytes\\n\", *size);\n+\tRTE_LOG(DEBUG, EAL, \"Ask a virtual area of 0x%zu bytes\\n\", *size);\n \n \tfd = open(\"/dev/zero\", O_RDONLY);\n \tif (fd < 0){\n@@ -102,7 +102,7 @@ xen_get_virtual_area(size_t *size, size_t mem_size)\n \n \tif (addr == MAP_FAILED) {\n \t\tclose(fd);\n-\t\tRTE_LOG(INFO, EAL, \"Cannot get a virtual area\\n\");\n+\t\tRTE_LOG(ERR, EAL, \"Cannot get a virtual area\\n\");\n \t\treturn NULL;\n \t}\n \n@@ -114,7 +114,7 @@ xen_get_virtual_area(size_t *size, size_t mem_size)\n \taligned_addr = RTE_ALIGN_CEIL(aligned_addr, mem_size);\n addr = (void *)(aligned_addr);\n \n-\tRTE_LOG(INFO, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n+\tRTE_LOG(DEBUG, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n \t\taddr, *size);\n \n \treturn addr;\n", "prefixes": [ "dpdk-dev" ] }