Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47321/?format=api
{ "id": 47321, "url": "http://patches.dpdk.org/api/patches/47321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/808a0ac238cd8a9924e7cc881a18f42c421197ee.1540384475.git.shahafs@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<808a0ac238cd8a9924e7cc881a18f42c421197ee.1540384475.git.shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/808a0ac238cd8a9924e7cc881a18f42c421197ee.1540384475.git.shahafs@mellanox.com", "date": "2018-10-24T12:36:13", "name": "[1/3] net/mlx5: rename static functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e4daa8215f703e4293455a263f612ade45a7f941", "submitter": { "id": 634, "url": "http://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/808a0ac238cd8a9924e7cc881a18f42c421197ee.1540384475.git.shahafs@mellanox.com/mbox/", "series": [ { "id": 2067, "url": "http://patches.dpdk.org/api/series/2067/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2067", "date": "2018-10-24T12:36:12", "name": "fix flow tunnel handling", "version": 1, "mbox": "http://patches.dpdk.org/series/2067/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47321/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5169F1B1FF;\n\tWed, 24 Oct 2018 14:38:51 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id EAA431B1FD\n\tfor <dev@dpdk.org>; Wed, 24 Oct 2018 14:38:49 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tshahafs@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 24 Oct 2018 14:43:54 +0200", "from unicorn01.mtl.labs.mlnx. (unicorn01.mtl.labs.mlnx\n\t[10.7.12.62])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w9OCaLct001458;\n\tWed, 24 Oct 2018 15:38:46 +0300" ], "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "shahafs@mellanox.com", "Cc": "dev@dpdk.org, yskoh@mellanox.com", "Date": "Wed, 24 Oct 2018 15:36:13 +0300", "Message-Id": "<808a0ac238cd8a9924e7cc881a18f42c421197ee.1540384475.git.shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<cover.1540384475.git.shahafs@mellanox.com>", "References": "<cover.1540384475.git.shahafs@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 1/3] net/mlx5: rename static functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yongseok Koh <yskoh@mellanox.com>\n\nIn mlx5_flow*.c, static functions have names starting from 'flow_' while\nshared ones start from \"mlx5_flow_'.\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 62 +++++++++++++++++++--------------------\n 1 file changed, 30 insertions(+), 32 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 6219c9d68a..68eb7da3f6 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -505,7 +505,7 @@ mlx5_flow_hashfields_adjust(struct mlx5_flow *dev_flow,\n * Rx queue to update.\n */\n static void\n-mlx5_flow_rxq_tunnel_ptype_update(struct mlx5_rxq_ctrl *rxq_ctrl)\n+flow_rxq_tunnel_ptype_update(struct mlx5_rxq_ctrl *rxq_ctrl)\n {\n \tunsigned int i;\n \tuint32_t tunnel_ptype = 0;\n@@ -533,7 +533,7 @@ mlx5_flow_rxq_tunnel_ptype_update(struct mlx5_rxq_ctrl *rxq_ctrl)\n * Pointer to flow structure.\n */\n static void\n-mlx5_flow_rxq_flags_set(struct rte_eth_dev *dev, struct rte_flow *flow)\n+flow_rxq_flags_set(struct rte_eth_dev *dev, struct rte_flow *flow)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tconst int mark = !!(flow->actions &\n@@ -562,7 +562,7 @@ mlx5_flow_rxq_flags_set(struct rte_eth_dev *dev, struct rte_flow *flow)\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\t\t\tmlx5_flow_rxq_tunnel_ptype_update(rxq_ctrl);\n+\t\t\tflow_rxq_tunnel_ptype_update(rxq_ctrl);\n \t\t}\n \t}\n }\n@@ -577,7 +577,7 @@ mlx5_flow_rxq_flags_set(struct rte_eth_dev *dev, struct rte_flow *flow)\n * Pointer to the flow.\n */\n static void\n-mlx5_flow_rxq_flags_trim(struct rte_eth_dev *dev, struct rte_flow *flow)\n+flow_rxq_flags_trim(struct rte_eth_dev *dev, struct rte_flow *flow)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tconst int mark = !!(flow->actions &\n@@ -607,7 +607,7 @@ mlx5_flow_rxq_flags_trim(struct rte_eth_dev *dev, struct rte_flow *flow)\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\t\t\tmlx5_flow_rxq_tunnel_ptype_update(rxq_ctrl);\n+\t\t\tflow_rxq_tunnel_ptype_update(rxq_ctrl);\n \t\t}\n \t}\n }\n@@ -619,7 +619,7 @@ mlx5_flow_rxq_flags_trim(struct rte_eth_dev *dev, struct rte_flow *flow)\n * Pointer to Ethernet device.\n */\n static void\n-mlx5_flow_rxq_flags_clear(struct rte_eth_dev *dev)\n+flow_rxq_flags_clear(struct rte_eth_dev *dev)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tunsigned int i;\n@@ -1914,7 +1914,7 @@ mlx5_flow_validate(struct rte_eth_dev *dev,\n * Pointer to the RSS action if exist, else return NULL.\n */\n static const struct rte_flow_action_rss*\n-mlx5_flow_get_rss_action(const struct rte_flow_action actions[])\n+flow_get_rss_action(const struct rte_flow_action actions[])\n {\n \tfor (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {\n \t\tswitch (actions->type) {\n@@ -1929,7 +1929,7 @@ mlx5_flow_get_rss_action(const struct rte_flow_action actions[])\n }\n \n static unsigned int\n-mlx5_find_graph_root(const struct rte_flow_item pattern[], uint32_t rss_level)\n+find_graph_root(const struct rte_flow_item pattern[], uint32_t rss_level)\n {\n \tconst struct rte_flow_item *item;\n \tunsigned int has_vlan = 0;\n@@ -1967,12 +1967,11 @@ mlx5_find_graph_root(const struct rte_flow_item pattern[], uint32_t rss_level)\n * A flow on success, NULL otherwise and rte_errno is set.\n */\n static struct rte_flow *\n-mlx5_flow_list_create(struct rte_eth_dev *dev,\n-\t\t struct mlx5_flows *list,\n-\t\t const struct rte_flow_attr *attr,\n-\t\t const struct rte_flow_item items[],\n-\t\t const struct rte_flow_action actions[],\n-\t\t struct rte_flow_error *error)\n+flow_list_create(struct rte_eth_dev *dev, struct mlx5_flows *list,\n+\t\t const struct rte_flow_attr *attr,\n+\t\t const struct rte_flow_item items[],\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *error)\n {\n \tstruct rte_flow *flow = NULL;\n \tstruct mlx5_flow *dev_flow;\n@@ -1992,7 +1991,7 @@ mlx5_flow_list_create(struct rte_eth_dev *dev,\n \tif (ret < 0)\n \t\treturn NULL;\n \tflow_size = sizeof(struct rte_flow);\n-\trss = mlx5_flow_get_rss_action(actions);\n+\trss = flow_get_rss_action(actions);\n \tif (rss)\n \t\tflow_size += RTE_ALIGN_CEIL(rss->queue_num * sizeof(uint16_t),\n \t\t\t\t\t sizeof(void *));\n@@ -2007,7 +2006,7 @@ mlx5_flow_list_create(struct rte_eth_dev *dev,\n \tif (rss && rss->types) {\n \t\tunsigned int graph_root;\n \n-\t\tgraph_root = mlx5_find_graph_root(items, rss->level);\n+\t\tgraph_root = find_graph_root(items, rss->level);\n \t\tret = rte_flow_expand_rss(buf, sizeof(expand_buffer.buffer),\n \t\t\t\t\t items, rss->types,\n \t\t\t\t\t mlx5_support_expansion,\n@@ -2038,7 +2037,7 @@ mlx5_flow_list_create(struct rte_eth_dev *dev,\n \t\t\tgoto error;\n \t}\n \tTAILQ_INSERT_TAIL(list, flow, next);\n-\tmlx5_flow_rxq_flags_set(dev, flow);\n+\tflow_rxq_flags_set(dev, flow);\n \treturn flow;\n error:\n \tret = rte_errno; /* Save rte_errno before cleanup. */\n@@ -2062,9 +2061,9 @@ mlx5_flow_create(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_action actions[],\n \t\t struct rte_flow_error *error)\n {\n-\treturn mlx5_flow_list_create\n-\t\t(dev, &((struct priv *)dev->data->dev_private)->flows,\n-\t\t attr, items, actions, error);\n+\treturn flow_list_create(dev,\n+\t\t\t\t&((struct priv *)dev->data->dev_private)->flows,\n+\t\t\t\tattr, items, actions, error);\n }\n \n /**\n@@ -2078,8 +2077,8 @@ mlx5_flow_create(struct rte_eth_dev *dev,\n * Flow to destroy.\n */\n static void\n-mlx5_flow_list_destroy(struct rte_eth_dev *dev, struct mlx5_flows *list,\n-\t\t struct rte_flow *flow)\n+flow_list_destroy(struct rte_eth_dev *dev, struct mlx5_flows *list,\n+\t\t struct rte_flow *flow)\n {\n \tflow_drv_destroy(dev, flow);\n \tTAILQ_REMOVE(list, flow, next);\n@@ -2088,7 +2087,7 @@ mlx5_flow_list_destroy(struct rte_eth_dev *dev, struct mlx5_flows *list,\n \t * already clean.\n \t */\n \tif (dev->data->dev_started)\n-\t\tmlx5_flow_rxq_flags_trim(dev, flow);\n+\t\tflow_rxq_flags_trim(dev, flow);\n \trte_free(flow);\n }\n \n@@ -2107,7 +2106,7 @@ mlx5_flow_list_flush(struct rte_eth_dev *dev, struct mlx5_flows *list)\n \t\tstruct rte_flow *flow;\n \n \t\tflow = TAILQ_FIRST(list);\n-\t\tmlx5_flow_list_destroy(dev, list, flow);\n+\t\tflow_list_destroy(dev, list, flow);\n \t}\n }\n \n@@ -2126,7 +2125,7 @@ mlx5_flow_stop(struct rte_eth_dev *dev, struct mlx5_flows *list)\n \n \tTAILQ_FOREACH_REVERSE(flow, list, mlx5_flows, next)\n \t\tflow_drv_remove(dev, flow);\n-\tmlx5_flow_rxq_flags_clear(dev);\n+\tflow_rxq_flags_clear(dev);\n }\n \n /**\n@@ -2151,7 +2150,7 @@ mlx5_flow_start(struct rte_eth_dev *dev, struct mlx5_flows *list)\n \t\tret = flow_drv_apply(dev, flow, &error);\n \t\tif (ret < 0)\n \t\t\tgoto error;\n-\t\tmlx5_flow_rxq_flags_set(dev, flow);\n+\t\tflow_rxq_flags_set(dev, flow);\n \t}\n \treturn 0;\n error:\n@@ -2260,8 +2259,8 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev,\n \t}\n \tfor (i = 0; i != priv->reta_idx_n; ++i)\n \t\tqueue[i] = (*priv->reta_idx)[i];\n-\tflow = mlx5_flow_list_create(dev, &priv->ctrl_flows, &attr, items,\n-\t\t\t\t actions, &error);\n+\tflow = flow_list_create(dev, &priv->ctrl_flows,\n+\t\t\t\t&attr, items, actions, &error);\n \tif (!flow)\n \t\treturn -rte_errno;\n \treturn 0;\n@@ -2301,7 +2300,7 @@ mlx5_flow_destroy(struct rte_eth_dev *dev,\n {\n \tstruct priv *priv = dev->data->dev_private;\n \n-\tmlx5_flow_list_destroy(dev, &priv->flows, flow);\n+\tflow_list_destroy(dev, &priv->flows, flow);\n \treturn 0;\n }\n \n@@ -2609,9 +2608,8 @@ mlx5_fdir_filter_add(struct rte_eth_dev *dev,\n \tret = mlx5_fdir_filter_convert(dev, fdir_filter, &attributes);\n \tif (ret)\n \t\treturn ret;\n-\tflow = mlx5_flow_list_create(dev, &priv->flows, &attributes.attr,\n-\t\t\t\t attributes.items, attributes.actions,\n-\t\t\t\t &error);\n+\tflow = flow_list_create(dev, &priv->flows, &attributes.attr,\n+\t\t\t\tattributes.items, attributes.actions, &error);\n \tif (flow) {\n \t\tDRV_LOG(DEBUG, \"port %u FDIR created %p\", dev->data->port_id,\n \t\t\t(void *)flow);\n", "prefixes": [ "1/3" ] }