Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47006/?format=api
{ "id": 47006, "url": "http://patches.dpdk.org/api/patches/47006/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181018001949.17443-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181018001949.17443-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181018001949.17443-1-thomas@monjalon.net", "date": "2018-10-18T00:19:49", "name": "devargs: fix freeing during device removal", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "64e9b4d2cd9eb96cd5c705dd02506e0c6c9e9c86", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181018001949.17443-1-thomas@monjalon.net/mbox/", "series": [ { "id": 1963, "url": "http://patches.dpdk.org/api/series/1963/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1963", "date": "2018-10-18T00:19:49", "name": "devargs: fix freeing during device removal", "version": 1, "mbox": "http://patches.dpdk.org/series/1963/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47006/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 076905F51;\n\tThu, 18 Oct 2018 02:20:23 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8094D5F44\n\tfor <dev@dpdk.org>; Thu, 18 Oct 2018 02:20:21 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E8E5721B36;\n\tWed, 17 Oct 2018 20:20:20 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Wed, 17 Oct 2018 20:20:20 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 7AE5AE4680;\n\tWed, 17 Oct 2018 20:20:19 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding; s=mesmtp; bh=+o83ooeDZTzSUvUqvY2dg84\n\tBvcFA0I6GjW7atqZYOKE=; b=plZ1w/3IV/fUbmqSRhT6wtwVoXx1t7U611ftOAJ\n\tOpwexCdoLo9ko0OsQNfKbVZ42oTqQ3XtwgUuZOVOzQH1c0ljGjNuGrKREy3NxMUy\n\tvMGi6sllmc5Qg4QXMQkbUbT0HFX1R01NrMOplSmHFTzmSl9bsd5rxqap8DiMHLDk\n\trkXE=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+o83ooeDZTzSUvUqv\n\tY2dg84BvcFA0I6GjW7atqZYOKE=; b=Ai9K8cCODh26ax3vCyEBOlPqqsIn59IvP\n\tWclm3rzqTHu2vwdfeDa8kvQm5VUPCHd0Y8RNTOUVVbX8MqT5dIwYlmzYbO3f9IcE\n\tfOJDZBavXa/WlZtDq+ovrI91kjveEJ1DGDOcHiJ9FXKWE6LHDMamkRiYdA0l1BFJ\n\toBa3650e+ZYe/qjCK7X/LUTpxRFlmz9oA+avTL1RNLaelMv62ahITTggSqGOTnp1\n\tjwDoHTxYG3bv7YVebz3rBYtLmx6ltSiEaOY4CzUO6IVRlvjkNo2TsGpr10zo99vN\n\t/wHe4BdQsGbg0J7zGJ2uJ27UhA5fMIoKKOtQ7LbMAvlTpwiKMOOTw==" ], "X-ME-Sender": "<xms:xNHHW65njJ8LvIXxu5jReuqHhxHfXJwODot_PBd6hFzWwOlxaObZ-A>", "X-ME-Proxy": "<xmx:xNHHW0aUMhyg9R5YmMSl-E3dKFDqrtRjRv8MHzvj0suyIID3AcpRhg>\n\t<xmx:xNHHW_Hazw1BZAFI0_Ko4SrBx2o-PWiz0HTfFvuYzmvJ1AagqBvIpA>\n\t<xmx:xNHHW5wEO8cOxQMnMqjK_ejHCUBvDey5jteH8F3LWpov8HJZsdBCVg>\n\t<xmx:xNHHWxHaZYBdGtZRS74SzlKu1XICUwGGkJs1BxbbU-0Laj-vjTL_tw>\n\t<xmx:xNHHW-u3OV2mfV1fiuvTUMAlBS0wrcUL_IwIBh1sSaTjQR5pC_oGOA>\n\t<xmx:xNHHW08RGGb3ZUlo_cUCsqIRw-R7SCs9VBDGxyL325gwCRgBfRjzLw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "gaetan.rivet@6wind.com, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n\twisamm@mellanox.com, ophirmu@mellanox.com", "Date": "Thu, 18 Oct 2018 02:19:49 +0200", "Message-Id": "<20181018001949.17443-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] devargs: fix freeing during device removal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After calling unplug function of a bus, the device is expected\nto be freed. It is too late for getting devargs to remove.\nAnyway, the buses which implement unplug are already freeing\nthe devargs, except the PCI bus.\nSo the call to rte_devargs_remove() is removed from EAL and\nadded in PCI.\n\nFixes: 2effa126fbd8 (\"devargs: simplify parameters of removal function\")\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/bus/pci/pci_common.c | 1 +\n lib/librte_eal/common/eal_common_dev.c | 2 --\n 2 files changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 41f8fc27e..feb79803c 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -522,6 +522,7 @@ pci_unplug(struct rte_device *dev)\n \tret = rte_pci_detach_dev(pdev);\n \tif (ret == 0) {\n \t\trte_pci_remove_device(pdev);\n+\t\trte_devargs_remove(dev->devargs);\n \t\tfree(pdev);\n \t}\n \treturn ret;\ndiff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 0c873bfe0..8b0844af1 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -372,8 +372,6 @@ local_dev_remove(struct rte_device *dev)\n \t\treturn ret;\n \t}\n \n-\trte_devargs_remove(dev->devargs);\n-\n \treturn 0;\n }\n \n", "prefixes": [] }