Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 46298,
    "url": "http://patches.dpdk.org/api/patches/46298/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1539033410-21422-1-git-send-email-ed.czeck@atomicrules.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1539033410-21422-1-git-send-email-ed.czeck@atomicrules.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1539033410-21422-1-git-send-email-ed.czeck@atomicrules.com",
    "date": "2018-10-08T21:16:48",
    "name": "[1/3] net/ark: add recovery code for lack of mbufs during runtime",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "e3cc1affbc4e24efa19aa9787233c9058c7fc1fb",
    "submitter": {
        "id": 699,
        "url": "http://patches.dpdk.org/api/people/699/?format=api",
        "name": "Ed Czeck",
        "email": "ed.czeck@atomicrules.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1539033410-21422-1-git-send-email-ed.czeck@atomicrules.com/mbox/",
    "series": [
        {
            "id": 1764,
            "url": "http://patches.dpdk.org/api/series/1764/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1764",
            "date": "2018-10-08T21:16:48",
            "name": "[1/3] net/ark: add recovery code for lack of mbufs during runtime",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1764/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/46298/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/46298/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8AC655B2C;\n\tMon,  8 Oct 2018 23:17:05 +0200 (CEST)",
            "from mail-qt1-f195.google.com (mail-qt1-f195.google.com\n\t[209.85.160.195]) by dpdk.org (Postfix) with ESMTP id 1E68156A3\n\tfor <dev@dpdk.org>; Mon,  8 Oct 2018 23:17:04 +0200 (CEST)",
            "by mail-qt1-f195.google.com with SMTP id e22-v6so15476737qto.6\n\tfor <dev@dpdk.org>; Mon, 08 Oct 2018 14:17:04 -0700 (PDT)",
            "from z170.home (pool-173-48-117-246.bstnma.fios.verizon.net.\n\t[173.48.117.246]) by smtp.gmail.com with ESMTPSA id\n\ty28-v6sm2699953qtj.9.2018.10.08.14.17.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 08 Oct 2018 14:17:02 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=atomicrules-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=yNiZejSGepLIRKE/Ome0luF8jHE5aDwh6wmIlpq6SiY=;\n\tb=c3/x0ncu6OnlEnvjUXrVony3ycB9uN6uWWDYrPmwg5PQ1tF9n17Vg4sez5JHQbJUqR\n\t1FlOxmHq5kPLieMsyGR5TZa13DfjrWPoj3ekEg1Uru5lRwqZ9FOSVP3BiZO6LTOzRJkk\n\tnsTM5YCDteZYDWVNURwMrmPz2rRG02K75rSYzwEVrdfzjQGjp7to++f0b4KPsCwTqiEQ\n\t3c0dhFFG5NGdbq7K0n1uBHqGCdyk/ephXrZzWGV56ZRq9TBaso5GTROA+Szeky+d0tnk\n\t38IoLmzIRYu9QHeRYDDtUitv/q+CUEWB7mavTef3xaIsUVhQOINNII5+1AqtwUzmlewN\n\tbaOQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=yNiZejSGepLIRKE/Ome0luF8jHE5aDwh6wmIlpq6SiY=;\n\tb=GloXeAd1KosqxVXQbP3v2jZ7/QY+by/wx3PI2EG1275bDYLjBb5e/FKxp+26tGCDAs\n\tIguw9Zl/PP7mWZCOa52ECtt87Mn6bgL9f6p5m9458mtn1HN6nsKtQIeCDSoyQ2pG7eY7\n\tUlTqMjSIF3l2yBGvavGfJUu1rrkaFXcW3svNnjqSkzXPLMCBmgeAD0+Y6T+zcTmip6Iu\n\t1CaEkdyH8XDOF8jlKJrxn7qGzbb+k+bGkAlZ662GAggXA5VDo2e7vX2fdYDTch4VOqrc\n\tZjEXLxOXkNVjrebyaYHG8Ioa0pCXqnYQcBC3H2hgs0vIdmxrkxX18jDz9oiWNKPGO+G7\n\tIjAg==",
        "X-Gm-Message-State": "ABuFfogtxAtHIJ876koMxHkPJNrVDxOjqhdd83UHy0aYXfk1a73aq+Vs\n\tnD2jyaOl142hRsLXZ3bv1uS5LUFLmsk=",
        "X-Google-Smtp-Source": "ACcGV61dEHOurIaxCpnj2VfFimUHZTpRrup+uKTa1ad7Hncb+uJMvS5Mbys5tkKH/+uw/Cmw3Zwfqw==",
        "X-Received": "by 2002:a0c:9923:: with SMTP id\n\th32-v6mr20600792qvd.81.1539033423032; \n\tMon, 08 Oct 2018 14:17:03 -0700 (PDT)",
        "From": "Ed Czeck <ed.czeck@atomicrules.com>",
        "To": "dev@dpdk.org",
        "Cc": "john.miller@atomicrules.com, shepard.siegel@atomicrules.com,\n\tferruh.yigit@intel.com, Ed Czeck <ed.czeck@atomicrules.com>",
        "Date": "Mon,  8 Oct 2018 17:16:48 -0400",
        "Message-Id": "<1539033410-21422-1-git-send-email-ed.czeck@atomicrules.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH 1/3] net/ark: add recovery code for lack of mbufs\n\tduring runtime",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fail with rte_exit() when the lack of mbufs is not recoverable.\n\nSigned-off-by: Ed Czeck <ed.czeck@atomicrules.com>\n---\n drivers/net/ark/ark_ethdev_rx.c | 52 ++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 46 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c\nindex 16f0d11..77149f6 100644\n--- a/drivers/net/ark/ark_ethdev_rx.c\n+++ b/drivers/net/ark/ark_ethdev_rx.c\n@@ -25,6 +25,9 @@ static uint32_t eth_ark_rx_jumbo(struct ark_rx_queue *queue,\n \t\t\t\t struct rte_mbuf *mbuf0,\n \t\t\t\t uint32_t cons_index);\n static inline int eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue);\n+static int eth_ark_rx_seed_recovery(struct ark_rx_queue *queue,\n+\t\t\t\t    uint32_t *pnb,\n+\t\t\t\t    struct rte_mbuf **mbufs);\n \n /* ************************************************************************* */\n struct ark_rx_queue {\n@@ -196,20 +199,25 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t/* populate mbuf reserve */\n \tstatus = eth_ark_rx_seed_mbufs(queue);\n \n+\tif (queue->seed_index != nb_desc) {\n+\t\tPMD_DRV_LOG(ERR, \"ARK: Failed to allocate %u mbufs for RX queue %d\\n\",\n+\t\t\t    nb_desc, qidx);\n+\t\tstatus = -1;\n+\t}\n \t/* MPU Setup */\n \tif (status == 0)\n \t\tstatus = eth_ark_rx_hw_setup(dev, queue, qidx, queue_idx);\n \n \tif (unlikely(status != 0)) {\n-\t\tstruct rte_mbuf *mbuf;\n+\t\tstruct rte_mbuf **mbuf;\n \n \t\tPMD_DRV_LOG(ERR, \"Failed to initialize RX queue %d %s\\n\",\n \t\t\t    qidx,\n \t\t\t    __func__);\n \t\t/* Free the mbufs allocated */\n-\t\tfor (i = 0, mbuf = queue->reserve_q[0];\n-\t\t     i < nb_desc; ++i, mbuf++) {\n-\t\t\trte_pktmbuf_free(mbuf);\n+\t\tfor (i = 0, mbuf = queue->reserve_q;\n+\t\t     i < queue->seed_index; ++i, mbuf++) {\n+\t\t\trte_pktmbuf_free(*mbuf);\n \t\t}\n \t\trte_free(queue->reserve_q);\n \t\trte_free(queue->paddress_q);\n@@ -446,8 +454,13 @@ eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue)\n \tstruct rte_mbuf **mbufs = &queue->reserve_q[seed_m];\n \tint status = rte_pktmbuf_alloc_bulk(queue->mb_pool, mbufs, nb);\n \n-\tif (unlikely(status != 0))\n-\t\treturn -1;\n+\tif (unlikely(status != 0)) {\n+\t\t/* Try to recover from lack of mbufs in pool */\n+\t\tstatus = eth_ark_rx_seed_recovery(queue, &nb, mbufs);\n+\t\tif (unlikely(status != 0)) {\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n \n \tif (ARK_RX_DEBUG) {\t\t/* DEBUG */\n \t\twhile (count != nb) {\n@@ -495,6 +508,33 @@ eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue)\n \treturn 0;\n }\n \n+int\n+eth_ark_rx_seed_recovery(struct ark_rx_queue *queue,\n+\t\t\t uint32_t *pnb,\n+\t\t\t struct rte_mbuf **mbufs)\n+{\n+\tint status = -1;\n+\n+\t/* Ignore small allocation failures */\n+\tif (*pnb <= 64)\n+\t\treturn -1;\n+\n+\t*pnb = 64U;\n+\tstatus = rte_pktmbuf_alloc_bulk(queue->mb_pool, mbufs, *pnb);\n+\tif (status != 0) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t    \"ARK: Could not allocate %u mbufs from pool for RX queue %u;\"\n+\t\t\t    \" %u free buffers remaining in queue\\n\",\n+\t\t\t    *pnb, queue->queue_index,\n+\t\t\t    queue->seed_index - queue->cons_index);\n+\t\tif (queue->seed_index - queue->cons_index < 64) {\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"ARK: No mbufs in pool;  do you have a leak?\\n\");\n+\t\t}\n+\t}\n+\treturn status;\n+}\n+\n void\n eth_ark_rx_dump_queue(struct rte_eth_dev *dev, uint16_t queue_id,\n \t\t      const char *msg)\n",
    "prefixes": [
        "1/3"
    ]
}