Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45825/?format=api
{ "id": 45825, "url": "http://patches.dpdk.org/api/patches/45825/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-8-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181002093651.24795-8-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181002093651.24795-8-maxime.coquelin@redhat.com", "date": "2018-10-02T09:36:41", "name": "[v2,07/17] vhost: enable fds passing when sending vhost-user messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9be54d3d52970919fd716f03ff91cde7e33a7845", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-8-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1630, "url": "http://patches.dpdk.org/api/series/1630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1630", "date": "2018-10-02T09:36:34", "name": "vhost: add postcopy live-migration support", "version": 2, "mbox": "http://patches.dpdk.org/series/1630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45825/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D6C214C8F;\n\tTue, 2 Oct 2018 11:37:39 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id BFCC65323;\n\tTue, 2 Oct 2018 11:37:37 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1AB053084217;\n\tTue, 2 Oct 2018 09:37:37 +0000 (UTC)", "from localhost.localdomain (ovpn-112-50.ams2.redhat.com\n\t[10.36.112.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E5D5A17119;\n\tTue, 2 Oct 2018 09:37:33 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 2 Oct 2018 11:36:41 +0200", "Message-Id": "<20181002093651.24795-8-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "References": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.40]); Tue, 02 Oct 2018 09:37:37 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 07/17] vhost: enable fds passing when sending\n\tvhost-user messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Passing userfault fds to Qemu will be required for postcopy\nlive-migration feature.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 27 +++++++++++++++------------\n 1 file changed, 15 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 050fc8bf9..436ab7bf5 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -171,6 +171,7 @@ vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \n \tmsg->payload.u64 = features;\n \tmsg->size = sizeof(msg->payload.u64);\n+\tmsg->fd_num = 0;\n \n \treturn VH_RESULT_REPLY;\n }\n@@ -189,6 +190,7 @@ vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \n \tmsg->payload.u64 = (uint64_t)queue_num;\n \tmsg->size = sizeof(msg->payload.u64);\n+\tmsg->fd_num = 0;\n \n \treturn VH_RESULT_REPLY;\n }\n@@ -1174,6 +1176,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev,\n \tvq->batch_copy_elems = NULL;\n \n \tmsg->size = sizeof(msg->payload.state);\n+\tmsg->fd_num = 0;\n \n \treturn VH_RESULT_REPLY;\n }\n@@ -1233,6 +1236,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,\n \n \tmsg->payload.u64 = protocol_features;\n \tmsg->size = sizeof(msg->payload.u64);\n+\tmsg->fd_num = 0;\n \n \treturn VH_RESULT_REPLY;\n }\n@@ -1315,6 +1319,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \tdev->log_size = size;\n \n \tmsg->size = sizeof(msg->payload.u64);\n+\tmsg->fd_num = 0;\n \n \treturn VH_RESULT_REPLY;\n }\n@@ -1561,13 +1566,13 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg)\n }\n \n static int\n-send_vhost_message(int sockfd, struct VhostUserMsg *msg, int *fds, int fd_num)\n+send_vhost_message(int sockfd, struct VhostUserMsg *msg)\n {\n \tif (!msg)\n \t\treturn 0;\n \n \treturn send_fd_message(sockfd, (char *)msg,\n-\t\tVHOST_USER_HDR_SIZE + msg->size, fds, fd_num);\n+\t\tVHOST_USER_HDR_SIZE + msg->size, msg->fds, msg->fd_num);\n }\n \n static int\n@@ -1581,19 +1586,18 @@ send_vhost_reply(int sockfd, struct VhostUserMsg *msg)\n \tmsg->flags |= VHOST_USER_VERSION;\n \tmsg->flags |= VHOST_USER_REPLY_MASK;\n \n-\treturn send_vhost_message(sockfd, msg, NULL, 0);\n+\treturn send_vhost_message(sockfd, msg);\n }\n \n static int\n-send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg,\n-\t\t\t int *fds, int fd_num)\n+send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg)\n {\n \tint ret;\n \n \tif (msg->flags & VHOST_USER_NEED_REPLY)\n \t\trte_spinlock_lock(&dev->slave_req_lock);\n \n-\tret = send_vhost_message(dev->slave_req_fd, msg, fds, fd_num);\n+\tret = send_vhost_message(dev->slave_req_fd, msg);\n \tif (ret < 0 && (msg->flags & VHOST_USER_NEED_REPLY))\n \t\trte_spinlock_unlock(&dev->slave_req_lock);\n \n@@ -1826,6 +1830,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tif (msg.flags & VHOST_USER_NEED_REPLY) {\n \t\tmsg.payload.u64 = ret == VH_RESULT_ERR;\n \t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tmsg.fd_num = 0;\n \t\tsend_vhost_reply(fd, &msg);\n \t} else if (ret == VH_RESULT_ERR) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n@@ -1909,7 +1914,7 @@ vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)\n \t\t},\n \t};\n \n-\tret = send_vhost_message(dev->slave_req_fd, &msg, NULL, 0);\n+\tret = send_vhost_message(dev->slave_req_fd, &msg);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\t\"Failed to send IOTLB miss message (%d)\\n\",\n@@ -1925,8 +1930,6 @@ static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,\n \t\t\t\t\t\t uint64_t offset,\n \t\t\t\t\t\t uint64_t size)\n {\n-\tint *fdp = NULL;\n-\tsize_t fd_num = 0;\n \tint ret;\n \tstruct VhostUserMsg msg = {\n \t\t.request.slave = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG,\n@@ -1942,11 +1945,11 @@ static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,\n \tif (fd < 0)\n \t\tmsg.payload.area.u64 |= VHOST_USER_VRING_NOFD_MASK;\n \telse {\n-\t\tfdp = &fd;\n-\t\tfd_num = 1;\n+\t\tmsg.fds[0] = fd;\n+\t\tmsg.fd_num = 1;\n \t}\n \n-\tret = send_vhost_slave_message(dev, &msg, fdp, fd_num);\n+\tret = send_vhost_slave_message(dev, &msg);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"Failed to set host notifier (%d)\\n\", ret);\n", "prefixes": [ "v2", "07/17" ] }