Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45738/?format=api
{ "id": 45738, "url": "http://patches.dpdk.org/api/patches/45738/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/7d89bc19d944b5a97e6d41b07387541d124b62ec.1538384304.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7d89bc19d944b5a97e6d41b07387541d124b62ec.1538384304.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7d89bc19d944b5a97e6d41b07387541d124b62ec.1538384304.git.anatoly.burakov@intel.com", "date": "2018-10-01T11:04:53", "name": "[v7,04/21] mem: do not check for invalid socket ID", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4c8d115f3d1ca61b5e450b24d771cb2ae545a08d", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/7d89bc19d944b5a97e6d41b07387541d124b62ec.1538384304.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1613, "url": "http://patches.dpdk.org/api/series/1613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1613", "date": "2018-10-01T11:04:49", "name": "Support externally allocated memory in DPDK", "version": 7, "mbox": "http://patches.dpdk.org/series/1613/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45738/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/45738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 42CD75F2C;\n\tMon, 1 Oct 2018 13:05:23 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 06F295942\n\tfor <dev@dpdk.org>; Mon, 1 Oct 2018 13:05:16 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Oct 2018 04:05:16 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 01 Oct 2018 04:05:12 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw91B5BnA028009; Mon, 1 Oct 2018 12:05:11 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w91B5BZ8017800;\n\tMon, 1 Oct 2018 12:05:11 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w91B5B8r017796;\n\tMon, 1 Oct 2018 12:05:11 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,327,1534834800\"; d=\"scan'208\";a=\"77756349\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tlaszlo.madarassy@ericsson.com, laszlo.vadkerti@ericsson.com,\n\tandras.kovacs@ericsson.com, winnie.tian@ericsson.com,\n\tdaniel.andrasi@ericsson.com, janos.kobor@ericsson.com,\n\tgeza.koblo@ericsson.com, srinath.mannam@broadcom.com,\n\tscott.branden@broadcom.com, ajit.khaparde@broadcom.com,\n\tkeith.wiles@intel.com, bruce.richardson@intel.com, thomas@monjalon.net,\n\tshreyansh.jain@nxp.com, shahafs@mellanox.com,\n\tarybchenko@solarflare.com, alejandro.lucero@netronome.com", "Date": "Mon, 1 Oct 2018 12:04:53 +0100", "Message-Id": "<7d89bc19d944b5a97e6d41b07387541d124b62ec.1538384304.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1538384304.git.anatoly.burakov@intel.com>", "<cover.1538384304.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1538384304.git.anatoly.burakov@intel.com>", "<cover.1538044725.git.anatoly.burakov@intel.com>\n\t<cover.1538384304.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v7 04/21] mem: do not check for invalid socket ID", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We will be assigning \"invalid\" socket ID's to external heap, and\nmalloc will now be able to verify if a supplied socket ID is in\nfact a valid one, rendering parameter checks for sockets\nobsolete.\n\nThis changes the semantics of what we understand by \"socket ID\",\nso document the change in the release notes.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n doc/guides/rel_notes/release_18_11.rst | 7 +++++++\n lib/librte_eal/common/eal_common_memzone.c | 8 +++++---\n lib/librte_eal/common/malloc_heap.c | 2 +-\n lib/librte_eal/common/rte_malloc.c | 4 ----\n 4 files changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex 5fc71e208..6ee236302 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -98,6 +98,13 @@ API Changes\n users of memseg-walk-related functions, as they will now have to skip\n externally allocated segments in most cases if the intent is to only iterate\n over internal DPDK memory.\n+ - ``socket_id`` parameter across the entire DPDK has gained additional\n+ meaning, as some socket ID's will now be representing externally allocated\n+ memory. No changes will be required for existing code as backwards\n+ compatibility will be kept, and those who do not use this feature will not\n+ see these extra socket ID's. Any new API's must not check socket ID\n+ parameters themselves, and must instead leave it to the memory subsystem to\n+ decide whether socket ID is a valid one.\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c\nindex 7300fe05d..b7081afbf 100644\n--- a/lib/librte_eal/common/eal_common_memzone.c\n+++ b/lib/librte_eal/common/eal_common_memzone.c\n@@ -120,13 +120,15 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,\n \t\treturn NULL;\n \t}\n \n-\tif ((socket_id != SOCKET_ID_ANY) &&\n-\t (socket_id >= RTE_MAX_NUMA_NODES || socket_id < 0)) {\n+\tif ((socket_id != SOCKET_ID_ANY) && socket_id < 0) {\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \n-\tif (!rte_eal_has_hugepages())\n+\t/* only set socket to SOCKET_ID_ANY if we aren't allocating for an\n+\t * external heap.\n+\t */\n+\tif (!rte_eal_has_hugepages() && socket_id < RTE_MAX_NUMA_NODES)\n \t\tsocket_id = SOCKET_ID_ANY;\n \n \tcontig = (flags & RTE_MEMZONE_IOVA_CONTIG) != 0;\ndiff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c\nindex a9cfa423f..09b06061d 100644\n--- a/lib/librte_eal/common/malloc_heap.c\n+++ b/lib/librte_eal/common/malloc_heap.c\n@@ -651,7 +651,7 @@ malloc_heap_alloc(const char *type, size_t size, int socket_arg,\n \tif (size == 0 || (align && !rte_is_power_of_2(align)))\n \t\treturn NULL;\n \n-\tif (!rte_eal_has_hugepages())\n+\tif (!rte_eal_has_hugepages() && socket_arg < RTE_MAX_NUMA_NODES)\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n \tif (socket_arg == SOCKET_ID_ANY)\ndiff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex 73d6df31d..9ba1472c3 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -47,10 +47,6 @@ rte_malloc_socket(const char *type, size_t size, unsigned int align,\n \tif (!rte_eal_has_hugepages())\n \t\tsocket_arg = SOCKET_ID_ANY;\n \n-\t/* Check socket parameter */\n-\tif (socket_arg >= RTE_MAX_NUMA_NODES)\n-\t\treturn NULL;\n-\n \treturn malloc_heap_alloc(type, size, socket_arg, 0,\n \t\t\talign == 0 ? 1 : align, 0, false);\n }\n", "prefixes": [ "v7", "04/21" ] }