Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45660/?format=api
{ "id": 45660, "url": "http://patches.dpdk.org/api/patches/45660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538208822-9726-18-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538208822-9726-18-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538208822-9726-18-git-send-email-rasesh.mody@cavium.com", "date": "2018-09-29T08:14:39", "name": "[17/18] net/qede/base: semantic changes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1aea4894825f46a2bd73a06e1be617a1ad00c056", "submitter": { "id": 569, "url": "http://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538208822-9726-18-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [ { "id": 1596, "url": "http://patches.dpdk.org/api/series/1596/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1596", "date": "2018-09-29T08:13:57", "name": "net/qede: base driver update", "version": 1, "mbox": "http://patches.dpdk.org/series/1596/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45660/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/45660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 48A1E1B1D6;\n\tSat, 29 Sep 2018 10:15:10 +0200 (CEST)", "from NAM02-CY1-obe.outbound.protection.outlook.com\n\t(mail-cys01nam02on0088.outbound.protection.outlook.com\n\t[104.47.37.88]) by dpdk.org (Postfix) with ESMTP id E08431B0F9\n\tfor <dev@dpdk.org>; Sat, 29 Sep 2018 10:14:40 +0200 (CEST)", "from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by\n\tBYAPR07MB4806.namprd07.prod.outlook.com (20.176.248.157) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1164.20; Sat, 29 Sep 2018 08:14:39 +0000", "from BYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0]) by\n\tBYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.022;\n\tSat, 29 Sep 2018 08:14:39 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=oeY3iskg5kggmDrR5UR5PVjbtXHucEDOSpXuA4EnZnk=;\n\tb=YNDTY26zPBVojmgJ2l1+2rObAjrlPn/ock5FbE6o8DcL7PpUiREhZEgy5nHqSF0DBofhZ1sRrWejOzHQP60KbM10v6JELo8sHWD/UcD3qxRUQDglsKrDRuZtkARVAAKh9hpib8+uw+7i50sFrsChKajDdZ4gQKVto5GMgksr/gQ=", "From": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>, Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>", "Thread-Topic": "[PATCH 17/18] net/qede/base: semantic changes", "Thread-Index": "AQHUV8x34DV8UPi5pEqIYc5NDZzWdQ==", "Date": "Sat, 29 Sep 2018 08:14:39 +0000", "Message-ID": "<1538208822-9726-18-git-send-email-rasesh.mody@cavium.com>", "References": "<1538208822-9726-1-git-send-email-rasesh.mody@cavium.com>", "In-Reply-To": "<1538208822-9726-1-git-send-email-rasesh.mody@cavium.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR11CA0059.namprd11.prod.outlook.com\n\t(2603:10b6:a03:80::36) To BYAPR07MB5365.namprd07.prod.outlook.com\n\t(2603:10b6:a03:64::18)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[198.186.1.5]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; BYAPR07MB4806;\n\t6:DrWuarhtmuMbBLIVdn1GQHZMt+/kREQdlt8XQcXcbcYPiX6mfgSuZevEWQtb6mNyIlU3FUdYkDlT7PEpmE3i1+tocVCY0pm6Srm/kob/R8UI/wgA2w+MJxlxhFRXTsW54jVyQR7xSJ26Dk+Kgr+nU25OGeXsZgHTzy4mnvaxpuoTfPXEexUPlMMvpN8IT+cxKaepkYPU1dc0eTXxUfpAc/hpOOAL1LE9o+xYaTSDbw78ymV15MXB7y0XiHCALRPWmrKlycqwQyUETSYI57k+sfg+eknjERIV1RQIS015CGvWFU6igjUPwEojxpeQsysz7pA4jeqI/ydmkoxNZam/BmRKVDRPXv316DwEsqHMnmLqAPcjfq0mhLETSyTtv0ZMyI0W38ifmF7fF29vmDhxCnQvFi1R/hCxFQGADcOsDoYTGBCWCGc1MSM6PjCid3ozkOK6Y1/6qswCmc4KNQl0dw==;\n\t5:JM2ILoB1PQcDbQVFA1+O6iERZhYV1QtnX7RYt+et48/U8IlKiqWWaKxmPsPoIQ65nZcE1xFF2Je0IgA+v7/30E4dCkTvfLXkiKouRJhStWDSR+VTldP9AKlDVkoQpxUwNfYeA6hmq73tsDMr13QhRWnoDp5iqNTTokucbJnz/Zc=;\n\t7:qUjzceMO0IVfHq3zGNlh+SY5odwKRfce9likAUojv6GKpG5h9uD5SgoJ1uDZ7MgRoIk4KO7bbJfna7AAxETz8c8RmaC+YN/Y/HoF+yqpRIcS+BBQxDY5ido0BSZDPOZiz6W3nMplGR6nJWULSHUjeJvvM33fVQl2uvr5wYktjE9dew/GLbeJ4/XGcYPPjZO5Rrcx5v90EGH4lrL3ZudWgZYU3DMHufw/+/3nq7JEzoqWrMpBdUIFrqNNfKRSCD4a", "x-ms-office365-filtering-correlation-id": "09573b2e-a813-4a76-336d-08d625e3997a", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:BYAPR07MB4806; ", "x-ms-traffictypediagnostic": "BYAPR07MB4806:", "x-microsoft-antispam-prvs": "<BYAPR07MB48060E8E94C64A6D1E25D1679FED0@BYAPR07MB4806.namprd07.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(10201501046)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051);\n\tSRVR:BYAPR07MB4806; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4806; ", "x-forefront-prvs": "0810818DA0", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(376002)(396003)(366004)(136003)(39860400002)(199004)(189003)(26005)(4326008)(102836004)(14444005)(256004)(2616005)(66066001)(446003)(476003)(71190400001)(71200400001)(6116002)(11346002)(3846002)(316002)(5660300001)(36756003)(486006)(2906002)(107886003)(25786009)(8936002)(68736007)(6512007)(8676002)(106356001)(14454004)(5640700003)(81156014)(81166006)(105586002)(1730700003)(6436002)(6486002)(52116002)(76176011)(53936002)(72206003)(2351001)(7736002)(305945005)(478600001)(54906003)(6916009)(2501003)(186003)(86362001)(6506007)(386003)(5250100002)(2900100001)(34290500001)(99286004)(97736004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4806;\n\tH:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "gmUYmuoEqcTyFpqNmgAbBq0QrRTAiLCd/roT1RuzEQP5/vo4l6ebhkXQvWtL2vQKutoP5mWb2fUajYHW1PKnr6Y6niarkWTkyG+z/TVZPu5PPXkkBCnHDz5/lvELdxTvOanAsrB9Ms+w+xP/0jQrIOOX3zBrDMvD5pfRKUdl+ByPSfdVGdUkT1Z3m1t1uEIKnxsiYqFc8tFKvrDdZd10R9ZBJf5h5z4Tc0pDuVtm9PdrAasi/mKiTZ4/c/gAoKXm3eu07hfleYQHqssD27ePVqZmevJHWSou0SQlX3phHe8qT4PqYWgiUYdvmKuL2/sBs3X1z7ZdeJObTrbj4pohvD4m+BKMhqSRVu+sQJRxOFg=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "09573b2e-a813-4a76-336d-08d625e3997a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "29 Sep 2018 08:14:39.5490\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR07MB4806", "Subject": "[dpdk-dev] [PATCH 17/18] net/qede/base: semantic changes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch consists of semantic/formatting changes.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_dcbx.c | 3 ++-\n drivers/net/qede/base/ecore_init_ops.c | 12 ++++-----\n drivers/net/qede/base/ecore_int.c | 3 ++-\n drivers/net/qede/base/ecore_int_api.h | 3 ++-\n drivers/net/qede/base/ecore_l2.c | 16 ++++++------\n drivers/net/qede/base/ecore_mcp.c | 11 ++++----\n drivers/net/qede/base/ecore_spq.c | 44 ++++++++++++++++++--------------\n drivers/net/qede/base/ecore_sriov.c | 12 +++++----\n 8 files changed, 58 insertions(+), 46 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c\nindex 7981c42..cbc69cd 100644\n--- a/drivers/net/qede/base/ecore_dcbx.c\n+++ b/drivers/net/qede/base/ecore_dcbx.c\n@@ -325,7 +325,7 @@ u8 ecore_dcbx_get_dscp_value(struct ecore_hwfn *p_hwfn, u8 pri)\n {\n \tstruct dcbx_app_priority_feature *p_app;\n \tstruct dcbx_app_priority_entry *p_tbl;\n-\tstruct ecore_dcbx_results data = { 0 };\n+\tstruct ecore_dcbx_results data;\n \tstruct dcbx_ets_feature *p_ets;\n \tstruct ecore_hw_info *p_info;\n \tu32 pri_tc_tbl, flags;\n@@ -345,6 +345,7 @@ u8 ecore_dcbx_get_dscp_value(struct ecore_hwfn *p_hwfn, u8 pri)\n \tp_info = &p_hwfn->hw_info;\n \tnum_entries = GET_MFW_FIELD(p_app->flags, DCBX_APP_NUM_ENTRIES);\n \n+\tOSAL_MEMSET(&data, 0, sizeof(struct ecore_dcbx_results));\n \trc = ecore_dcbx_process_tlv(p_hwfn, p_ptt, &data, p_tbl, pri_tc_tbl,\n \t\t\t\t num_entries, dcbx_version);\n \tif (rc != ECORE_SUCCESS)\ndiff --git a/drivers/net/qede/base/ecore_init_ops.c b/drivers/net/qede/base/ecore_init_ops.c\nindex 47c1be2..044308b 100644\n--- a/drivers/net/qede/base/ecore_init_ops.c\n+++ b/drivers/net/qede/base/ecore_init_ops.c\n@@ -420,11 +420,11 @@ static u8 ecore_init_cmd_mode_match(struct ecore_hwfn *p_hwfn,\n \t\t\t\t u16 *p_offset, int modes)\n {\n \tstruct ecore_dev *p_dev = p_hwfn->p_dev;\n-\tconst u8 *modes_tree_buf;\n \tu8 arg1, arg2, tree_val;\n+\tconst u8 *modes_tree;\n \n-\tmodes_tree_buf = p_dev->fw_data->modes_tree_buf;\n-\ttree_val = modes_tree_buf[(*p_offset)++];\n+\tmodes_tree = p_dev->fw_data->modes_tree_buf;\n+\ttree_val = modes_tree[(*p_offset)++];\n \tswitch (tree_val) {\n \tcase INIT_MODE_OP_NOT:\n \t\treturn ecore_init_cmd_mode_match(p_hwfn, p_offset, modes) ^ 1;\n@@ -474,12 +474,12 @@ enum _ecore_status_t ecore_init_run(struct ecore_hwfn *p_hwfn,\n {\n \tstruct ecore_dev *p_dev = p_hwfn->p_dev;\n \tu32 cmd_num, num_init_ops;\n-\tunion init_op *init_ops;\n+\tunion init_op *init;\n \tbool b_dmae = false;\n \tenum _ecore_status_t rc = ECORE_SUCCESS;\n \n \tnum_init_ops = p_dev->fw_data->init_ops_size;\n-\tinit_ops = p_dev->fw_data->init_ops;\n+\tinit = p_dev->fw_data->init_ops;\n \n #ifdef CONFIG_ECORE_ZIPPED_FW\n \tp_hwfn->unzip_buf = OSAL_ZALLOC(p_hwfn->p_dev, GFP_ATOMIC,\n@@ -491,7 +491,7 @@ enum _ecore_status_t ecore_init_run(struct ecore_hwfn *p_hwfn,\n #endif\n \n \tfor (cmd_num = 0; cmd_num < num_init_ops; cmd_num++) {\n-\t\tunion init_op *cmd = &init_ops[cmd_num];\n+\t\tunion init_op *cmd = &init[cmd_num];\n \t\tu32 data = OSAL_LE32_TO_CPU(cmd->raw.op_data);\n \n \t\tswitch (GET_FIELD(data, INIT_CALLBACK_OP_OP)) {\ndiff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c\nindex e48a7bc..7368d55 100644\n--- a/drivers/net/qede/base/ecore_int.c\n+++ b/drivers/net/qede/base/ecore_int.c\n@@ -1224,8 +1224,9 @@ static enum _ecore_status_t ecore_int_attentions(struct ecore_hwfn *p_hwfn)\n static void ecore_sb_ack_attn(struct ecore_hwfn *p_hwfn,\n \t\t\t void OSAL_IOMEM *igu_addr, u32 ack_cons)\n {\n-\tstruct igu_prod_cons_update igu_ack = { 0 };\n+\tstruct igu_prod_cons_update igu_ack;\n \n+\tOSAL_MEMSET(&igu_ack, 0, sizeof(struct igu_prod_cons_update));\n \tigu_ack.sb_id_and_flags =\n \t ((ack_cons << IGU_PROD_CONS_UPDATE_SB_INDEX_SHIFT) |\n \t (1 << IGU_PROD_CONS_UPDATE_UPDATE_FLAG_SHIFT) |\ndiff --git a/drivers/net/qede/base/ecore_int_api.h b/drivers/net/qede/base/ecore_int_api.h\nindex 5b9c31d..42538a4 100644\n--- a/drivers/net/qede/base/ecore_int_api.h\n+++ b/drivers/net/qede/base/ecore_int_api.h\n@@ -92,8 +92,9 @@ static OSAL_INLINE u16 ecore_sb_update_sb_idx(struct ecore_sb_info *sb_info)\n static OSAL_INLINE void ecore_sb_ack(struct ecore_sb_info *sb_info,\n \t\t\t\t enum igu_int_cmd int_cmd, u8 upd_flg)\n {\n-\tstruct igu_prod_cons_update igu_ack = { 0 };\n+\tstruct igu_prod_cons_update igu_ack;\n \n+\tOSAL_MEMSET(&igu_ack, 0, sizeof(struct igu_prod_cons_update));\n \tigu_ack.sb_id_and_flags =\n \t ((sb_info->sb_ack << IGU_PROD_CONS_UPDATE_SB_INDEX_SHIFT) |\n \t (upd_flg << IGU_PROD_CONS_UPDATE_UPDATE_FLAG_SHIFT) |\ndiff --git a/drivers/net/qede/base/ecore_l2.c b/drivers/net/qede/base/ecore_l2.c\nindex 5a0905e..8b9817e 100644\n--- a/drivers/net/qede/base/ecore_l2.c\n+++ b/drivers/net/qede/base/ecore_l2.c\n@@ -2205,10 +2205,10 @@ enum _ecore_status_t\n \treturn ecore_spq_post(p_hwfn, p_ent, OSAL_NULL);\n }\n \n-int ecore_get_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n-\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t struct ecore_queue_cid *p_cid,\n-\t\t\t u16 *p_rx_coal)\n+enum _ecore_status_t ecore_get_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n+\t\t\t\t\t struct ecore_ptt *p_ptt,\n+\t\t\t\t\t struct ecore_queue_cid *p_cid,\n+\t\t\t\t\t u16 *p_rx_coal)\n {\n \tu32 coalesce, address, is_valid;\n \tstruct cau_sb_entry sb_entry;\n@@ -2240,10 +2240,10 @@ int ecore_get_rxq_coalesce(struct ecore_hwfn *p_hwfn,\n \treturn ECORE_SUCCESS;\n }\n \n-int ecore_get_txq_coalesce(struct ecore_hwfn *p_hwfn,\n-\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t struct ecore_queue_cid *p_cid,\n-\t\t\t u16 *p_tx_coal)\n+enum _ecore_status_t ecore_get_txq_coalesce(struct ecore_hwfn *p_hwfn,\n+\t\t\t\t\t struct ecore_ptt *p_ptt,\n+\t\t\t\t\t struct ecore_queue_cid *p_cid,\n+\t\t\t\t\t u16 *p_tx_coal)\n {\n \tu32 coalesce, address, is_valid;\n \tstruct cau_sb_entry sb_entry;\ndiff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c\nindex 202db13..6c65606 100644\n--- a/drivers/net/qede/base/ecore_mcp.c\n+++ b/drivers/net/qede/base/ecore_mcp.c\n@@ -3084,7 +3084,7 @@ enum _ecore_status_t ecore_mcp_phy_read(struct ecore_dev *p_dev, u32 cmd,\n {\n \tstruct ecore_hwfn *p_hwfn = ECORE_LEADING_HWFN(p_dev);\n \tstruct ecore_ptt *p_ptt;\n-\tu32 resp, param;\n+\tu32 resp = 0, param;\n \tenum _ecore_status_t rc;\n \n \tp_ptt = ecore_ptt_acquire(p_hwfn);\n@@ -3124,7 +3124,7 @@ enum _ecore_status_t ecore_mcp_nvm_del_file(struct ecore_dev *p_dev, u32 addr)\n {\n \tstruct ecore_hwfn *p_hwfn = ECORE_LEADING_HWFN(p_dev);\n \tstruct ecore_ptt *p_ptt;\n-\tu32 resp, param;\n+\tu32 resp = 0, param;\n \tenum _ecore_status_t rc;\n \n \tp_ptt = ecore_ptt_acquire(p_hwfn);\n@@ -3143,7 +3143,7 @@ enum _ecore_status_t ecore_mcp_nvm_put_file_begin(struct ecore_dev *p_dev,\n {\n \tstruct ecore_hwfn *p_hwfn = ECORE_LEADING_HWFN(p_dev);\n \tstruct ecore_ptt *p_ptt;\n-\tu32 resp, param;\n+\tu32 resp = 0, param;\n \tenum _ecore_status_t rc;\n \n \tp_ptt = ecore_ptt_acquire(p_hwfn);\n@@ -3237,8 +3237,8 @@ enum _ecore_status_t ecore_mcp_phy_write(struct ecore_dev *p_dev, u32 cmd,\n \t\t\t\t\t u32 addr, u8 *p_buf, u32 len)\n {\n \tstruct ecore_hwfn *p_hwfn = ECORE_LEADING_HWFN(p_dev);\n+\tu32 resp = 0, param, nvm_cmd;\n \tstruct ecore_ptt *p_ptt;\n-\tu32 resp, param, nvm_cmd;\n \tenum _ecore_status_t rc;\n \n \tp_ptt = ecore_ptt_acquire(p_hwfn);\n@@ -4216,10 +4216,11 @@ enum _ecore_status_t ecore_mcp_get_ppfid_bitmap(struct ecore_hwfn *p_hwfn,\n void ecore_mcp_wol_wr(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt,\n \t\t u32 offset, u32 val)\n {\n-\tstruct ecore_mcp_mb_params mb_params = {0};\n \tenum _ecore_status_t\t rc = ECORE_SUCCESS;\n \tu32\t\t\t dword = val;\n+\tstruct ecore_mcp_mb_params mb_params;\n \n+\tOSAL_MEMSET(&mb_params, 0, sizeof(struct ecore_mcp_mb_params));\n \tmb_params.cmd = DRV_MSG_CODE_WRITE_WOL_REG;\n \tmb_params.param = offset;\n \tmb_params.p_data_src = &dword;\ndiff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c\nindex 1a02ba2..88ad961 100644\n--- a/drivers/net/qede/base/ecore_spq.c\n+++ b/drivers/net/qede/base/ecore_spq.c\n@@ -282,6 +282,7 @@ static enum _ecore_status_t ecore_spq_hw_post(struct ecore_hwfn *p_hwfn,\n \t\t\t struct event_ring_entry *p_eqe)\n {\n \tecore_spq_async_comp_cb cb;\n+\tenum _ecore_status_t rc;\n \n \tif (p_eqe->protocol_id >= MAX_PROTOCOL_TYPE) {\n \t\tDP_ERR(p_hwfn, \"Wrong protocol: %d\\n\", p_eqe->protocol_id);\n@@ -289,15 +290,22 @@ static enum _ecore_status_t ecore_spq_hw_post(struct ecore_hwfn *p_hwfn,\n \t}\n \n \tcb = p_hwfn->p_spq->async_comp_cb[p_eqe->protocol_id];\n-\tif (cb) {\n-\t\treturn cb(p_hwfn, p_eqe->opcode, p_eqe->echo,\n-\t\t\t &p_eqe->data, p_eqe->fw_return_code);\n-\t} else {\n+\tif (!cb) {\n \t\tDP_NOTICE(p_hwfn,\n \t\t\t true, \"Unknown Async completion for protocol: %d\\n\",\n \t\t\t p_eqe->protocol_id);\n \t\treturn ECORE_INVAL;\n \t}\n+\n+\trc = cb(p_hwfn, p_eqe->opcode, p_eqe->echo,\n+\t\t&p_eqe->data, p_eqe->fw_return_code);\n+\tif (rc != ECORE_SUCCESS)\n+\t\tDP_NOTICE(p_hwfn, true,\n+\t\t\t \"Async completion callback failed, rc = %d [opcode %x, echo %x, fw_return_code %x]\",\n+\t\t\t rc, p_eqe->opcode, p_eqe->echo,\n+\t\t\t p_eqe->fw_return_code);\n+\n+\treturn rc;\n }\n \n enum _ecore_status_t\n@@ -342,7 +350,7 @@ enum _ecore_status_t ecore_eq_completion(struct ecore_hwfn *p_hwfn,\n \tstruct ecore_eq *p_eq = cookie;\n \tstruct ecore_chain *p_chain = &p_eq->chain;\n \tu16 fw_cons_idx = 0;\n-\tenum _ecore_status_t rc = 0;\n+\tenum _ecore_status_t rc = ECORE_SUCCESS;\n \n \tif (!p_hwfn->p_spq) {\n \t\tDP_ERR(p_hwfn, \"Unexpected NULL p_spq\\n\");\n@@ -366,7 +374,8 @@ enum _ecore_status_t ecore_eq_completion(struct ecore_hwfn *p_hwfn,\n \twhile (fw_cons_idx != ecore_chain_get_cons_idx(p_chain)) {\n \t\tstruct event_ring_entry *p_eqe = ecore_chain_consume(p_chain);\n \t\tif (!p_eqe) {\n-\t\t\trc = ECORE_INVAL;\n+\t\t\tDP_ERR(p_hwfn,\n+\t\t\t \"Unexpected NULL chain consumer entry\\n\");\n \t\t\tbreak;\n \t\t}\n \n@@ -382,15 +391,13 @@ enum _ecore_status_t ecore_eq_completion(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t\t */\n \t\t\t p_eqe->flags);\n \n-\t\tif (GET_FIELD(p_eqe->flags, EVENT_RING_ENTRY_ASYNC)) {\n-\t\t\tif (ecore_async_event_completion(p_hwfn, p_eqe))\n-\t\t\t\trc = ECORE_INVAL;\n-\t\t} else if (ecore_spq_completion(p_hwfn,\n-\t\t\t\t\t\tp_eqe->echo,\n-\t\t\t\t\t\tp_eqe->fw_return_code,\n-\t\t\t\t\t\t&p_eqe->data)) {\n-\t\t\trc = ECORE_INVAL;\n-\t\t}\n+\t\tif (GET_FIELD(p_eqe->flags, EVENT_RING_ENTRY_ASYNC))\n+\t\t\tecore_async_event_completion(p_hwfn, p_eqe);\n+\t\telse\n+\t\t\tecore_spq_completion(p_hwfn,\n+\t\t\t\t\t p_eqe->echo,\n+\t\t\t\t\t p_eqe->fw_return_code,\n+\t\t\t\t\t &p_eqe->data);\n \n \t\tecore_chain_recycle_consumed(p_chain);\n \t}\n@@ -936,12 +943,11 @@ enum _ecore_status_t ecore_spq_completion(struct ecore_hwfn *p_hwfn,\n \tstruct ecore_spq_entry *found = OSAL_NULL;\n \tenum _ecore_status_t rc;\n \n-\tif (!p_hwfn)\n-\t\treturn ECORE_INVAL;\n-\n \tp_spq = p_hwfn->p_spq;\n-\tif (!p_spq)\n+\tif (!p_spq) {\n+\t\tDP_ERR(p_hwfn, \"Unexpected NULL p_spq\\n\");\n \t\treturn ECORE_INVAL;\n+\t}\n \n \tOSAL_SPIN_LOCK(&p_spq->lock);\n \tOSAL_LIST_FOR_EACH_ENTRY_SAFE(p_ent,\ndiff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c\nindex 9e937e2..db929f0 100644\n--- a/drivers/net/qede/base/ecore_sriov.c\n+++ b/drivers/net/qede/base/ecore_sriov.c\n@@ -218,7 +218,7 @@ struct ecore_vf_info *ecore_iov_get_vf_info(struct ecore_hwfn *p_hwfn,\n static struct ecore_queue_cid *\n ecore_iov_get_vf_rx_queue_cid(struct ecore_vf_queue *p_queue)\n {\n-\tint i;\n+\tu32 i;\n \n \tfor (i = 0; i < MAX_QUEUES_PER_QZONE; i++) {\n \t\tif (p_queue->cids[i].p_cid &&\n@@ -240,7 +240,7 @@ static bool ecore_iov_validate_queue_mode(struct ecore_vf_info *p_vf,\n \t\t\t\t\t enum ecore_iov_validate_q_mode mode,\n \t\t\t\t\t bool b_is_tx)\n {\n-\tint i;\n+\tu32 i;\n \n \tif (mode == ECORE_IOV_VALIDATE_Q_NA)\n \t\treturn true;\n@@ -2089,8 +2089,8 @@ static void ecore_iov_vf_mbx_start_vport(struct ecore_hwfn *p_hwfn,\n \t\t\t\t\t struct ecore_ptt *p_ptt,\n \t\t\t\t\t struct ecore_vf_info *vf)\n {\n-\tstruct ecore_sp_vport_start_params params = { 0 };\n \tstruct ecore_iov_vf_mbx *mbx = &vf->vf_mbx;\n+\tstruct ecore_sp_vport_start_params params;\n \tstruct vfpf_vport_start_tlv *start;\n \tu8 status = PFVF_STATUS_SUCCESS;\n \tstruct ecore_vf_info *vf_info;\n@@ -2141,6 +2141,7 @@ static void ecore_iov_vf_mbx_start_vport(struct ecore_hwfn *p_hwfn,\n \t\t*p_bitmap |= 1 << VFPF_BULLETIN_UNTAGGED_DEFAULT;\n \t}\n \n+\tOSAL_MEMSET(¶ms, 0, sizeof(struct ecore_sp_vport_start_params));\n \tparams.tpa_mode = start->tpa_mode;\n \tparams.remove_inner_vlan = start->inner_vlan_removal;\n \tparams.tx_switching = true;\n@@ -3668,7 +3669,7 @@ static void ecore_iov_vf_pf_set_coalesce(struct ecore_hwfn *p_hwfn,\n \tstruct ecore_queue_cid *p_cid;\n \tu16 rx_coal, tx_coal;\n \tu16 qid;\n-\tint i;\n+\tu32 i;\n \n \treq = &mbx->req_virt->update_coalesce;\n \n@@ -3748,7 +3749,8 @@ enum _ecore_status_t\n \tstruct ecore_queue_cid *p_cid;\n \tstruct ecore_vf_info *vf;\n \tstruct ecore_ptt *p_ptt;\n-\tint i, rc = 0;\n+\tint rc = 0;\n+\tu32 i;\n \n \tif (!ecore_iov_is_valid_vfid(p_hwfn, vf_id, true, true)) {\n \t\tDP_NOTICE(p_hwfn, true,\n", "prefixes": [ "17/18" ] }