Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45535,
    "url": "http://patches.dpdk.org/api/patches/45535/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538059845-35896-5-git-send-email-dekelp@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1538059845-35896-5-git-send-email-dekelp@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1538059845-35896-5-git-send-email-dekelp@mellanox.com",
    "date": "2018-09-27T14:50:45",
    "name": "[4/4] net/mlx5: add DV decap L2 and L3 operations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2ac245dfc009e05cf2592475ae4849399fae5896",
    "submitter": {
        "id": 1082,
        "url": "http://patches.dpdk.org/api/people/1082/?format=api",
        "name": "Dekel Peled",
        "email": "dekelp@mellanox.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patches.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538059845-35896-5-git-send-email-dekelp@mellanox.com/mbox/",
    "series": [
        {
            "id": 1555,
            "url": "http://patches.dpdk.org/api/series/1555/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1555",
            "date": "2018-09-27T14:50:41",
            "name": "support DV encap and decap actions",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1555/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/45535/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/45535/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 22E3B1B4E3;\n\tThu, 27 Sep 2018 16:52:20 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 84D061B4D9\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 16:52:15 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 27 Sep 2018 16:56:45 +0200",
            "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w8REq7gM013802;\n\tThu, 27 Sep 2018 17:52:11 +0300"
        ],
        "From": "Dekel Peled <dekelp@mellanox.com>",
        "To": "dev@dpdk.org, shahafs@mellanox.com, yskoh@mellanox.com",
        "Cc": "orika@mellanox.com",
        "Date": "Thu, 27 Sep 2018 17:50:45 +0300",
        "Message-Id": "<1538059845-35896-5-git-send-email-dekelp@mellanox.com>",
        "X-Mailer": "git-send-email 1.7.1",
        "In-Reply-To": "<1538059845-35896-1-git-send-email-dekelp@mellanox.com>",
        "References": "<1538059845-35896-1-git-send-email-dekelp@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH 4/4] net/mlx5: add DV decap L2 and L3 operations",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds support for Direct Verbs decap operations, L2 and L3.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 258 ++++++++++++++++++++++++++++++++++++++--\n 1 file changed, 248 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 50925ac..ca44f13 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -126,12 +126,20 @@\n \t\t\t\t\t  NULL,\n \t\t\t\t\t  \"can't have 2 encap actions in same\"\n \t\t\t\t\t  \" flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_DECAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_DECAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't encap and decap in same\"\n+\t\t\t\t\t  \" flow\");\n \tif (attr->ingress)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n-\t\t\t\t\tNULL,\n-\t\t\t\t\t\"encap action not supported for \"\n-\t\t\t\t\t\"ingress\");\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"encap action not supported for \"\n+\t\t\t\t\t  \"ingress\");\n \treturn 0;\n }\n \n@@ -178,12 +186,130 @@\n \t\t\t\t\t  NULL,\n \t\t\t\t\t  \"can't have 2 encap actions in same\"\n \t\t\t\t\t  \" flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_DECAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_DECAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't encap and decap in same\"\n+\t\t\t\t\t  \" flow\");\n \tif (attr->ingress)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n-\t\t\t\t\tNULL,\n-\t\t\t\t\t\"encap action not supported for \"\n-\t\t\t\t\t\"ingress\");\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"encap action not supported for \"\n+\t\t\t\t\t  \"ingress\");\n+\treturn 0;\n+}\n+\n+/**\n+ * Validate the tunnel decap action\n+ *\n+ * @param[in] action_flags\n+ *   holds the actions detected until now.\n+ * @param[in] attr\n+ *   Pointer to flow attributes\n+ * @param[out] error\n+ *   Pointer to error structure.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_ernno is set.\n+ */\n+static int\n+mlx5_flow_validate_action_tunnel_decap(uint64_t action_flags,\n+\t\t\t\t       const struct rte_flow_attr *attr,\n+\t\t\t\t       struct rte_flow_error *error)\n+{\n+\tif (action_flags & MLX5_ACTION_DROP)\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't drop and decap in same flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_DECAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_DECAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't have 2 decap actions in same\"\n+\t\t\t\t\t  \" flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_ENCAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_ENCAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't encap and decap in same\"\n+\t\t\t\t\t  \" flow\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"decap action not supported for \"\n+\t\t\t\t\t  \"egress\");\n+\treturn 0;\n+}\n+\n+/**\n+ * Validate the tunnel decap L3 action\n+ *\n+ * @param[in] action_flags\n+ *   holds the actions detected until now.\n+ * @param[in] action\n+ *   Pointer to the decap action.\n+ * @param[in] attr\n+ *   Pointer to flow attributes\n+ * @param[out] error\n+ *   Pointer to error structure.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_ernno is set.\n+ */\n+static int\n+mlx5_flow_validate_action_tunnel_decap_l3(uint64_t action_flags,\n+\t\t\t\t\t  const struct rte_flow_action *action,\n+\t\t\t\t\t  const struct rte_flow_attr *attr,\n+\t\t\t\t\t  struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_action_tunnel_decap_l3 *tunnel_decap_l3 =\n+\t\t\t\t\t\t\t\taction->conf;\n+\n+\tif (!tunnel_decap_l3 || !(tunnel_decap_l3->buf))\n+\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  action,\n+\t\t\t\t\t  \"configuration cannot be null\");\n+\tif (action_flags & MLX5_ACTION_DROP)\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't drop and decap in same flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_DECAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_DECAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't have 2 decap actions in same\"\n+\t\t\t\t\t  \" flow\");\n+\tif (action_flags & (MLX5_ACTION_TUNNEL_ENCAP |\n+\t\t\t    MLX5_ACTION_TUNNEL_ENCAP_L3))\n+\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t  ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"can't encap and decap in same\"\n+\t\t\t\t\t  \" flow\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t  NULL,\n+\t\t\t\t\t  \"decap action not supported for \"\n+\t\t\t\t\t  \"egress\");\n \treturn 0;\n }\n \n@@ -257,6 +383,72 @@\n }\n \n /**\n+ * Convert decap action to DV specification.\n+ *\n+ * @param[in] action\n+ *   Pointer to action structure.\n+ * @param[in] ctx\n+ *   Verbs context.\n+ * @param[out] error\n+ *   Pointer to the error structure.\n+ *\n+ * @return\n+ *   Pointer to action on success, NULL otherwise and rte_errno is set.\n+ */\n+static struct ibv_flow_action *\n+mlx5_flow_dv_create_decap(const struct rte_flow_action *action __rte_unused,\n+\t\t\t  struct ibv_context *ctx,\n+\t\t\t  struct rte_flow_error *error)\n+{\n+\tstruct ibv_flow_action *decap_verb = NULL;\n+\n+\tdecap_verb = mlx5_glue->dv_create_flow_action_packet_reformat(ctx,\n+\t\t\t0, NULL,\n+\t\t\tMLX5DV_FLOW_ACTION_PACKET_REFORMAT_TYPE_L2_TUNNEL_TO_L2,\n+\t\t\tMLX5DV_FLOW_TABLE_TYPE_NIC_RX);\n+\tif (!decap_verb)\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t   NULL, \"cannot create decap action\");\n+\treturn decap_verb;\n+}\n+\n+/**\n+ * Convert decap L3 action to DV specification.\n+ *\n+ * @param[in] action\n+ *   Pointer to action structure.\n+ * @param[in] ctx\n+ *   Verbs context.\n+ * @param[out] error\n+ *   Pointer to the error structure.\n+ *\n+ * @return\n+ *   Pointer to action on success, NULL otherwise and rte_errno is set.\n+ */\n+static struct ibv_flow_action *\n+mlx5_flow_dv_create_decap_l3(const struct rte_flow_action *action,\n+\t\t\t     struct ibv_context *ctx,\n+\t\t\t     struct rte_flow_error *error)\n+{\n+\tstruct ibv_flow_action *decap_l3_verb = NULL;\n+\tconst struct rte_flow_action_tunnel_decap_l3 *decap_l3_data;\n+\n+\tdecap_l3_data =\n+\t\t(const struct rte_flow_action_tunnel_decap_l3 *)action->conf;\n+\tdecap_l3_verb = mlx5_glue->dv_create_flow_action_packet_reformat(ctx,\n+\t\t\tdecap_l3_data->size,\n+\t\t\tdecap_l3_data->size ? decap_l3_data->buf :\n+\t\t\t\t\t      NULL,\n+\t\t\tMLX5DV_FLOW_ACTION_PACKET_REFORMAT_TYPE_L3_TUNNEL_TO_L2,\n+\t\t\tMLX5DV_FLOW_TABLE_TYPE_NIC_RX);\n+\tif (!decap_l3_verb)\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t   NULL, \"cannot create decap L3 action\");\n+\n+\treturn decap_l3_verb;\n+}\n+\n+/**\n  * Verify the @p attributes will be correctly understood by the NIC and store\n  * them in the @p flow if everything is correct.\n  *\n@@ -529,6 +721,25 @@\n \t\t\t\treturn ret;\n \t\t\taction_flags |= MLX5_ACTION_TUNNEL_ENCAP_L3;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP:\n+\t\t\tret = mlx5_flow_validate_action_tunnel_decap\n+\t\t\t\t(action_flags,\n+\t\t\t\t attr,\n+\t\t\t\t error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\taction_flags |= MLX5_ACTION_TUNNEL_DECAP;\n+\t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP_L3:\n+\t\t\tret = mlx5_flow_validate_action_tunnel_decap_l3\n+\t\t\t\t(action_flags,\n+\t\t\t\t actions,\n+\t\t\t\t attr,\n+\t\t\t\t error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\taction_flags |= MLX5_ACTION_TUNNEL_DECAP_L3;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION,\n@@ -1320,6 +1531,30 @@\n \t\tflow->actions |= MLX5_ACTION_TUNNEL_ENCAP_L3;\n \t\tactions_n++;\n \t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP:\n+\t\tdev_flow->dv.actions[actions_n].type =\n+\t\t\tMLX5DV_FLOW_ACTION_IBV_FLOW_ACTION;\n+\t\tdev_flow->dv.actions[actions_n].action =\n+\t\t\tmlx5_flow_dv_create_decap(action, ctx, error);\n+\t\tif (!(dev_flow->dv.actions[actions_n].action))\n+\t\t\treturn -rte_errno;\n+\t\tdev_flow->dv.decap_verb =\n+\t\t\tdev_flow->dv.actions[actions_n].action;\n+\t\tflow->actions |= MLX5_ACTION_TUNNEL_DECAP;\n+\t\tactions_n++;\n+\t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP_L3:\n+\t\tdev_flow->dv.actions[actions_n].type =\n+\t\t\tMLX5DV_FLOW_ACTION_IBV_FLOW_ACTION;\n+\t\tdev_flow->dv.actions[actions_n].action =\n+\t\t\tmlx5_flow_dv_create_decap_l3(action, ctx, error);\n+\t\tif (!(dev_flow->dv.actions[actions_n].action))\n+\t\t\treturn -rte_errno;\n+\t\tdev_flow->dv.decap_verb =\n+\t\t\tdev_flow->dv.actions[actions_n].action;\n+\t\tflow->actions |= MLX5_ACTION_TUNNEL_DECAP_L3;\n+\t\tactions_n++;\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -1679,13 +1914,16 @@\n \t\tLIST_REMOVE(dev_flow, next);\n \t\tif (dev_flow->dv.matcher)\n \t\t\tflow_dv_matcher_release(dev, dev_flow->dv.matcher);\n-\n \t\tif (dev_flow->dv.encap_verb) {\n \t\t\tclaim_zero(mlx5_glue->destroy_flow_action\n \t\t\t\t\t\t(dev_flow->dv.encap_verb));\n \t\t\tdev_flow->dv.encap_verb = NULL;\n \t\t}\n-\n+\t\tif (dev_flow->dv.decap_verb) {\n+\t\t\tclaim_zero(mlx5_glue->destroy_flow_action\n+\t\t\t\t\t\t(dev_flow->dv.decap_verb));\n+\t\t\tdev_flow->dv.decap_verb = NULL;\n+\t\t}\n \t\trte_free(dev_flow);\n \t}\n }\n",
    "prefixes": [
        "4/4"
    ]
}