Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45519/?format=api
{ "id": 45519, "url": "http://patches.dpdk.org/api/patches/45519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com", "date": "2018-09-27T12:30:24", "name": "bus/pci: set intr_handle type for secondary processes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bf5ff01ad48ee83418f28b55f348895a68fc4247", "submitter": { "id": 270, "url": "http://patches.dpdk.org/api/people/270/?format=api", "name": "Alejandro Lucero", "email": "alejandro.lucero@netronome.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com/mbox/", "series": [ { "id": 1550, "url": "http://patches.dpdk.org/api/series/1550/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1550", "date": "2018-09-27T12:30:24", "name": "bus/pci: set intr_handle type for secondary processes", "version": 1, "mbox": "http://patches.dpdk.org/series/1550/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45519/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45519/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 650271B475;\n\tThu, 27 Sep 2018 14:31:39 +0200 (CEST)", "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 590E81B452\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 14:31:38 +0200 (CEST)", "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw8RCUObT024211 for <dev@dpdk.org>; Thu, 27 Sep 2018 13:30:24 +0100", "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w8RCUOkR024210\n\tfor dev@dpdk.org; Thu, 27 Sep 2018 13:30:24 +0100" ], "From": "Alejandro Lucero <alejandro.lucero@netronome.com>", "To": "dev@dpdk.org", "Date": "Thu, 27 Sep 2018 13:30:24 +0100", "Message-Id": "<1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] bus/pci: set intr_handle type for secondary\n\tprocesses", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Invoking rte_pci_read/write_config functions requires device with\na intr_handle type for using VFIO or UIO driver related functions.\n\nSecondary processes rely on primary processes for device initialization\nso they do not usually require using these functions. However, some PMDs,\nlike NFP PMD, require using these functions even for secondary processes.\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/bus/pci/linux/pci_vfio.c | 2 ++\n drivers/bus/pci/pci_common_uio.c | 6 ++++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c\nindex 686386d..19f5d8e 100644\n--- a/drivers/bus/pci/linux/pci_vfio.c\n+++ b/drivers/bus/pci/linux/pci_vfio.c\n@@ -545,7 +545,9 @@\n \n \tstruct pci_map *maps;\n \n+\t/* This is required for using rte_pci_read/write_config */\n \tdev->intr_handle.fd = -1;\n+\tdev->intr_handle.type = RTE_INTR_HANDLE_VFIO_MSIX;\n \n \t/* store PCI address string */\n \tsnprintf(pci_addr, sizeof(pci_addr), PCI_PRI_FMT,\ndiff --git a/drivers/bus/pci/pci_common_uio.c b/drivers/bus/pci/pci_common_uio.c\nindex 54bc20b..6dba4e1 100644\n--- a/drivers/bus/pci/pci_common_uio.c\n+++ b/drivers/bus/pci/pci_common_uio.c\n@@ -31,6 +31,12 @@\n \tstruct mapped_pci_res_list *uio_res_list =\n \t\t\tRTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);\n \n+\t/* This is required for using rte_pci_read/write_config */\n+\tif (dev->kdrv == RTE_KDRV_IGB_UIO)\n+\t\tdev->intr_handle.type = RTE_INTR_HANDLE_UIO;\n+\telse\n+\t\tdev->intr_handle.type = RTE_INTR_HANDLE_UIO_INTX;\n+\n \tTAILQ_FOREACH(uio_res, uio_res_list, next) {\n \n \t\t/* skip this element if it doesn't match our PCI address */\n", "prefixes": [] }