Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45514/?format=api
{ "id": 45514, "url": "http://patches.dpdk.org/api/patches/45514/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538047196-13789-2-git-send-email-rasland@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538047196-13789-2-git-send-email-rasland@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538047196-13789-2-git-send-email-rasland@mellanox.com", "date": "2018-09-27T11:19:56", "name": "[v3,2/2] net/tap: add queues when attaching from secondary process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fd7581a3711f6b612c1adc827b261249f298486", "submitter": { "id": 513, "url": "http://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538047196-13789-2-git-send-email-rasland@mellanox.com/mbox/", "series": [ { "id": 1545, "url": "http://patches.dpdk.org/api/series/1545/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1545", "date": "2018-09-27T11:19:55", "name": "[v3,1/2] net/tap: change queue fd to be pointers to process private", "version": 3, "mbox": "http://patches.dpdk.org/series/1545/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45514/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45514/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55FF41B3B3;\n\tThu, 27 Sep 2018 13:20:18 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10080.outbound.protection.outlook.com [40.107.1.80])\n\tby dpdk.org (Postfix) with ESMTP id DC4ED1B39C\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 13:20:13 +0200 (CEST)", "from mellanox.com (37.142.13.130) by\n\tVI1PR05MB1263.eurprd05.prod.outlook.com (2a01:111:e400:5188::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.25;\n\tThu, 27 Sep 2018 11:20:10 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=YCp7Ei5hTzLjCIY75rLM3kB3neGab2Mgo3Y46f1+cVQ=;\n\tb=fEhKg1BqiusgnR4anpt3SRpFxvXaafBDCUHiL+a2woHPyfGRgn9OL/RWZKLP/oNv4vIZuETBexbybPRIQBC0ILpTAcqWpKrj5vUQ+b7Dj674MA7oMDOG4GKjGezAk63y2a0sCB3GD5LDftGK4v91gkefb70HtoXXsYj20zNa8pQ=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=rasland@mellanox.com; ", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "keith.wiles@intel.com", "Cc": "thomas@monjalon.net, dev@dpdk.org, shahafs@mellanox.com,\n\trasland@mellanox.com, orik@mellanox.com", "Date": "Thu, 27 Sep 2018 14:19:56 +0300", "Message-Id": "<1538047196-13789-2-git-send-email-rasland@mellanox.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1538047196-13789-1-git-send-email-rasland@mellanox.com>", "References": "<20180720105742.12669-1-thomas@monjalon.net>\n\t<1538047196-13789-1-git-send-email-rasland@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "HE1PR09CA0059.eurprd09.prod.outlook.com\n\t(2603:10a6:7:3c::27) To VI1PR05MB1263.eurprd05.prod.outlook.com\n\t(2a01:111:e400:5188::13)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "d095899f-dfc8-4976-b270-08d6246b3081", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR05MB1263; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR05MB1263;\n\t3:l1Wh1XyUZKkRQXLj/HU0I8+Obw2gmbV6h+gCzfVWoXverqdIkGZB2S+xiJ+dZleWX1dGlYYfOr6Rk849HVs5H9FULlTAHPqfiTXAh2Ne54OK6MO7yJWgLich4GiuZsL/79WwKVnEH1CyIqlDw+GllC/HRsk2EtJWHhFNtNngZdiH4m6RaRmKQYsljsy1dv8n9Db0YpO15gBD7SCzhhKtiepfBIUXScbrgNFiCR8DbCXmMp5zCyKQPXwl5Td2GfQ/;\n\t25:L585aoAnM13u5eUvtTm4AyCYiBlxmQtIy9vSxIGm2lKfI0INOKNMcYzMUptoqvHZX6LIOTNKDkzIxKfXDeErjLZWq4JIFktOzpSn/cM5CN/Nc+1RJV2weSIKrCSt5lhp9knXfk+LShVEe+1dehfPs4UaxTmeXwe+4tX5ncxCsgcM4DMNu+eNNoL7W5rgHdVeDG6eSmxeOxW5EtKSzfbdfoC16nVokQ0QEZ+/xU+75vEjC/rFmwm+Uqirghj7sZ8QpJDXpYuKDQx0+aTlDo92Z1Z95LvS0cMHzgxCuUuHpTpVPhJK2yvMqSvVZFRPzj+GLFs+1y2H+MF+kib+57TRwJd+JX/SznUxrNIXTC5W+iQ=;\n\t31:0UO5nflUJtpSwQFfO+RDlc3BYoBusWhBHLxnDAsPtVKoKMwHYmZqBTGb5kMRsHOJ7muTk1vMvZlcTgWiKTMNFJLa325I3m8QzNSc9F+BTpYUe/322zdInnCBw3kZqVa0zTWCMVdSbLO9Uq80q206ojfFxRMfz8YEUGIBcyt68hCIrpxC5TRjBoMF9NNQipYbISXmPF0pCkIoqIVO1e9gKGp6GGTqP6xldE7jjklRI0c=", "1; VI1PR05MB1263;\n\t20:SlpuH0M6OBBuId4pFeFK8Ug6gWYnDxF1m2XmRQQhWyl8gAfVmnJgPanZDHmKfHOsao6m8Cmccb7ZyvLrM7oKlMMqUQrNFTrWdV64twWEZNn4ZZLz+HeuilRRKLU/f2gD9h0w2BO+OLypZJS54TysmBONF/Kmex7tSPJraPpNIjCM1AQI7tlvHS6+3zYy05UU/2yWOeJG5h3mYAJAzqQinC9VvNola0eSKri9FSQ6STq5Y4FAkBibessAg5jZXFRskI3k+EBdTYI7GsSRrJ3gyg6s4XLBm9l+uhe5wgAPhqaRcu9qBsndDSKxRJ0r6rnnR9dCq+Ukkt77sPkvVdQfTK3ZAVaROgyX6/5vppGqLO/N7NG068Z4rAAZu/3PNYO89ABV0iJzHq9ym0LlnQKlHWcWeV7ocVp5Wwqat2TImnAi96KtweppGDgpBfh2RT6Er+E8C+MfZOfia3Jwd0rqIgenpwMO+5LycuJkXTq/c7rTGo7iMIdXHBFGNC1MTVNG;\n\t4:o6qpEiMLtjLm9UjCIZWbOPyBaGJ7irLGG12BuK9ECkiLGeNiiz9kLMqett6xdfqaPQ8eClz4gAyICOJNrpvryFqFR5EMj0jqHx6M41bWQnT1rIz8s38H2Dopy5Atf7bUiIkHu/wxpuqmP1736w0R/vPM4cO4G2zaog3ExKUbLuP4dAZX9IydW0/LT3L4RjIgY+SxDDY1I4wO5uf4vUHrkcRsDEU7Q07VEdJjUGXEP4hW7RqLBzRvMBYp7i7gn/jONh14y8TlyZLvrkmqGL71U+vqo9OYa4Y3YJ4DTo/s9amhfuJFwonkR8xeK2YG0h7j", "=?us-ascii?Q?1; VI1PR05MB1263;\n\t23:kAJSFEChq8AnAoZJag86DHrmsE4gvCQkZWl/I5xsy?=\n\tljjbAcE6U3hWFXAI4w0ijMWl8fkDtVZ2QPGtf0H2cWTaTbtsI6KQoatMscyZg2+x/MkQsjnwcGgyCYqgyOp9HgJsEn/3bhNTDYhcwD2t0mBlq0ekcbHMMV/cYVvpp5i3TLOS4mHdyLXaEKEP0woqEXQEavcvCb2ucQhPLaamFl0fK0Nko3KrOnmrMWhF+cJFxCjd9N2euBi+7APjkAR7mOz2TuRIl3v7IXAqI5PI3dY7CthUo74Ie1snON/L3PHHFWse3mQU+iHug+dVf6iIKskv9PbfIW5eVqG8yXdmG4mRMvFOXPQGDYOIqQfgBCivKxfrj145FO+jsN8nG70xL9qWBv6rGEKvZBE5utoxk368smn9v22ls8jWr4E/NBRAnUzhzWAdGd4hbNwsZ7g8JDbGUhzCQm1eJIwK4yvxHQtbC6yCCbZbIkM0ipIBXfBWfMkbn/9Xsp+qhvhRrxdmujUmpIAuC+SRaAqPEyENBA5jBdbfYJ4mC1z1iqS++CMLwV1UxbFs2ixlHb9xpd3uFN7f1gKN5T2WyIYABT5ak8a5maeMga0egZX9CV6H6uMFKJmI1Mihxj8rnknh9fe1Uoey8DrTrMnlE6Ro3T75vMuy8ah9yzqiV5Lix6Nyd5yzCpCDAbyzZmsMwmywxE4MbVYzH/c0WNUJRSRs7B3Fs7VM/lzSppjtIotp1+a0npvg/iWavZ97KYMDU5AjkKWeAp0xmjd3QCgeBP9aQsjxz0HgfsFRCMotoysrHH5EijUUyhsnERP73ZjQwehOfafQUgjWFYG+UyKQXwR3FyZjAxMIgtfD5iWWGjaitA81qcInwT7nZG+5xvItUc9U48TI18UgqVjNW1srJg/gEQiYzc8p+MRAfr+ohYIb/39qp50SwW0qzoHJ7LRV9XyA8F1zgFRcrK8+ZFyEdg7Oc70W+Y9jtZUhp2aqg+IcpfscRN9i5whyKD0QssHUHFR8nrpkex+KC1E1RE7VZJXU6CwAH4f8nMx3TcX+JwPWARi6gXdVbNwvX86Am3MG5EK+KkkXwrjxUEZK8S2371w0thAOWKYbTQkwdA03GRf8KnASMPqIkNj7VHuEHqX+e2f1bvbO/8nZfMrRtL0ww8Jr2pDMIGpte0kEkeER8l7KFGJB1OsZYgG3Io12WsOCXLNrpSQSAwfcFKza1gEnw3EIHAZGYOM57FoTCXUHtHpnBnI7RgV0YDJVs+tdFLpS8S8NsqWMxDHIdThUSJCiJjDJ4aP7MWRaybSwapRABcw2H/VvUW2uyXkqnwfRDRIMgMWTSyU9T30", "1; VI1PR05MB1263;\n\t6:VKae8OjRriwomhaojMSaWqj4XeqgdwvIMZZm28t5cNgL3wg1lujIz3dLFbDlcK9U3HotvQbeKr+E9auvgohK1hLlMOjD/TGPRwY8oczhTe7YuKyhI4o36pVN+pfUn7NiZzPwHxD6HObrb2AdbCmJsQxnkUIJjFYxtZsc17HWiRio9c0RuqqcF+JH2SDMz/SWSJWlvt3oL/dfWlwb2uIFr6s2INRavkA4map7gmUMsEX8ffx5eOsV1CobPD10vFo5UtQ5TTgEXgrnvaSDZVmbPi/4m8ZBsd/GWIiLdzuOsDKUrkVQDpNqXoF2UWDBC/9fFdAzp6tYr43EvIbO268BVHqXrrG+NP6fvD+5jmW9yqM4oFqW6LcZWtDuh+vv8m51jRautqABhxrw1zSTtXNSzWKcX00HBIWVEQKxsTRpYUq/fABKSApO61P8LZsoUVAViUVaplW4t7VP0eEUEUeilA==;\n\t5:ggnmLWGRnA9Vgde0+y4DYQXRL24mYrXFhpEPlJe/jXaUDIUwpjqg7ZgQCTQmvj1fWUEZh92OF3JEqSQD18wFEMnqenDdPMPU5AjO1eZ6jBnOOF/Vb4Jxq5t63u8rtYTJ0hgE5GcKol/srYvcHTHy7D0eBNtMPYMx50VhvpEQe7c=;\n\t7:WnNY1gzFa5ieHHnXDsZUIddHyzZM8tA5P3qvokam62OPDTjoY+JKSK18xGVWg5djTiDkVftVx0gYTJ4ohyQSrDuXsLJWXJ9aAI/16zKZkKWUfqzhvwYd4RaUDlXtLRlNg6xBcN3E+GOsvB8WrkcpEaYDao7A14Tb7ScgVGzwjgBmEsPfD1bXM9K8PGIH7rQjE2wCJKxeNvNPeHDHu87F+CckuM7QE9UnRuSBraPk4hIR4icDIMRzAV3/3eSiE1bL" ], "X-MS-TrafficTypeDiagnostic": "VI1PR05MB1263:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Microsoft-Antispam-PRVS": "<VI1PR05MB1263292ACD8388B824C47941C2140@VI1PR05MB1263.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(72170088055959);", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699051);\n\tSRVR:VI1PR05MB1263; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1263; ", "X-Forefront-PRVS": "0808323E97", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(346002)(376002)(396003)(366004)(39860400002)(189003)(199004)(76176011)(97736004)(7696005)(51416003)(53936002)(66066001)(47776003)(478600001)(21086003)(5660300001)(4326008)(33026002)(386003)(55016002)(36756003)(52116002)(68736007)(8886007)(16586007)(6116002)(3846002)(86362001)(69596002)(446003)(476003)(2616005)(486006)(7736002)(81156014)(8936002)(956004)(11346002)(305945005)(81166006)(8676002)(26005)(50226002)(186003)(316002)(50466002)(16526019)(25786009)(106356001)(6666003)(2351001)(107886003)(48376002)(2361001)(2906002)(6916009)(14444005)(5024004)(105586002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1263; H:mellanox.com; FPR:;\n\tSPF:None; \n\tLANG:en; PTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "Pm+g/Qpa/M9u73B+stS01G5fwezEWI1myrGYhSYXEfKhLhwwkSJFm0p1x1ycytyWvRlLyvnr8tpYAV9tNLrr7iQLPSxf4qatxXP0FcPCceudGouuKRByqQYFaVkVyOVHt/igO3G3MMBr4WXZZSDmfMtrmkeVn5GlBBVN+0vgLc0FCetflO+lARaaSx+8QpgyBYmbEe8lFWUOShaYFF+QgQm51RrDpwf0+wGlwWv7kXKH2HbZSDCElc3Lo5mF5EozWU++/CIePDOUXWIPnC3fMVCz1XRCZeB0DfY45Rhtaem7GRNEyosMpBQNOicrr4Hc0lCziYBVBoqA2L5ajjcmZkCFMjhE/SOP16DdvC30Ygw=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Sep 2018 11:20:10.3253\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d095899f-dfc8-4976-b270-08d6246b3081", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB1263", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/tap: add queues when attaching from\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the case the device is created by the primary process,\nthe secondary must request some file descriptors to attach the queues.\nThe file descriptors are shared via IPC Unix socket.\n\nThanks to the IPC synchronization, the secondary process\nis now able to do Rx/Tx on a TAP created by the primary process.\n\nSigned-off-by: Raslan Darawsheh <rasland@mellanox.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n\n---\nv2:\n - translate file descriptors via IPC API\n - add documentation\nv3:\n - rabse the commit\n - use private static array for fd's to be local for each process\n\n---\n---\n doc/guides/nics/tap.rst | 16 ++++\n doc/guides/rel_notes/release_18_11.rst | 4 +\n drivers/net/tap/Makefile | 1 +\n drivers/net/tap/rte_eth_tap.c | 133 +++++++++++++++++++++++++++++++++\n 4 files changed, 154 insertions(+)", "diff": "diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst\nindex 2714868..d1f3e1c 100644\n--- a/doc/guides/nics/tap.rst\n+++ b/doc/guides/nics/tap.rst\n@@ -152,6 +152,22 @@ Distribute IPv4 TCP packets using RSS to a given MAC address over queues 0-3::\n testpmd> flow create 0 priority 4 ingress pattern eth dst is 0a:0b:0c:0d:0e:0f \\\n / ipv4 / tcp / end actions rss queues 0 1 2 3 end / end\n \n+Multi-process sharing\n+---------------------\n+\n+It is possible to attach an existing TAP device in a secondary process,\n+by declaring it as a vdev with the same name as in the primary process,\n+and without any parameter.\n+\n+The port attached in a secondary process will give access to the\n+statistics and the queues.\n+Therefore it can be used for monitoring or Rx/Tx processing.\n+\n+The IPC synchronization of Rx/Tx queues is currently limited:\n+\n+ - Only 8 queues\n+ - Synchronized on probing, but not on later port update\n+\n Example\n -------\n \ndiff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex 8c4bb54..a9dda5b 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -67,6 +67,10 @@ New Features\n SR-IOV option in Hyper-V and Azure. This is an alternative to the previous\n vdev_netvsc, tap, and failsafe drivers combination.\n \n+* **Added TAP Rx/Tx queues sharing with a secondary process.**\n+\n+ A secondary process can attach a TAP device created in the primary process,\n+ probe the queues, and process Rx/Tx in a secondary process.\n \n API Changes\n -----------\ndiff --git a/drivers/net/tap/Makefile b/drivers/net/tap/Makefile\nindex 3243365..7748283 100644\n--- a/drivers/net/tap/Makefile\n+++ b/drivers/net/tap/Makefile\n@@ -22,6 +22,7 @@ CFLAGS += -O3\n CFLAGS += -I$(SRCDIR)\n CFLAGS += -I.\n CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash\n LDLIBS += -lrte_bus_vdev -lrte_gso\ndiff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 8cc4552..8d276eb 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -16,6 +16,8 @@\n #include <rte_debug.h>\n #include <rte_ip.h>\n #include <rte_string_fns.h>\n+#include <rte_ethdev.h>\n+#include <rte_errno.h>\n \n #include <assert.h>\n #include <sys/types.h>\n@@ -62,6 +64,9 @@\n #define TAP_GSO_MBUFS_NUM \\\n \t(TAP_GSO_MBUFS_PER_CORE * TAP_GSO_MBUF_CACHE_SIZE)\n \n+/* IPC key for queue fds sync */\n+#define TAP_MP_KEY \"tap_mp_sync_queues\"\n+\n static struct rte_vdev_driver pmd_tap_drv;\n static struct rte_vdev_driver pmd_tun_drv;\n static struct pmd_process_private *process_private;\n@@ -101,6 +106,17 @@ enum ioctl_mode {\n \tREMOTE_ONLY,\n };\n \n+/* Message header to synchronize queues via IPC */\n+struct ipc_queues {\n+\tchar port_name[RTE_DEV_NAME_MAX_LEN];\n+\tint rxq_count;\n+\tint txq_count;\n+\t/*\n+\t * The file descriptors are in the dedicated part\n+\t * of the Unix message to be translated by the kernel.\n+\t */\n+};\n+\n static int tap_intr_handle_set(struct rte_eth_dev *dev, int set);\n \n /**\n@@ -1980,6 +1996,100 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)\n \treturn ret;\n }\n \n+/* Request queue file descriptors from secondary to primary. */\n+static int\n+tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n+{\n+\tint ret;\n+\tstruct timespec timeout = {.tv_sec = 1, .tv_nsec = 0};\n+\tstruct rte_mp_msg request, *reply;\n+\tstruct rte_mp_reply replies;\n+\tstruct ipc_queues *request_param = (struct ipc_queues *)request.param;\n+\tstruct ipc_queues *reply_param;\n+\tint queue, fd_iterator;\n+\n+\t/* Prepare the request */\n+\tstrcpy(request.name, TAP_MP_KEY);\n+\tstrcpy(request_param->port_name, port_name);\n+\trequest.len_param = sizeof(*request_param);\n+\t/* Send request and receive reply */\n+\tret = rte_mp_request_sync(&request, &replies, &timeout);\n+\tif (ret < 0) {\n+\t\tTAP_LOG(ERR, \"Failed to request queues from primary: %d\",\n+\t\t\trte_errno);\n+\t\treturn -1;\n+\t}\n+\t/* FIXME: handle replies.nb_received > 1 */\n+\treply = &replies.msgs[0];\n+\treply_param = (struct ipc_queues *)reply->param;\n+\tTAP_LOG(DEBUG, \"Received IPC reply for %s\", reply_param->port_name);\n+\n+\t/* Attach the queues from received file descriptors */\n+\n+\tdev->data->nb_rx_queues = reply_param->rxq_count;\n+\tdev->data->nb_tx_queues = reply_param->txq_count;\n+\tfd_iterator = 0;\n+\tfor (queue = 0; queue < reply_param->rxq_count; queue++)\n+\t\tprocess_private->rxq_fds[queue] = reply->fds[fd_iterator++];\n+\tfor (queue = 0; queue < reply_param->txq_count; queue++)\n+\t\tprocess_private->txq_fds[queue] = reply->fds[fd_iterator++];\n+\n+\n+\treturn 0;\n+}\n+\n+/* Send the queue file descriptors from the primary process to secondary. */\n+static int\n+tap_mp_sync_queues(const struct rte_mp_msg *request, const void *peer)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tstruct rte_mp_msg reply;\n+\tconst struct ipc_queues *request_param =\n+\t\t(const struct ipc_queues *)request->param;\n+\tstruct ipc_queues *reply_param =\n+\t\t(struct ipc_queues *)reply.param;\n+\tuint16_t port_id;\n+\tint queue;\n+\tint ret;\n+\n+\t/* Get requested port */\n+\tTAP_LOG(DEBUG, \"Received IPC request for %s\", request_param->port_name);\n+\tret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id);\n+\tif (ret) {\n+\t\tTAP_LOG(ERR, \"Failed to get port id for %s\",\n+\t\t\trequest_param->port_name);\n+\t\treturn -1;\n+\t}\n+\tdev = &rte_eth_devices[port_id];\n+\n+\t/* Fill file descriptors for all queues */\n+\treply.num_fds = 0;\n+\treply_param->rxq_count = 0;\n+\tfor (queue = 0; queue < dev->data->nb_rx_queues; queue++) {\n+\t\treply.fds[reply.num_fds++] = process_private->rxq_fds[queue];\n+\t\treply_param->rxq_count++;\n+\t}\n+\tassert(reply_param->rxq_count == dev->data->nb_rx_queues);\n+\treply_param->txq_count = 0;\n+\tfor (queue = 0; queue < dev->data->nb_tx_queues; queue++) {\n+\t\treply.fds[reply.num_fds++] = process_private->txq_fds[queue];\n+\t\treply_param->txq_count++;\n+\t}\n+\tassert(reply_param->txq_count == dev->data->nb_tx_queues);\n+\t/* FIXME: split message if more queues than RTE_MP_MAX_FD_NUM */\n+\tRTE_ASSERT(reply.num_fds <= RTE_MP_MAX_FD_NUM);\n+\n+\t/* Send reply */\n+\tstrcpy(reply.name, request->name);\n+\tstrcpy(reply_param->port_name, request_param->port_name);\n+\treply.len_param = sizeof(*reply_param);\n+\tif (rte_mp_reply(&reply, peer) < 0) {\n+\t\tTAP_LOG(ERR, \"Failed to reply an IPC request to sync queues\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n /* Open a TAP interface device.\n */\n static int\n@@ -2009,6 +2119,21 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)\n \t\t/* TODO: request info from primary to set up Rx and Tx */\n \t\teth_dev->dev_ops = &ops;\n \t\teth_dev->device = &dev->device;\n+\t\teth_dev->rx_pkt_burst = pmd_rx_burst;\n+\t\teth_dev->tx_pkt_burst = pmd_tx_burst;\n+\t\tif (!rte_eal_primary_proc_alive(NULL)) {\n+\t\t\tTAP_LOG(ERR, \"Primary process is missing\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tprocess_private = (struct pmd_process_private *)\n+\t\t\trte_zmalloc_socket(name,\n+\t\t\t\tsizeof(struct pmd_process_private),\n+\t\t\t\t\tRTE_CACHE_LINE_SIZE,\n+\t\t\t\t\teth_dev->device->numa_node);\n+\n+\t\tret = tap_mp_attach_queues(name, eth_dev);\n+\t\tif (ret != 0)\n+\t\t\treturn -1;\n \t\trte_eth_dev_probing_finish(eth_dev);\n \t\treturn 0;\n \t}\n@@ -2056,6 +2181,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)\n \tTAP_LOG(NOTICE, \"Initializing pmd_tap for %s as %s\",\n \t\tname, tap_name);\n \n+\t/* Register IPC feed callback */\n+\tret = rte_mp_action_register(TAP_MP_KEY, tap_mp_sync_queues);\n+\tif (ret < 0 && rte_errno != EEXIST) {\n+\t\tTAP_LOG(ERR, \"%s: Failed to register IPC callback: %s\",\n+\t\t\ttuntap_name, strerror(rte_errno));\n+\t\tgoto leave;\n+\t}\n \tret = eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac,\n \t\tETH_TUNTAP_TYPE_TAP);\n \n@@ -2063,6 +2195,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)\n \tif (ret == -1) {\n \t\tTAP_LOG(ERR, \"Failed to create pmd for %s as %s\",\n \t\t\tname, tap_name);\n+\t\trte_mp_action_unregister(TAP_MP_KEY);\n \t\ttap_unit--;\t\t/* Restore the unit number */\n \t}\n \trte_kvargs_free(kvlist);\n", "prefixes": [ "v3", "2/2" ] }