Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45286/?format=api
{ "id": 45286, "url": "http://patches.dpdk.org/api/patches/45286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com", "date": "2018-09-25T07:02:34", "name": "[v2,1/2] event/dpaa: remove duplicate log macros", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "70614ad4d0ef5fb6a865b9ff829dd2cc261dba01", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 1481, "url": "http://patches.dpdk.org/api/series/1481/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1481", "date": "2018-09-25T07:02:34", "name": "[v2,1/2] event/dpaa: remove duplicate log macros", "version": 2, "mbox": "http://patches.dpdk.org/series/1481/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45286/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/45286/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6FBA81E34;\n\tTue, 25 Sep 2018 09:04:40 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id 231F51AFF\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 09:04:39 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 994341A0099;\n\tTue, 25 Sep 2018 09:04:38 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id BC4DD1A006A;\n\tTue, 25 Sep 2018 09:04:36 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.134.28])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3AC32402D8;\n\tTue, 25 Sep 2018 15:04:34 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "jerin.jacob@caviumnetworks.com", "Date": "Tue, 25 Sep 2018 12:32:34 +0530", "Message-Id": "<1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535607196-26782-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1535607196-26782-1-git-send-email-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 1/2] event/dpaa: remove duplicate log macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "align and cleanup the debug log prints\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\nNote: This patch has a dependency on following patch series:\nhttp://mails.dpdk.org/archives/dev/2018-September/112433.html\nwhich is now part of dpdk-next-net tree.\n\n drivers/event/dpaa/dpaa_eventdev.c | 58 +++++++++++++++++++-------------------\n drivers/event/dpaa/dpaa_eventdev.h | 7 -----\n 2 files changed, 29 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c\nindex 5443ef5..9ddaf30 100644\n--- a/drivers/event/dpaa/dpaa_eventdev.c\n+++ b/drivers/event/dpaa/dpaa_eventdev.c\n@@ -49,7 +49,7 @@ dpaa_event_dequeue_timeout_ticks(struct rte_eventdev *dev, uint64_t ns,\n {\n \tuint64_t cycles_per_second;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \n@@ -175,7 +175,7 @@ static void\n dpaa_event_dev_info_get(struct rte_eventdev *dev,\n \t\t\tstruct rte_event_dev_info *dev_info)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tdev_info->driver_name = \"event_dpaa\";\n@@ -220,8 +220,7 @@ dpaa_event_dev_configure(const struct rte_eventdev *dev)\n \tint ret, i;\n \tuint32_t *ch_id;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n-\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \tpriv->dequeue_timeout_ns = conf->dequeue_timeout_ns;\n \tpriv->nb_events_limit = conf->nb_events_limit;\n \tpriv->nb_event_queues = conf->nb_event_queues;\n@@ -244,13 +243,14 @@ dpaa_event_dev_configure(const struct rte_eventdev *dev)\n \t\t\t sizeof(uint32_t) * priv->nb_event_queues,\n \t\t\t RTE_CACHE_LINE_SIZE);\n \tif (ch_id == NULL) {\n-\t\tEVENTDEV_DRV_ERR(\"Fail to allocate memory for dpaa channels\\n\");\n+\t\tDPAA_EVENTDEV_ERR(\"Fail to allocate memory for dpaa channels\\n\");\n \t\treturn -ENOMEM;\n \t}\n \t/* Create requested event queues within the given event device */\n \tret = qman_alloc_pool_range(ch_id, priv->nb_event_queues, 1, 0);\n \tif (ret < 0) {\n-\t\tEVENTDEV_DRV_ERR(\"Failed to create internal channel\\n\");\n+\t\tDPAA_EVENTDEV_ERR(\"qman_alloc_pool_range %u, err =%d\\n\",\n+\t\t\t\t priv->nb_event_queues, ret);\n \t\trte_free(ch_id);\n \t\treturn ret;\n \t}\n@@ -283,7 +283,7 @@ dpaa_event_dev_configure(const struct rte_eventdev *dev)\n \t * can be created equals to number of lcore.\n \t */\n \trte_free(ch_id);\n-\tEVENTDEV_DRV_LOG(\"Configured eventdev devid=%d\", dev->data->dev_id);\n+\tDPAA_EVENTDEV_INFO(\"Configured eventdev devid=%d\", dev->data->dev_id);\n \n \treturn 0;\n }\n@@ -291,7 +291,7 @@ dpaa_event_dev_configure(const struct rte_eventdev *dev)\n static int\n dpaa_event_dev_start(struct rte_eventdev *dev)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \tRTE_SET_USED(dev);\n \n \treturn 0;\n@@ -300,14 +300,14 @@ dpaa_event_dev_start(struct rte_eventdev *dev)\n static void\n dpaa_event_dev_stop(struct rte_eventdev *dev)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \tRTE_SET_USED(dev);\n }\n \n static int\n dpaa_event_dev_close(struct rte_eventdev *dev)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \tRTE_SET_USED(dev);\n \n \treturn 0;\n@@ -317,7 +317,7 @@ static void\n dpaa_event_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,\n \t\t\t struct rte_event_queue_conf *queue_conf)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tRTE_SET_USED(queue_id);\n@@ -334,14 +334,14 @@ dpaa_event_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,\n \tstruct dpaa_eventdev *priv = dev->data->dev_private;\n \tstruct dpaa_eventq *evq_info = &priv->evq_info[queue_id];\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tswitch (queue_conf->schedule_type) {\n \tcase RTE_SCHED_TYPE_PARALLEL:\n \tcase RTE_SCHED_TYPE_ATOMIC:\n \t\tbreak;\n \tcase RTE_SCHED_TYPE_ORDERED:\n-\t\tEVENTDEV_DRV_ERR(\"Schedule type is not supported.\");\n+\t\tDPAA_EVENTDEV_ERR(\"Schedule type is not supported.\");\n \t\treturn -1;\n \t}\n \tevq_info->event_queue_cfg = queue_conf->event_queue_cfg;\n@@ -353,7 +353,7 @@ dpaa_event_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,\n static void\n dpaa_event_queue_release(struct rte_eventdev *dev, uint8_t queue_id)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tRTE_SET_USED(queue_id);\n@@ -363,7 +363,7 @@ static void\n dpaa_event_port_default_conf_get(struct rte_eventdev *dev, uint8_t port_id,\n \t\t\t\t struct rte_event_port_conf *port_conf)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tRTE_SET_USED(port_id);\n@@ -379,7 +379,7 @@ dpaa_event_port_setup(struct rte_eventdev *dev, uint8_t port_id,\n {\n \tstruct dpaa_eventdev *eventdev = dev->data->dev_private;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(port_conf);\n \tdev->data->ports[port_id] = &eventdev->ports[port_id];\n@@ -390,7 +390,7 @@ dpaa_event_port_setup(struct rte_eventdev *dev, uint8_t port_id,\n static void\n dpaa_event_port_release(void *port)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(port);\n }\n@@ -466,7 +466,7 @@ dpaa_event_eth_rx_adapter_caps_get(const struct rte_eventdev *dev,\n {\n \tconst char *ethdev_driver = eth_dev->device->driver->name;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \n@@ -491,14 +491,14 @@ dpaa_event_eth_rx_adapter_queue_add(\n \tstruct dpaa_if *dpaa_intf = eth_dev->data->dev_private;\n \tint ret, i;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tif (rx_queue_id == -1) {\n \t\tfor (i = 0; i < dpaa_intf->nb_rx_queues; i++) {\n \t\t\tret = dpaa_eth_eventq_attach(eth_dev, i, ch_id,\n \t\t\t\t\t\t queue_conf);\n \t\t\tif (ret) {\n-\t\t\t\tEVENTDEV_DRV_ERR(\n+\t\t\t\tDPAA_EVENTDEV_ERR(\n \t\t\t\t\t\"Event Queue attach failed:%d\\n\", ret);\n \t\t\t\tgoto detach_configured_queues;\n \t\t\t}\n@@ -508,7 +508,7 @@ dpaa_event_eth_rx_adapter_queue_add(\n \n \tret = dpaa_eth_eventq_attach(eth_dev, rx_queue_id, ch_id, queue_conf);\n \tif (ret)\n-\t\tEVENTDEV_DRV_ERR(\"dpaa_eth_eventq_attach failed:%d\\n\", ret);\n+\t\tDPAA_EVENTDEV_ERR(\"dpaa_eth_eventq_attach failed:%d\\n\", ret);\n \treturn ret;\n \n detach_configured_queues:\n@@ -527,14 +527,14 @@ dpaa_event_eth_rx_adapter_queue_del(const struct rte_eventdev *dev,\n \tint ret, i;\n \tstruct dpaa_if *dpaa_intf = eth_dev->data->dev_private;\n \n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tif (rx_queue_id == -1) {\n \t\tfor (i = 0; i < dpaa_intf->nb_rx_queues; i++) {\n \t\t\tret = dpaa_eth_eventq_detach(eth_dev, i);\n \t\t\tif (ret)\n-\t\t\t\tEVENTDEV_DRV_ERR(\n+\t\t\t\tDPAA_EVENTDEV_ERR(\n \t\t\t\t\t\"Event Queue detach failed:%d\\n\", ret);\n \t\t}\n \n@@ -543,7 +543,7 @@ dpaa_event_eth_rx_adapter_queue_del(const struct rte_eventdev *dev,\n \n \tret = dpaa_eth_eventq_detach(eth_dev, rx_queue_id);\n \tif (ret)\n-\t\tEVENTDEV_DRV_ERR(\"dpaa_eth_eventq_detach failed:%d\\n\", ret);\n+\t\tDPAA_EVENTDEV_ERR(\"dpaa_eth_eventq_detach failed:%d\\n\", ret);\n \treturn ret;\n }\n \n@@ -551,7 +551,7 @@ static int\n dpaa_event_eth_rx_adapter_start(const struct rte_eventdev *dev,\n \t\t\t\tconst struct rte_eth_dev *eth_dev)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tRTE_SET_USED(eth_dev);\n@@ -563,7 +563,7 @@ static int\n dpaa_event_eth_rx_adapter_stop(const struct rte_eventdev *dev,\n \t\t\t const struct rte_eth_dev *eth_dev)\n {\n-\tEVENTDEV_DRV_FUNC_TRACE();\n+\tEVENTDEV_INIT_FUNC_TRACE();\n \n \tRTE_SET_USED(dev);\n \tRTE_SET_USED(eth_dev);\n@@ -603,7 +603,7 @@ dpaa_event_dev_create(const char *name)\n \t\t\t\t\t sizeof(struct dpaa_eventdev),\n \t\t\t\t\t rte_socket_id());\n \tif (eventdev == NULL) {\n-\t\tEVENTDEV_DRV_ERR(\"Failed to create eventdev vdev %s\", name);\n+\t\tDPAA_EVENTDEV_ERR(\"Failed to create eventdev vdev %s\", name);\n \t\tgoto fail;\n \t}\n \n@@ -631,7 +631,7 @@ dpaa_event_dev_probe(struct rte_vdev_device *vdev)\n \tconst char *name;\n \n \tname = rte_vdev_device_name(vdev);\n-\tEVENTDEV_DRV_LOG(\"Initializing %s\", name);\n+\tDPAA_EVENTDEV_INFO(\"Initializing %s\", name);\n \n \treturn dpaa_event_dev_create(name);\n }\n@@ -642,7 +642,7 @@ dpaa_event_dev_remove(struct rte_vdev_device *vdev)\n \tconst char *name;\n \n \tname = rte_vdev_device_name(vdev);\n-\tEVENTDEV_DRV_LOG(\"Closing %s\", name);\n+\tDPAA_EVENTDEV_INFO(\"Closing %s\", name);\n \n \treturn rte_event_pmd_vdev_uninit(name);\n }\ndiff --git a/drivers/event/dpaa/dpaa_eventdev.h b/drivers/event/dpaa/dpaa_eventdev.h\nindex 583e46c..3994bd6 100644\n--- a/drivers/event/dpaa/dpaa_eventdev.h\n+++ b/drivers/event/dpaa/dpaa_eventdev.h\n@@ -12,13 +12,6 @@\n \n #define EVENTDEV_NAME_DPAA_PMD\t\tevent_dpaa1\n \n-#define EVENTDEV_DRV_LOG(fmt, args...)\t\\\n-\t\tDPAA_EVENTDEV_INFO(fmt, ## args)\n-#define EVENTDEV_DRV_FUNC_TRACE()\t\\\n-\t\tDPAA_EVENTDEV_DEBUG(\"%s() Called:\\n\", __func__)\n-#define EVENTDEV_DRV_ERR(fmt, args...)\t\\\n-\t\tDPAA_EVENTDEV_ERR(\"%s(): \" fmt \"\\n\", __func__, ## args)\n-\n #define DPAA_EVENT_MAX_PORTS\t\t\t8\n #define DPAA_EVENT_MAX_QUEUES\t\t\t16\n #define DPAA_EVENT_MIN_DEQUEUE_TIMEOUT\t1\n", "prefixes": [ "v2", "1/2" ] }