Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44906/?format=api
{ "id": 44906, "url": "http://patches.dpdk.org/api/patches/44906/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180919100417.37868-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180919100417.37868-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180919100417.37868-2-bruce.richardson@intel.com", "date": "2018-09-19T10:04:15", "name": "[v4,1/3] net/avf: fix unused variables and label", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "338bd72d263633f828a19eca4d19de6b5cfe36f9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180919100417.37868-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 1386, "url": "http://patches.dpdk.org/api/series/1386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1386", "date": "2018-09-19T10:04:14", "name": "AVF build improvements", "version": 4, "mbox": "http://patches.dpdk.org/series/1386/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44906/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/44906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BC1D94CA2;\n\tWed, 19 Sep 2018 12:06:00 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 2B09C34F3;\n\tWed, 19 Sep 2018 12:05:59 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2018 03:05:58 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby orsmga005.jf.intel.com with ESMTP; 19 Sep 2018 03:04:40 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,393,1531810800\"; d=\"scan'208\";a=\"258522795\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Jingjing Wu <jingjing.wu@intel.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>", "Cc": "dev@dpdk.org, Zhang Qi Z <qi.z.zhang@intel.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org", "Date": "Wed, 19 Sep 2018 11:04:15 +0100", "Message-Id": "<20180919100417.37868-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180919100417.37868-1-bruce.richardson@intel.com>", "References": "<20180913144405.72772-1-bruce.richardson@intel.com>\n\t<20180919100417.37868-1-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/3] net/avf: fix unused variables and label", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compiling with all warnings turned on causes errors about unused variables\nand an unused label. Remove these to allow building without having to\ndisable those warnings.\n\nFixes: 69dd4c3d0898 (\"net/avf: enable queue and device\")\nFixes: 3fd7a3719c66 (\"net/avf: enable ops for MTU setting\")\nFixes: d6bde6b5eae9 (\"net/avf: enable Rx interrupt\")\nFixes: 22b123a36d07 (\"net/avf: initialize PMD\")\nFixes: 319c421f3890 (\"net/avf: enable SSE Rx Tx\")\nFixes: a2b29a7733ef (\"net/avf: enable basic Rx Tx\")\nFixes: 1060591eada5 (\"net/avf: enable bulk allocate Rx\")\n\nCC: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/avf/avf_ethdev.c | 15 +--------------\n drivers/net/avf/avf_rxtx.c | 19 ++++++-------------\n drivers/net/avf/avf_vchnl.c | 2 --\n 3 files changed, 7 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c\nindex a7d69828c..6b6ff7d55 100644\n--- a/drivers/net/avf/avf_ethdev.c\n+++ b/drivers/net/avf/avf_ethdev.c\n@@ -154,7 +154,6 @@ static int\n avf_init_rss(struct avf_adapter *adapter)\n {\n \tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);\n \tstruct rte_eth_rss_conf *rss_conf;\n \tuint8_t i, j, nb_q;\n \tint ret;\n@@ -259,11 +258,8 @@ avf_init_rxq(struct rte_eth_dev *dev, struct avf_rx_queue *rxq)\n static int\n avf_init_queues(struct rte_eth_dev *dev)\n {\n-\tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tstruct avf_rx_queue **rxq =\n \t\t(struct avf_rx_queue **)dev->data->rx_queues;\n-\tstruct avf_tx_queue **txq =\n-\t\t(struct avf_tx_queue **)dev->data->tx_queues;\n \tint i, ret = AVF_SUCCESS;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n@@ -415,7 +411,6 @@ avf_dev_start(struct rte_eth_dev *dev)\n \t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = dev->intr_handle;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -476,9 +471,7 @@ avf_dev_stop(struct rte_eth_dev *dev)\n \tstruct avf_adapter *adapter =\n \t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = dev->intr_handle;\n-\tint ret, i;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -503,8 +496,6 @@ avf_dev_stop(struct rte_eth_dev *dev)\n static void\n avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n-\tstruct avf_adapter *adapter =\n-\t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \n \tmemset(dev_info, 0, sizeof(*dev_info));\n@@ -914,7 +905,6 @@ avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n static int\n avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n {\n-\tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tuint32_t frame_size = mtu + AVF_ETH_OVERHEAD;\n \tint ret = 0;\n \n@@ -1044,8 +1034,6 @@ avf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)\n static int\n avf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)\n {\n-\tstruct avf_adapter *adapter =\n-\t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tuint16_t msix_intr;\n@@ -1088,7 +1076,7 @@ avf_check_vf_reset_done(struct avf_hw *hw)\n static int\n avf_init_vf(struct rte_eth_dev *dev)\n {\n-\tint i, err, bufsz;\n+\tint err, bufsz;\n \tstruct avf_adapter *adapter =\n \t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1197,7 +1185,6 @@ avf_dev_interrupt_handler(void *param)\n \n \tavf_handle_virtchnl_msg(dev);\n \n-done:\n \tavf_enable_irq0(hw);\n }\n \ndiff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c\nindex e03a136fc..6b3b0191c 100644\n--- a/drivers/net/avf/avf_rxtx.c\n+++ b/drivers/net/avf/avf_rxtx.c\n@@ -247,7 +247,6 @@ alloc_rxq_mbufs(struct avf_rx_queue *rxq)\n static inline void\n release_rxq_mbufs(struct avf_rx_queue *rxq)\n {\n-\tstruct rte_mbuf *mbuf;\n \tuint16_t i;\n \n \tif (!rxq->sw_ring)\n@@ -310,9 +309,8 @@ avf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tstruct avf_rx_queue *rxq;\n \tconst struct rte_memzone *mz;\n \tuint32_t ring_size;\n-\tuint16_t len, i;\n+\tuint16_t len;\n \tuint16_t rx_free_thresh;\n-\tuint16_t base, bsf, tc_mapping;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -428,13 +426,10 @@ avf_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t const struct rte_eth_txconf *tx_conf)\n {\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct avf_adapter *ad =\n-\t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct avf_tx_queue *txq;\n \tconst struct rte_memzone *mz;\n \tuint32_t ring_size;\n \tuint16_t tx_rs_thresh, tx_free_thresh;\n-\tuint16_t i, base, bsf, tc_mapping;\n \tuint64_t offloads;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -515,8 +510,11 @@ avf_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \ttxq->ops = &def_txq_ops;\n \n #ifdef RTE_LIBRTE_AVF_INC_VECTOR\n-\tif (check_tx_vec_allow(txq) == FALSE)\n+\tif (check_tx_vec_allow(txq) == FALSE) {\n+\t\tstruct avf_adapter *ad =\n+\t\t\tAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \t\tad->tx_vec_allowed = false;\n+\t}\n #endif\n \n \treturn 0;\n@@ -1268,7 +1266,6 @@ static inline uint16_t\n rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct avf_rx_queue *rxq = (struct avf_rx_queue *)rx_queue;\n-\tstruct rte_eth_dev *dev;\n \tuint16_t nb_rx = 0;\n \n \tif (!nb_pkts)\n@@ -1584,10 +1581,6 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \n \t\tif (nb_ctx) {\n \t\t\t/* Setup TX context descriptor if required */\n-\t\t\tvolatile struct avf_tx_context_desc *ctx_txd =\n-\t\t\t\t(volatile struct avf_tx_context_desc *)\n-\t\t\t\t\t&txr[tx_id];\n-\t\t\tuint16_t cd_l2tag2 = 0;\n \t\t\tuint64_t cd_type_cmd_tso_mss =\n \t\t\t\tAVF_TX_DESC_DTYPE_CONTEXT;\n \n@@ -1603,7 +1596,7 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\tcd_type_cmd_tso_mss |=\n \t\t\t\t\tavf_set_tso_ctx(tx_pkt, tx_offload);\n \n-\t\t\tAVF_DUMP_TX_DESC(txq, ctx_txd, tx_id);\n+\t\t\tAVF_DUMP_TX_DESC(txq, &txr[tx_id], tx_id);\n \t\t\ttxe->last_id = tx_last;\n \t\t\ttx_id = txe->next_id;\n \t\t\ttxe = txn;\ndiff --git a/drivers/net/avf/avf_vchnl.c b/drivers/net/avf/avf_vchnl.c\nindex fa71014e1..fd90cc2c3 100644\n--- a/drivers/net/avf/avf_vchnl.c\n+++ b/drivers/net/avf/avf_vchnl.c\n@@ -69,7 +69,6 @@ avf_execute_vf_cmd(struct avf_adapter *adapter, struct avf_cmd_info *args)\n {\n \tstruct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);\n \tstruct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);\n-\tstruct avf_arq_event_info event_info;\n \tenum avf_status_code ret;\n \tint err = 0;\n \tint i = 0;\n@@ -600,7 +599,6 @@ avf_config_irq_map(struct avf_adapter *adapter)\n \tstruct virtchnl_irq_map_info *map_info;\n \tstruct virtchnl_vector_map *vecmap;\n \tstruct avf_cmd_info args;\n-\tuint32_t vector_id;\n \tint len, i, err;\n \n \tlen = sizeof(struct virtchnl_irq_map_info) +\n", "prefixes": [ "v4", "1/3" ] }