Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44131/?format=api
{ "id": 44131, "url": "http://patches.dpdk.org/api/patches/44131/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535727232-44836-1-git-send-email-alejandro.lucero@netronome.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535727232-44836-1-git-send-email-alejandro.lucero@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535727232-44836-1-git-send-email-alejandro.lucero@netronome.com", "date": "2018-08-31T14:53:52", "name": "[17.11] mem: fix max DMA maskbit size", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "be1f1c9af17a0e59c65b5f5d8b323eab091b1002", "submitter": { "id": 270, "url": "http://patches.dpdk.org/api/people/270/?format=api", "name": "Alejandro Lucero", "email": "alejandro.lucero@netronome.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535727232-44836-1-git-send-email-alejandro.lucero@netronome.com/mbox/", "series": [ { "id": 1142, "url": "http://patches.dpdk.org/api/series/1142/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1142", "date": "2018-08-31T14:53:52", "name": "[17.11] mem: fix max DMA maskbit size", "version": 1, "mbox": "http://patches.dpdk.org/series/1142/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/44131/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/44131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A1BC8E73;\n\tFri, 31 Aug 2018 16:54:48 +0200 (CEST)", "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 782968E58;\n\tFri, 31 Aug 2018 16:54:46 +0200 (CEST)", "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw7VErrZw044874; Fri, 31 Aug 2018 15:53:53 +0100", "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w7VErqCP044873;\n\tFri, 31 Aug 2018 15:53:53 +0100" ], "From": "Alejandro Lucero <alejandro.lucero@netronome.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, anatoly.burakov@intel.com, echaudro@redhat.com", "Date": "Fri, 31 Aug 2018 15:53:52 +0100", "Message-Id": "<1535727232-44836-1-git-send-email-alejandro.lucero@netronome.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH 17.11] mem: fix max DMA maskbit size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The sanity check inside rte_eal_check_dma_mask is using 47 bits as\nthe maximum size. It turns out there are some IOMMU hardware reporting\n48 bits precluding the IOVA VA mode to be enabled.\n\nIt is harmless to raise the maximum mask size to 63 bits.\n\nThis patch also removes any reference to unused X86_VA_WIDTH.\n\nFixes: 3a80bc50c949 (\"mem: add function for checking memsegs IOVAs addresses\")\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/bus/pci/linux/pci.c | 1 -\n lib/librte_eal/common/eal_common_memory.c | 5 -----\n 2 files changed, 6 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex c81ed50..44440f2 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -583,7 +583,6 @@\n {\n #define VTD_CAP_MGAW_SHIFT\t16\n #define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n-#define X86_VA_WIDTH 47 /* From Documentation/x86/x86_64/mm.txt */\n \tstruct rte_pci_addr *addr = &dev->addr;\n \tchar filename[PATH_MAX];\n \tFILE *fp;\ndiff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 00ab393..a0922f1 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -109,13 +109,8 @@\n \t}\n }\n \n-#if defined(RTE_ARCH_X86)\n-#define X86_VA_WIDTH 47 /* From Documentation/x86/x86_64/mm.txt */\n-#define MAX_DMA_MASK_BITS X86_VA_WIDTH\n-#else\n /* 63 bits is good enough for a sanity check */\n #define MAX_DMA_MASK_BITS 63\n-#endif\n \n /* check memseg iovas are within the required range based on dma mask */\n int\n", "prefixes": [ "17.11" ] }