Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43811/?format=api
{ "id": 43811, "url": "http://patches.dpdk.org/api/patches/43811/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535026093-101872-2-git-send-email-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535026093-101872-2-git-send-email-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535026093-101872-2-git-send-email-ciara.power@intel.com", "date": "2018-08-23T12:08:03", "name": "[01/11] telemetry: initial telemetry infrastructure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f9b9275b9722555a5646b1dc89953d3f7434d3f", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Ciara Power", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535026093-101872-2-git-send-email-ciara.power@intel.com/mbox/", "series": [ { "id": 1038, "url": "http://patches.dpdk.org/api/series/1038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1038", "date": "2018-08-23T12:08:02", "name": "introduce telemetry library", "version": 1, "mbox": "http://patches.dpdk.org/series/1038/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43811/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 95BAF4C95;\n\tThu, 23 Aug 2018 14:08:29 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 4BD2E2BF7\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 14:08:26 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2018 05:08:25 -0700", "from silpixa00399503.ir.intel.com ([10.237.222.102])\n\tby fmsmga005.fm.intel.com with ESMTP; 23 Aug 2018 05:08:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,278,1531810800\"; d=\"scan'208\";a=\"256613827\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "harry.van.haaren@intel.com, brian.archbold@intel.com,\n\temma.kenny@intel.com, ciara.power@intel.com", "Cc": "dev@dpdk.org", "Date": "Thu, 23 Aug 2018 13:08:03 +0100", "Message-Id": "<1535026093-101872-2-git-send-email-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>", "References": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds the infrastructure and initial code for the\ntelemetry library.\n\nA virtual device is used for telemetry, which is included in\nthis patch. To use telemetry, a command-line argument must be\nused - \"--vdev=telemetry\".\n\nControl threads are used to get CPU cycles for telemetry, which\nare configured in this patch also.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nSigned-off-by: Brian Archbold <brian.archbold@intel.com>\n---\n config/common_base | 5 +\n drivers/Makefile | 3 +\n drivers/meson.build | 3 +-\n drivers/telemetry/Makefile | 8 ++\n drivers/telemetry/meson.build | 6 ++\n drivers/telemetry/telemetry/Makefile | 26 +++++\n drivers/telemetry/telemetry/meson.build | 5 +\n .../telemetry/rte_pmd_telemetry_version.map | 9 ++\n drivers/telemetry/telemetry/telemetry_driver.c | 40 ++++++++\n lib/Makefile | 2 +\n lib/librte_telemetry/Makefile | 26 +++++\n lib/librte_telemetry/meson.build | 7 ++\n lib/librte_telemetry/rte_telemetry.c | 108 +++++++++++++++++++++\n lib/librte_telemetry/rte_telemetry.h | 40 ++++++++\n lib/librte_telemetry/rte_telemetry_internal.h | 32 ++++++\n lib/librte_telemetry/rte_telemetry_version.map | 6 ++\n lib/meson.build | 2 +-\n mk/rte.app.mk | 2 +\n 18 files changed, 328 insertions(+), 2 deletions(-)\n create mode 100644 drivers/telemetry/Makefile\n create mode 100644 drivers/telemetry/meson.build\n create mode 100644 drivers/telemetry/telemetry/Makefile\n create mode 100644 drivers/telemetry/telemetry/meson.build\n create mode 100644 drivers/telemetry/telemetry/rte_pmd_telemetry_version.map\n create mode 100644 drivers/telemetry/telemetry/telemetry_driver.c\n create mode 100644 lib/librte_telemetry/Makefile\n create mode 100644 lib/librte_telemetry/meson.build\n create mode 100644 lib/librte_telemetry/rte_telemetry.c\n create mode 100644 lib/librte_telemetry/rte_telemetry.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_internal.h\n create mode 100644 lib/librte_telemetry/rte_telemetry_version.map", "diff": "diff --git a/config/common_base b/config/common_base\nindex 4bcbaf9..682f8bf 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -716,6 +716,11 @@ CONFIG_RTE_LIBRTE_HASH=y\n CONFIG_RTE_LIBRTE_HASH_DEBUG=n\n \n #\n+# Compile librte_telemetry\n+#\n+CONFIG_RTE_LIBRTE_TELEMETRY=y\n+\n+#\n # Compile librte_efd\n #\n CONFIG_RTE_LIBRTE_EFD=y\ndiff --git a/drivers/Makefile b/drivers/Makefile\nindex 7566076..2238290 100644\n--- a/drivers/Makefile\n+++ b/drivers/Makefile\n@@ -21,5 +21,8 @@ DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event\n DEPDIRS-event := common bus mempool net\n DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw\n DEPDIRS-raw := common bus mempool net event\n+DIRS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += telemetry\n+DEPDIRS-telemetry := common bus mempool\n+\n \n include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex f94e2fe..d38f22f 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -9,7 +9,8 @@ driver_classes = ['common',\n \t 'crypto', # depends on common, bus and mempool (net in future).\n \t 'compress', # depends on common, bus, mempool.\n \t 'event', # depends on common, bus, mempool and net.\n-\t 'raw'] # depends on common, bus, mempool, net and event.\n+\t 'raw', # depends on common, bus, mempool, net and event.\n+\t 'telemetry'] # depends on common, bus, and mempool.\n \n default_cflags = machine_args\n if cc.has_argument('-Wno-format-truncation')\ndiff --git a/drivers/telemetry/Makefile b/drivers/telemetry/Makefile\nnew file mode 100644\nindex 0000000..86b0342\n--- /dev/null\n+++ b/drivers/telemetry/Makefile\n@@ -0,0 +1,8 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+DIRS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += telemetry\n+\n+include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/telemetry/meson.build b/drivers/telemetry/meson.build\nnew file mode 100644\nindex 0000000..b7eb791\n--- /dev/null\n+++ b/drivers/telemetry/meson.build\n@@ -0,0 +1,6 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+drivers = ['telemetry']\n+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'\n+driver_name_fmt = 'rte_pmd_@0@'\ndiff --git a/drivers/telemetry/telemetry/Makefile b/drivers/telemetry/telemetry/Makefile\nnew file mode 100644\nindex 0000000..e9d98f1\n--- /dev/null\n+++ b/drivers/telemetry/telemetry/Makefile\n@@ -0,0 +1,26 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+# library name\n+LIB = librte_pmd_telemetry.a\n+\n+# build flags\n+CFLAGS += -O3\n+CFLAGS += $(WERROR_FLAGS)\n+\n+LDLIBS += -lrte_eal -lrte_mbuf\n+LDLIBS += -lrte_telemetry\n+LDLIBS += -lrte_bus_vdev\n+\n+# versioning export map\n+EXPORT_MAP := rte_pmd_telemetry_version.map\n+\n+# library version\n+LIBABIVER := 1\n+\n+# library source files\n+SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := telemetry_driver.c\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/telemetry/telemetry/meson.build b/drivers/telemetry/telemetry/meson.build\nnew file mode 100644\nindex 0000000..baebcab\n--- /dev/null\n+++ b/drivers/telemetry/telemetry/meson.build\n@@ -0,0 +1,5 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+sources = files('telemetry_driver.c')\n+deps += ['telemetry', 'bus_pci', 'bus_vdev']\ndiff --git a/drivers/telemetry/telemetry/rte_pmd_telemetry_version.map b/drivers/telemetry/telemetry/rte_pmd_telemetry_version.map\nnew file mode 100644\nindex 0000000..a73e0f2\n--- /dev/null\n+++ b/drivers/telemetry/telemetry/rte_pmd_telemetry_version.map\n@@ -0,0 +1,9 @@\n+DPDK_18.05 {\n+\tglobal:\n+\n+\ttelemetry_probe;\n+\ttelemetry_remove;\n+\n+\tlocal: *;\n+\n+};\ndiff --git a/drivers/telemetry/telemetry/telemetry_driver.c b/drivers/telemetry/telemetry/telemetry_driver.c\nnew file mode 100644\nindex 0000000..c56f60c\n--- /dev/null\n+++ b/drivers/telemetry/telemetry/telemetry_driver.c\n@@ -0,0 +1,40 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <stdio.h>\n+\n+#include <rte_telemetry.h>\n+#include <rte_malloc.h>\n+#include <rte_bus_vdev.h>\n+#include <rte_lcore.h>\n+\n+static int\n+telemetry_probe(struct rte_vdev_device *vdev)\n+{\n+\tint ret;\n+\n+\tRTE_SET_USED(vdev);\n+\tret = rte_telemetry_init(rte_socket_id());\n+\tif (ret < 0) {\n+\t\tprintf(\"Error - Telemetry initialisation failed\\n\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+telemetry_remove(struct rte_vdev_device *vdev)\n+{\n+\tconst char *name;\n+\tname = rte_vdev_device_name(vdev);\n+\tprintf(\"Uninitialising the device: %s\\n\", name);\n+\treturn 0;\n+}\n+\n+static struct rte_vdev_driver pmd_telemetry_drv = {\n+\t.probe = telemetry_probe,\n+\t.remove = telemetry_remove\n+};\n+\n+RTE_PMD_REGISTER_VDEV(telemetry, pmd_telemetry_drv);\ndiff --git a/lib/Makefile b/lib/Makefile\nindex afa604e..8cbd035 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -105,6 +105,8 @@ DEPDIRS-librte_gso := librte_eal librte_mbuf librte_ethdev librte_net\n DEPDIRS-librte_gso += librte_mempool\n DIRS-$(CONFIG_RTE_LIBRTE_BPF) += librte_bpf\n DEPDIRS-librte_bpf := librte_eal librte_mempool librte_mbuf librte_ethdev\n+DIRS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += librte_telemetry\n+DEPDIRS-librte_telemetry := librte_eal librte_metrics librte_ethdev\n \n ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)\n DIRS-$(CONFIG_RTE_LIBRTE_KNI) += librte_kni\ndiff --git a/lib/librte_telemetry/Makefile b/lib/librte_telemetry/Makefile\nnew file mode 100644\nindex 0000000..bda3788\n--- /dev/null\n+++ b/lib/librte_telemetry/Makefile\n@@ -0,0 +1,26 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+# library name\n+LIB = librte_telemetry.a\n+\n+CFLAGS += -O3\n+CFLAGS += -I$(SRCDIR)\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+\n+LDLIBS += -lrte_eal -lrte_ethdev\n+LDLIBS += -lrte_metrics\n+\n+EXPORT_MAP := rte_telemetry_version.map\n+\n+LIBABIVER := 1\n+\n+# library source files\n+SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := rte_telemetry.c\n+\n+# export include files\n+SYMLINK-$(CONFIG_RTE_LIBRTE_TELEMETRY)-include := rte_telemetry.h\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build\nnew file mode 100644\nindex 0000000..7716076\n--- /dev/null\n+++ b/lib/librte_telemetry/meson.build\n@@ -0,0 +1,7 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Intel Corporation\n+\n+sources = files('rte_telemetry.c')\n+headers = files('rte_telemetry.h', 'rte_telemetry_internal.h')\n+deps += ['metrics', 'ethdev']\n+cflags += '-DALLOW_EXPERIMENTAL_API'\ndiff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c\nnew file mode 100644\nindex 0000000..8d7b0e3\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry.c\n@@ -0,0 +1,108 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <unistd.h>\n+\n+#include <rte_eal.h>\n+#include <rte_ethdev.h>\n+#include <rte_metrics.h>\n+\n+#include \"rte_telemetry.h\"\n+#include \"rte_telemetry_internal.h\"\n+\n+#define SLEEP_TIME 10\n+\n+static telemetry_impl *static_telemetry;\n+\n+static int32_t\n+rte_telemetry_run(void *userdata)\n+{\n+\tstruct telemetry_impl *telemetry = (struct telemetry_impl *)userdata;\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - TELEMETRY could not be \"\n+\t\t\t\"initialised\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+*rte_telemetry_run_thread_func(void *userdata)\n+{\n+\tint ret;\n+\tstruct telemetry_impl *telemetry = (struct telemetry_impl *)userdata;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - %s passed a NULL instance\\n\",\n+\t\t\t__func__);\n+\t\tpthread_exit(0);\n+\t}\n+\n+\twhile (telemetry->thread_status) {\n+\t\trte_telemetry_run(telemetry);\n+\t\tret = usleep(SLEEP_TIME);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Calling thread could not be\"\n+\t\t\t\t\" put to sleep\\n\");\n+\t}\n+\tpthread_exit(0);\n+}\n+\n+int32_t\n+rte_telemetry_init(uint32_t socket_id)\n+{\n+\tint ret;\n+\tpthread_attr_t attr;\n+\tconst char *telemetry_ctrl_thread = \"telemetry\";\n+\n+\tif (static_telemetry) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - TELEMETRY structure already \"\n+\t\t\t\"initialised\\n\");\n+\t\treturn -EALREADY;\n+\t}\n+\n+\tstatic_telemetry = calloc(1, sizeof(struct telemetry_impl));\n+\tif (!static_telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Memory could not be allocated\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tstatic_telemetry->socket_id = socket_id;\n+\trte_metrics_init(static_telemetry->socket_id);\n+\tpthread_attr_init(&attr);\n+\tret = rte_ctrl_thread_create(&static_telemetry->thread_id,\n+\t\ttelemetry_ctrl_thread, &attr, rte_telemetry_run_thread_func,\n+\t\t(void *)static_telemetry);\n+\tstatic_telemetry->thread_status = 1;\n+\tif (ret < 0) {\n+\t\tret = rte_telemetry_cleanup();\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - TELEMETRY cleanup failed\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\treturn 0;\n+}\n+\n+int32_t\n+rte_telemetry_cleanup(void)\n+{\n+\tstruct telemetry_impl *telemetry = static_telemetry;\n+\ttelemetry->thread_status = 0;\n+\tpthread_join(telemetry->thread_id, NULL);\n+\tfree(telemetry);\n+\tstatic_telemetry = NULL;\n+\treturn 0;\n+}\n+\n+int telemetry_log_level;\n+RTE_INIT(rte_telemetry_log_init);\n+\n+static void\n+rte_telemetry_log_init(void)\n+{\n+\ttelemetry_log_level = rte_log_register(\"lib.telemetry\");\n+\tif (telemetry_log_level >= 0)\n+\t\trte_log_set_level(telemetry_log_level, RTE_LOG_ERR);\n+}\ndiff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h\nnew file mode 100644\nindex 0000000..b691845\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry.h\n@@ -0,0 +1,40 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <stdint.h>\n+\n+#ifndef _RTE_TELEMETRY_H_\n+#define _RTE_TELEMETRY_H_\n+\n+/**\n+ * Get the telemetry_impl structure device pointer initialised.\n+ *\n+ * @param socket_id\n+ * Unsigned integer representing the socket id to be used\n+ * for the telemetry structure.\n+ *\n+ * @return\n+ * 0 on successful initialisation.\n+ * @return\n+ * -ENOMEM on memory allocation error\n+ * @return\n+ * -EPERM on unknown error failure\n+ * @return\n+ * -EALREADY if Telemetry is already initialised.\n+ */\n+int32_t\n+rte_telemetry_init(uint32_t socket_id);\n+\n+/**\n+ * Clean up and free memory.\n+ *\n+ * @return\n+ * 0 on success\n+ * @return\n+ * -EPERM on failure\n+ */\n+int32_t\n+rte_telemetry_cleanup(void);\n+\n+#endif\ndiff --git a/lib/librte_telemetry/rte_telemetry_internal.h b/lib/librte_telemetry/rte_telemetry_internal.h\nnew file mode 100644\nindex 0000000..4e810a8\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry_internal.h\n@@ -0,0 +1,32 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <rte_log.h>\n+\n+#ifndef _RTE_TELEMETRY_INTERNAL_H_\n+#define _RTE_TELEMETRY_INTERNAL_H_\n+\n+/* Logging Macros */\n+extern int telemetry_log_level;\n+\n+#define TELEMETRY_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ##level, telemetry_log_level, \"%s(): \"fmt \"\\n\", \\\n+\t\t__func__, ##args)\n+\n+#define TELEMETRY_LOG_ERR(fmt, args...) \\\n+\tTELEMETRY_LOG(ERR, fmt, ## args)\n+\n+#define TELEMETRY_LOG_WARN(fmt, args...) \\\n+\tTELEMETRY_LOG(WARNING, fmt, ## args)\n+\n+#define TELEMETRY_LOG_INFO(fmt, args...) \\\n+\tTELEMETRY_LOG(INFO, fmt, ## args)\n+\n+typedef struct telemetry_impl {\n+\tpthread_t thread_id;\n+\tint thread_status;\n+\tuint32_t socket_id;\n+} telemetry_impl;\n+\n+#endif\ndiff --git a/lib/librte_telemetry/rte_telemetry_version.map b/lib/librte_telemetry/rte_telemetry_version.map\nnew file mode 100644\nindex 0000000..efd437d\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry_version.map\n@@ -0,0 +1,6 @@\n+DPDK_18.05 {\n+\tglobal:\n+\n+\trte_telemetry_init;\n+\tlocal: *;\n+};\ndiff --git a/lib/meson.build b/lib/meson.build\nindex eb91f10..fc84b2f 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -24,7 +24,7 @@ libraries = [ 'compat', # just a header, used for versioning\n \t# add pkt framework libs which use other libs from above\n \t'port', 'table', 'pipeline',\n \t# flow_classify lib depends on pkt framework table lib\n-\t'flow_classify', 'bpf']\n+\t'flow_classify', 'bpf', 'telemetry']\n \n default_cflags = machine_args\n if cc.has_argument('-Wno-format-truncation')\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex de33883..8551191 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -80,6 +80,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) += -lrte_security\n _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += -lrte_compressdev\n _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev\n _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV) += -lrte_rawdev\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += -lrte_metrics -lrte_telemetry\n _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool\n _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring\n@@ -164,6 +165,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += -lrte_pmd_softnic\n endif\n _LDLIBS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += -lrte_pmd_sfc_efx\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lrte_pmd_szedata2 -lsze2\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += -lrte_pmd_telemetry\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += -lrte_pmd_tap\n _LDLIBS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += -lrte_pmd_thunderx_nicvf\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) += -lrte_pmd_vdev_netvsc\n", "prefixes": [ "01/11" ] }