Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43419/?format=api
{ "id": 43419, "url": "http://patches.dpdk.org/api/patches/43419/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1532684420-29500-3-git-send-email-reshma.pattan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1532684420-29500-3-git-send-email-reshma.pattan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1532684420-29500-3-git-send-email-reshma.pattan@intel.com", "date": "2018-07-27T09:40:12", "name": "[v6,02/10] autotest: fix invalid code on reports", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0b9d275bc6aa79edb1b713badbe611bf0891cc66", "submitter": { "id": 70, "url": "http://patches.dpdk.org/api/people/70/?format=api", "name": "Pattan, Reshma", "email": "reshma.pattan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1532684420-29500-3-git-send-email-reshma.pattan@intel.com/mbox/", "series": [ { "id": 803, "url": "http://patches.dpdk.org/api/series/803/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=803", "date": "2018-07-27T09:40:10", "name": "Make unit tests great again", "version": 6, "mbox": "http://patches.dpdk.org/series/803/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43419/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43419/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6123D4C8C;\n\tFri, 27 Jul 2018 11:40:32 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id B0A0344CF;\n\tFri, 27 Jul 2018 11:40:28 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jul 2018 02:40:28 -0700", "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Jul 2018 02:40:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,408,1526367600\"; d=\"scan'208\";a=\"78302940\"", "From": "Reshma Pattan <reshma.pattan@intel.com>", "To": "thomas@monjalon.net,\n\tdev@dpdk.org", "Cc": "anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com,\n\tstable@dpdk.org", "Date": "Fri, 27 Jul 2018 10:40:12 +0100", "Message-Id": "<1532684420-29500-3-git-send-email-reshma.pattan@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1532684420-29500-1-git-send-email-reshma.pattan@intel.com>", "References": "<1532684420-29500-1-git-send-email-reshma.pattan@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 02/10] autotest: fix invalid code on reports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Anatoly Burakov <anatoly.burakov@intel.com>\n\nThere are no reports defined for any test, so this codepath was\nnever triggered, but it's still wrong because it's referencing\nvariables that aren't there. Fix it by passing target into the\ntest function, and reference correct log variable.\n\nFixes: e2cc79b75d9f (\"app: rework autotest.py\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n test/test/autotest_runner.py | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py\nindex b09b57876..bdc32da5d 100644\n--- a/test/test/autotest_runner.py\n+++ b/test/test/autotest_runner.py\n@@ -41,7 +41,7 @@ def wait_prompt(child):\n # quite a bit of effort to make it work).\n \n \n-def run_test_group(cmdline, test_group):\n+def run_test_group(cmdline, target, test_group):\n results = []\n child = None\n start_time = time.time()\n@@ -128,14 +128,15 @@ def run_test_group(cmdline, test_group):\n # make a note when the test was finished\n end_time = time.time()\n \n+ log = logfile.getvalue()\n+\n # append test data to the result tuple\n- result += (test[\"Name\"], end_time - start_time,\n- logfile.getvalue())\n+ result += (test[\"Name\"], end_time - start_time, log)\n \n # call report function, if any defined, and supply it with\n # target and complete log for test run\n if test[\"Report\"]:\n- report = test[\"Report\"](self.target, log)\n+ report = test[\"Report\"](target, log)\n \n # append report to results tuple\n result += (report,)\n@@ -343,6 +344,7 @@ def run_all_tests(self):\n for test_group in self.parallel_test_groups:\n result = pool.apply_async(run_test_group,\n [self.__get_cmdline(test_group),\n+ self.target,\n test_group])\n results.append(result)\n \n@@ -367,7 +369,7 @@ def run_all_tests(self):\n # run non_parallel tests. they are run one by one, synchronously\n for test_group in self.non_parallel_test_groups:\n group_result = run_test_group(\n- self.__get_cmdline(test_group), test_group)\n+ self.__get_cmdline(test_group), self.target, test_group)\n \n self.__process_results(group_result)\n \n", "prefixes": [ "v6", "02/10" ] }