Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43044/?format=api
{ "id": 43044, "url": "http://patches.dpdk.org/api/patches/43044/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/ba5990a602d3e89cb2acc58e60b467eb0afe1d73.1531485955.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<ba5990a602d3e89cb2acc58e60b467eb0afe1d73.1531485955.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ba5990a602d3e89cb2acc58e60b467eb0afe1d73.1531485955.git.anatoly.burakov@intel.com", "date": "2018-07-13T12:47:58", "name": "[v3,2/8] ipc: add support for no-shconf mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77f48fa98208af56c59533c8edd61e4abdaa3f23", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/ba5990a602d3e89cb2acc58e60b467eb0afe1d73.1531485955.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 564, "url": "http://patches.dpdk.org/api/series/564/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=564", "date": "2018-07-13T12:47:56", "name": "Support running DPDK without hugetlbfs mountpoint", "version": 3, "mbox": "http://patches.dpdk.org/series/564/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43044/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4947232A5;\n\tFri, 13 Jul 2018 14:48:15 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id BDFB52C18\n\tfor <dev@dpdk.org>; Fri, 13 Jul 2018 14:48:09 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jul 2018 05:48:07 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga005.fm.intel.com with ESMTP; 13 Jul 2018 05:48:05 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw6DCm43x016833; Fri, 13 Jul 2018 13:48:04 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w6DCm4Lq006243;\n\tFri, 13 Jul 2018 13:48:04 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w6DCm4AY006239;\n\tFri, 13 Jul 2018 13:48:04 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,347,1526367600\"; d=\"scan'208\";a=\"245000235\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "ray.kinsella@intel.com, kuralamudhan.ramakrishnan@intel.com,\n\tlouise.m.daly@intel.com, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net", "Date": "Fri, 13 Jul 2018 13:47:58 +0100", "Message-Id": "<ba5990a602d3e89cb2acc58e60b467eb0afe1d73.1531485955.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1531485955.git.anatoly.burakov@intel.com>", "<cover.1531485955.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1531485955.git.anatoly.burakov@intel.com>", "<cover.1531477505.git.anatoly.burakov@intel.com>\n\t<cover.1531485955.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 2/8] ipc: add support for no-shconf mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "IPC is an inter-process communication mechanism. Since no secondaries\ncan ever be expected to run in no-shconf mode, IPC will be useless, so\ndo not enable it in the first place. In the interests of API usage\nconvenience, we will still allow registering callbacks, but obviously\nthey won't ever be triggered.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n RFC->v1:\n - Use --no-shconf only\n\n lib/librte_eal/common/eal_common_proc.c | 25 +++++++++++++++++++++++++\n 1 file changed, 25 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex f010ef59e..c19b4b406 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -626,6 +626,14 @@ rte_mp_channel_init(void)\n \tint dir_fd;\n \tpthread_t mp_handle_tid, async_reply_handle_tid;\n \n+\t/* in no shared files mode, we do not have secondary processes support,\n+\t * so no need to initialize IPC.\n+\t */\n+\tif (internal_config.no_shconf) {\n+\t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC will be disabled\\n\");\n+\t\treturn 0;\n+\t}\n+\n \t/* create filter path */\n \tcreate_socket_path(\"*\", path, sizeof(path));\n \tstrlcpy(mp_filter, basename(path), sizeof(mp_filter));\n@@ -988,6 +996,12 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,\n \n \tif (check_input(req) == false)\n \t\treturn -1;\n+\n+\tif (internal_config.no_shconf) {\n+\t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC is disabled\\n\");\n+\t\treturn 0;\n+\t}\n+\n \tif (gettimeofday(&now, NULL) < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Faile to get current time\\n\");\n \t\trte_errno = errno;\n@@ -1072,6 +1086,12 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,\n \n \tif (check_input(req) == false)\n \t\treturn -1;\n+\n+\tif (internal_config.no_shconf) {\n+\t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC is disabled\\n\");\n+\t\treturn 0;\n+\t}\n+\n \tif (gettimeofday(&now, NULL) < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Faile to get current time\\n\");\n \t\trte_errno = errno;\n@@ -1213,5 +1233,10 @@ rte_mp_reply(struct rte_mp_msg *msg, const char *peer)\n \t\treturn -1;\n \t}\n \n+\tif (internal_config.no_shconf) {\n+\t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC is disabled\\n\");\n+\t\treturn 0;\n+\t}\n+\n \treturn mp_send(msg, peer, MP_REP);\n }\n", "prefixes": [ "v3", "2/8" ] }