Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42737,
    "url": "http://patches.dpdk.org/api/patches/42737/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180710155743.14448-10-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180710155743.14448-10-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180710155743.14448-10-adrien.mazarguil@6wind.com",
    "date": "2018-07-10T16:04:58",
    "name": "[v5,09/10] net/mlx5: add parameter for port representors",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f230866a27b2033783c73db3373adc59b0732b0f",
    "submitter": {
        "id": 165,
        "url": "http://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patches.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180710155743.14448-10-adrien.mazarguil@6wind.com/mbox/",
    "series": [
        {
            "id": 501,
            "url": "http://patches.dpdk.org/api/series/501/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=501",
            "date": "2018-07-10T16:04:39",
            "name": "net/mlx5: add port representor support",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/501/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/42737/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/42737/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D11721B4B6;\n\tTue, 10 Jul 2018 18:05:22 +0200 (CEST)",
            "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 17BB21B432\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 18:05:15 +0200 (CEST)",
            "by mail-wm0-f68.google.com with SMTP id z13-v6so24944486wma.5\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 09:05:15 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\ts17-v6sm13747678wmc.34.2018.07.10.09.05.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 10 Jul 2018 09:05:14 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=4qelGfXDR0NYqw3vkex8nX1rMGAhfI/j9iDIJOyh370=;\n\tb=vMvyEuUqfyZKKilPgKV2A1kSJ+qk6znFDtL2SmHDnQ/AFNduRbmnT2+gHqejZoSkDV\n\taHUQRAjtjtuOLzPAyiVkxi7txcD12Ht793466wwlf0v2in91DAEqTBQYxy2iBEh44jpl\n\tOyM/5Ne3xLfB9tA5b1BOqhZS+ZifNThhO9o/wzu9qQBpr/iOFjgLFO9cvwo2rkY7+BlN\n\tZs+rEGy27OKQUEJsyfjXBVhgcZBgzlv/HO1UKhaK/pYQBOjyrCV/1lcwvRq7D+YWR6H7\n\tcvtp8oWkQV9gANOUhwmHbaPojohUgbkfwz1soy3vc6YO1PbtV3HflXIY+FdGN6i73daL\n\t9xVg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=4qelGfXDR0NYqw3vkex8nX1rMGAhfI/j9iDIJOyh370=;\n\tb=Yt4rrYSCPjRde919yGJiPeF7wN0nuDg+wIw7GJnnBBN1OuOCoYzY+CAvsIpF18ZxPA\n\tslq8V1x6CS2rCWgisSv6PeAwx3N2ST8L2C7fDK3+x7wPq7Y6uS2+kvLkWIDYazGNjnf6\n\tRLZvHAI8dHfDm2Tkkp65G8mssQurWsTcv9H7HjVXg04sunRlpBUrYT9GkCz4lSOlWAVC\n\tja5bS+H+4cgTdmEReq2c+zY81CS9PFV7+Gwa/O9aKDvhdUvJLOzrcSwP7ycGc1Li+/yW\n\tj9jnrp1Sfyny8EN3b7hgMQalvlEazr5QY5fBt3Eo1+dp2GU50iGs5qlw6wNFpN5ynpZZ\n\t8eqg==",
        "X-Gm-Message-State": "AOUpUlH/LLCYrmILks6P4ra8eGpcaE8jHbWvldSKmNYF1ARRrZyJ4Mzm\n\tREoB76WGEtgdMUvnCeRnOk5GHQ==",
        "X-Google-Smtp-Source": "AAOMgpdcPqI58HCCplO803zI/qn1ANWoVJtzesZbZZ65EG6ZU6RsrqvBp3R9B/echQh72+1BegjkUg==",
        "X-Received": "by 2002:a1c:f415:: with SMTP id\n\tz21-v6mr3243811wma.80.1531238714808; \n\tTue, 10 Jul 2018 09:05:14 -0700 (PDT)",
        "Date": "Tue, 10 Jul 2018 18:04:58 +0200",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "Shahaf Shuler <shahafs@mellanox.com>",
        "Cc": "dev@dpdk.org",
        "Message-ID": "<20180710155743.14448-10-adrien.mazarguil@6wind.com>",
        "References": "<20180705083934.5535-1-adrien.mazarguil@6wind.com>\n\t<20180710155743.14448-1-adrien.mazarguil@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=us-ascii",
        "Content-Disposition": "inline",
        "In-Reply-To": "<20180710155743.14448-1-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH v5 09/10] net/mlx5: add parameter for port\n\trepresentors",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Prior to this patch, all port representors detected on a given device were\nprobed and Ethernet devices instantiated for each of them.\n\nThis patch adds support for the standard \"representor\" parameter, which\nimplies that port representors are not probed by default anymore, except\nfor the list provided through device arguments.\n\n(Patch based on prior work from Yuanhan Liu)\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nReviewed-by: Xueming Li <xuemingl@mellanox.com>\n--\nv3 changes:\n\n- Adapted representor detection to the reworked mlx5_dev_spawn().\n\nv2 changes:\n\n- Added error message for when rte_eth_devargs_parse() fails.\n---\n doc/guides/nics/mlx5.rst                | 12 ++++++++\n doc/guides/prog_guide/poll_mode_drv.rst |  2 ++\n drivers/net/mlx5/mlx5.c                 | 41 ++++++++++++++++++++++++++--\n 3 files changed, 52 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 7dd9c1c5e..0d0d21727 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -392,6 +392,18 @@ Run-time configuration\n \n   Disabled by default.\n \n+- ``representor`` parameter [list]\n+\n+  This parameter can be used to instantiate DPDK Ethernet devices from\n+  existing port (or VF) representors configured on the device.\n+\n+  It is a standard parameter whose format is described in\n+  :ref:`ethernet_device_standard_device_arguments`.\n+\n+  For instance, to probe port representors 0 through 2::\n+\n+    representor=[0-2]\n+\n Firmware configuration\n ~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst\nindex 4b69f6cbe..b2cf48354 100644\n--- a/doc/guides/prog_guide/poll_mode_drv.rst\n+++ b/doc/guides/prog_guide/poll_mode_drv.rst\n@@ -360,6 +360,8 @@ Ethernet Device API\n \n The Ethernet device API exported by the Ethernet PMDs is described in the *DPDK API Reference*.\n \n+.. _ethernet_device_standard_device_arguments:\n+\n Ethernet Device Standard Device Arguments\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 6592480bf..12a77afa8 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -92,6 +92,9 @@\n /* Activate Netlink support in VF mode. */\n #define MLX5_VF_NL_EN \"vf_nl_en\"\n \n+/* Select port representors to instantiate. */\n+#define MLX5_REPRESENTOR \"representor\"\n+\n #ifndef HAVE_IBV_MLX5_MOD_MPW\n #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2)\n #define MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW (1 << 3)\n@@ -443,6 +446,9 @@ mlx5_args_check(const char *key, const char *val, void *opaque)\n \tstruct mlx5_dev_config *config = opaque;\n \tunsigned long tmp;\n \n+\t/* No-op, port representors are processed in mlx5_dev_spawn(). */\n+\tif (!strcmp(MLX5_REPRESENTOR, key))\n+\t\treturn 0;\n \terrno = 0;\n \ttmp = strtoul(val, NULL, 0);\n \tif (errno) {\n@@ -515,6 +521,7 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs)\n \t\tMLX5_RX_VEC_EN,\n \t\tMLX5_L3_VXLAN_EN,\n \t\tMLX5_VF_NL_EN,\n+\t\tMLX5_REPRESENTOR,\n \t\tNULL,\n \t};\n \tstruct rte_kvargs *kvlist;\n@@ -672,7 +679,9 @@ mlx5_uar_init_secondary(struct rte_eth_dev *dev)\n  *\n  * @return\n  *   A valid Ethernet device object on success, NULL otherwise and rte_errno\n- *   is set.\n+ *   is set. The following error is defined:\n+ *\n+ *   EBUSY: device is not supposed to be spawned.\n  */\n static struct rte_eth_dev *\n mlx5_dev_spawn(struct rte_device *dpdk_dev,\n@@ -723,6 +732,26 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \tint own_domain_id = 0;\n \tunsigned int i;\n \n+\t/* Determine if this port representor is supposed to be spawned. */\n+\tif (switch_info->representor && dpdk_dev->devargs) {\n+\t\tstruct rte_eth_devargs eth_da;\n+\n+\t\terr = rte_eth_devargs_parse(dpdk_dev->devargs->args, &eth_da);\n+\t\tif (err) {\n+\t\t\trte_errno = -err;\n+\t\t\tDRV_LOG(ERR, \"failed to process device arguments: %s\",\n+\t\t\t\tstrerror(rte_errno));\n+\t\t\treturn NULL;\n+\t\t}\n+\t\tfor (i = 0; i < eth_da.nb_representor_ports; ++i)\n+\t\t\tif (eth_da.representor_ports[i] ==\n+\t\t\t    (uint16_t)switch_info->port_name)\n+\t\t\t\tbreak;\n+\t\tif (i == eth_da.nb_representor_ports) {\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n \t/* Prepare shared data between primary and secondary process. */\n \tmlx5_prepare_shared_data();\n \terrno = 0;\n@@ -1343,8 +1372,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n \t\tlist[i].eth_dev = mlx5_dev_spawn\n \t\t\t(&pci_dev->device, list[i].ibv_dev, vf, &list[i].info);\n-\t\tif (!list[i].eth_dev)\n-\t\t\tbreak;\n+\t\tif (!list[i].eth_dev) {\n+\t\t\tif (rte_errno != EBUSY)\n+\t\t\t\tbreak;\n+\t\t\t/* Device is disabled, ignore it. */\n+\t\t\tcontinue;\n+\t\t}\n \t\trestore = list[i].eth_dev->data->dev_flags;\n \t\trte_eth_copy_pci_info(list[i].eth_dev, pci_dev);\n \t\t/* Restore non-PCI flags cleared by the above call. */\n@@ -1370,6 +1403,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tret = -rte_errno;\n \t\t/* Roll back. */\n \t\twhile (i--) {\n+\t\t\tif (!list[i].eth_dev)\n+\t\t\t\tcontinue;\n \t\t\tmlx5_dev_close(list[i].eth_dev);\n \t\t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\t\t\trte_free(list[i].eth_dev->data->dev_private);\n",
    "prefixes": [
        "v5",
        "09/10"
    ]
}