Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42640,
    "url": "http://patches.dpdk.org/api/patches/42640/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531156496-1702-3-git-send-email-alejandro.lucero@netronome.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1531156496-1702-3-git-send-email-alejandro.lucero@netronome.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1531156496-1702-3-git-send-email-alejandro.lucero@netronome.com",
    "date": "2018-07-09T17:14:56",
    "name": "[2/2] net/nfp: fix live MAC changes not supported",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "cef535d0a258203acc2ccd033d56734b6e804f14",
    "submitter": {
        "id": 270,
        "url": "http://patches.dpdk.org/api/people/270/?format=api",
        "name": "Alejandro Lucero",
        "email": "alejandro.lucero@netronome.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531156496-1702-3-git-send-email-alejandro.lucero@netronome.com/mbox/",
    "series": [
        {
            "id": 477,
            "url": "http://patches.dpdk.org/api/series/477/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=477",
            "date": "2018-07-09T17:14:54",
            "name": "support MAC changes when no live changes allowed",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/477/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/42640/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/42640/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7FD3D1B058;\n\tMon,  9 Jul 2018 19:15:13 +0200 (CEST)",
            "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 517845F2B;\n\tMon,  9 Jul 2018 19:15:08 +0200 (CEST)",
            "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw69HExb0001939; Mon, 9 Jul 2018 18:14:59 +0100",
            "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w69HExjo001938;\n\tMon, 9 Jul 2018 18:14:59 +0100"
        ],
        "From": "Alejandro Lucero <alejandro.lucero@netronome.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org",
        "Date": "Mon,  9 Jul 2018 18:14:56 +0100",
        "Message-Id": "<1531156496-1702-3-git-send-email-alejandro.lucero@netronome.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1531156496-1702-1-git-send-email-alejandro.lucero@netronome.com>",
        "References": "<1531156496-1702-1-git-send-email-alejandro.lucero@netronome.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] net/nfp: fix live MAC changes not supported",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Some NFP firmwares support live changes to the MAC address, but\nthis is not always true and the firmware advertises it accordingly.\n\nThis patch checks if firmware does not support live changes and\nsets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/net/nfp/nfp_net.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex 3658696..fbe74fc 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2883,6 +2883,9 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq)\n \tether_addr_copy((struct ether_addr *)hw->mac_addr,\n \t\t\t&eth_dev->data->mac_addrs[0]);\n \n+\tif (!(hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR))\n+\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_NOLIVE_MAC_ADDR;\n+\n \tPMD_INIT_LOG(INFO, \"port %d VendorID=0x%x DeviceID=0x%x \"\n \t\t     \"mac=%02x:%02x:%02x:%02x:%02x:%02x\",\n \t\t     eth_dev->data->port_id, pci_dev->id.vendor_id,\n",
    "prefixes": [
        "2/2"
    ]
}