Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42156,
    "url": "http://patches.dpdk.org/api/patches/42156/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180703055801.45087-1-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180703055801.45087-1-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180703055801.45087-1-pablo.de.lara.guarch@intel.com",
    "date": "2018-07-03T05:58:01",
    "name": "crypto/aesni_mb: call buffer manager allocation",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5201008c37c6deaee9a0da636184bc650d844c75",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patches.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180703055801.45087-1-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [
        {
            "id": 374,
            "url": "http://patches.dpdk.org/api/series/374/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=374",
            "date": "2018-07-03T05:58:01",
            "name": "crypto/aesni_mb: call buffer manager allocation",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/374/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/42156/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/42156/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CA511BF17;\n\tTue,  3 Jul 2018 16:03:53 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 5B03C1BEF4\n\tfor <dev@dpdk.org>; Tue,  3 Jul 2018 16:03:51 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2018 07:03:47 -0700",
            "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga005.fm.intel.com with ESMTP; 03 Jul 2018 07:03:41 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,303,1526367600\"; d=\"scan'208\";a=\"242289691\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "declan.doherty@intel.com",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Tue,  3 Jul 2018 06:58:01 +0100",
        "Message-Id": "<20180703055801.45087-1-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.14.4",
        "Subject": "[dpdk-dev] [PATCH] crypto/aesni_mb: call buffer manager allocation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Instead of having a static field for the buffer manager\nMB_MGR in the queue pair structure, use the provided API\nthat allocates memory for it and store a pointer to it.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c         | 10 +++++-----\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c     | 22 ++++++++++++++++++----\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h |  2 +-\n 3 files changed, 24 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex 9ae2b54f4..cebb5318d 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -721,7 +721,7 @@ handle_completed_jobs(struct aesni_mb_qp *qp, JOB_AES_HMAC *job,\n \t\tif (processed_jobs == nb_ops)\n \t\t\tbreak;\n \n-\t\tjob = (*qp->op_fns->job.get_completed_job)(&qp->mb_mgr);\n+\t\tjob = (*qp->op_fns->job.get_completed_job)(qp->mb_mgr);\n \t}\n \n \treturn processed_jobs;\n@@ -734,7 +734,7 @@ flush_mb_mgr(struct aesni_mb_qp *qp, struct rte_crypto_op **ops,\n \tint processed_ops = 0;\n \n \t/* Flush the remaining jobs */\n-\tJOB_AES_HMAC *job = (*qp->op_fns->job.flush_job)(&qp->mb_mgr);\n+\tJOB_AES_HMAC *job = (*qp->op_fns->job.flush_job)(qp->mb_mgr);\n \n \tif (job)\n \t\tprocessed_ops += handle_completed_jobs(qp, job,\n@@ -779,14 +779,14 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t\tbreak;\n \n \t\t/* Get next free mb job struct from mb manager */\n-\t\tjob = (*qp->op_fns->job.get_next)(&qp->mb_mgr);\n+\t\tjob = (*qp->op_fns->job.get_next)(qp->mb_mgr);\n \t\tif (unlikely(job == NULL)) {\n \t\t\t/* if no free mb job structs we need to flush mb_mgr */\n \t\t\tprocessed_jobs += flush_mb_mgr(qp,\n \t\t\t\t\t&ops[processed_jobs],\n \t\t\t\t\t(nb_ops - processed_jobs) - 1);\n \n-\t\t\tjob = (*qp->op_fns->job.get_next)(&qp->mb_mgr);\n+\t\t\tjob = (*qp->op_fns->job.get_next)(qp->mb_mgr);\n \t\t}\n \n \t\tretval = set_mb_job_params(job, qp, op, &digest_idx);\n@@ -796,7 +796,7 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t}\n \n \t\t/* Submit job to multi-buffer for processing */\n-\t\tjob = (*qp->op_fns->job.submit)(&qp->mb_mgr);\n+\t\tjob = (*qp->op_fns->job.submit)(qp->mb_mgr);\n \n \t\t/*\n \t\t * If submit returns a processed job then handle it,\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\nindex 6a96d5077..f0087aeb1 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n@@ -402,6 +402,8 @@ aesni_mb_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)\n \t\tr = rte_ring_lookup(qp->name);\n \t\tif (r)\n \t\t\trte_ring_free(r);\n+\t\tif (qp->mb_mgr)\n+\t\t\tfree_mb_mgr(qp->mb_mgr);\n \t\trte_free(qp);\n \t\tdev->data->queue_pairs[qp_id] = NULL;\n \t}\n@@ -463,6 +465,7 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n {\n \tstruct aesni_mb_qp *qp = NULL;\n \tstruct aesni_mb_private *internals = dev->data->dev_private;\n+\tint ret = -1;\n \n \t/* Free memory prior to re-allocation if needed. */\n \tif (dev->data->queue_pairs[qp_id] != NULL)\n@@ -481,12 +484,20 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t\tgoto qp_setup_cleanup;\n \n \n+\tqp->mb_mgr = alloc_mb_mgr(0);\n+        if (qp->mb_mgr == NULL) {\n+\t\tret = -ENOMEM;\n+\t\tgoto qp_setup_cleanup;\n+\t}\n+\n \tqp->op_fns = &job_ops[internals->vector_mode];\n \n \tqp->ingress_queue = aesni_mb_pmd_qp_create_processed_ops_ring(qp,\n \t\t\t\"ingress\", qp_conf->nb_descriptors, socket_id);\n-\tif (qp->ingress_queue == NULL)\n+\tif (qp->ingress_queue == NULL) {\n+\t\tret = -1;\n \t\tgoto qp_setup_cleanup;\n+\t}\n \n \tqp->sess_mp = session_pool;\n \n@@ -498,14 +509,17 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t\t\t\t\"digest_mp_%u_%u\", dev->data->dev_id, qp_id);\n \n \t/* Initialise multi-buffer manager */\n-\t(*qp->op_fns->job.init_mgr)(&qp->mb_mgr);\n+\t(*qp->op_fns->job.init_mgr)(qp->mb_mgr);\n \treturn 0;\n \n qp_setup_cleanup:\n-\tif (qp)\n+\tif (qp) {\n+\t\tif (qp->mb_mgr == NULL)\n+\t\t\tfree_mb_mgr(qp->mb_mgr);\n \t\trte_free(qp);\n+\t}\n \n-\treturn -1;\n+\treturn ret;\n }\n \n /** Start queue pair */\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\nindex bad2a8743..9fb9f934b 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\n@@ -125,7 +125,7 @@ struct aesni_mb_qp {\n \t/**< Unique Queue Pair Name */\n \tconst struct aesni_mb_op_fns *op_fns;\n \t/**< Vector mode dependent pointer table of the multi-buffer APIs */\n-\tMB_MGR mb_mgr;\n+\tMB_MGR *mb_mgr;\n \t/**< Multi-buffer instance */\n \tstruct rte_ring *ingress_queue;\n        /**< Ring for placing operations ready for processing */\n",
    "prefixes": []
}