Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41986/?format=api
{ "id": 41986, "url": "http://patches.dpdk.org/api/patches/41986/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180629172738.2121-7-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180629172738.2121-7-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180629172738.2121-7-gavin.hu@arm.com", "date": "2018-06-29T17:27:38", "name": "[v14,6/6] devtools: expand meson cross compiling test coverage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7035b511ff52c883ea417207604015d48aa6e72", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180629172738.2121-7-gavin.hu@arm.com/mbox/", "series": [ { "id": 330, "url": "http://patches.dpdk.org/api/series/330/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=330", "date": "2018-06-29T17:27:32", "name": "Fix the cross compiling errors", "version": 14, "mbox": "http://patches.dpdk.org/series/330/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41986/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41986/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B62FC1B8C9;\n\tFri, 29 Jun 2018 19:28:08 +0200 (CEST)", "from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 08D751B69B;\n\tFri, 29 Jun 2018 19:27:58 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70D6F1529;\n\tFri, 29 Jun 2018 10:27:57 -0700 (PDT)", "from net-debian.shanghai.arm.com (net-debian.shanghai.arm.com\n\t[10.169.36.53])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\tB42393F5AD; Fri, 29 Jun 2018 10:27:56 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com,\n\tgavin.hu@arm.com,\n\tstable@dpdk.org", "Date": "Sat, 30 Jun 2018 01:27:38 +0800", "Message-Id": "<20180629172738.2121-7-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20180629172738.2121-1-gavin.hu@arm.com>", "References": "<20180625024913.17219-1-gavin.hu@arm.com>\n\t<20180629172738.2121-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH v14 6/6] devtools: expand meson cross compiling\n\ttest coverage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The default test script covers only default host cc compiler, either gcc or\nclang, the fix is to increase the coverage by adding one more to cover\nclang and the others for gcc.\n\nFixes: a55277a788 (\"devtools: add test script for meson builds\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Song Zhu <song.zhu@arm.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n devtools/test-meson-builds.sh | 22 ++++++++++++++--------\n 1 file changed, 14 insertions(+), 8 deletions(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 9bb5b93bd..f38304e6e 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -15,7 +15,7 @@ if command -v ninja >/dev/null 2>&1 ; then\n elif command -v ninja-build >/dev/null 2>&1 ; then\n ninja_cmd=ninja-build\n else\n- echo \"## ERROR: ninja is missing, please install...\"\n+ echo \"ERROR: ninja is not found\"\n exit 1\n fi\n \n@@ -45,10 +45,16 @@ done\n build build-x86-default -Dmachine=nehalem\n \n # enable cross compilation if gcc cross-compiler is found\n-for f in config/arm/arm*gcc ; do\n-\tc=aarch64-linux-gnu-gcc\n-\tif ! command -v $c >/dev/null 2>&1 ; then\n-\t\tcontinue\n-\tfi\n-\tbuild build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f\n-done\n+c=aarch64-linux-gnu-gcc\n+if command -v $c >/dev/null 2>&1 ; then\n+\t# compile the general v8a also for clang to increase coverage\n+\texport CC=\"ccache clang\"\n+\tbuild build-arm64-host-clang --cross-file \\\n+\t\tconfig/arm/arm64_armv8_linuxapp_gcc\n+\n+\tfor f in config/arm/arm*gcc ; do\n+\t\texport CC=\"ccache gcc\"\n+\t\tbuild build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) \\\n+\t\t\t--cross-file $f\n+\tdone\n+fi\n", "prefixes": [ "v14", "6/6" ] }