Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41283/?format=api
{ "id": 41283, "url": "http://patches.dpdk.org/api/patches/41283/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-14-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-14-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-14-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:40", "name": "[13/31] net/bnxt: code cleanup style of bnxt stats", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "bf6962157732ff80f03b2296215b115b887a28bb", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-14-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "http://patches.dpdk.org/api/series/171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/171/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41283/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 41CBF1B432;\n\tTue, 19 Jun 2018 23:31:38 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 0EE351B05D\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 95AA630C06B;\n\tTue, 19 Jun 2018 14:31:05 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 7861AAC0768;\n\tTue, 19 Jun 2018 14:31:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 95AA630C06B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443865;\n\tbh=pz/89ztQ7TY/N7augos+j4Ef1sJsaJWwUTx9PVXcUEE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FMOu27/8uBOD9rCbRhzTpujATwcFj5+qHEA9xazk3Cnu20yBgFmJ7w42tmBXQ5JO8\n\thIz65hTMj84NAUrLBbVU4i/WD5QoRzxmNb1vTrYJtbNVNzgRzhy12zFYqbofUUAEX5\n\tAuBJ07BqzcDYWGGiwjTsC0zOct4ze/6A5HaqmGpQ=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tScott Branden <scott.branden@broadcom.com>", "Date": "Tue, 19 Jun 2018 14:30:40 -0700", "Message-Id": "<20180619213058.12273-14-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 13/31] net/bnxt: code cleanup style of bnxt stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Scott Branden <scott.branden@broadcom.com>\n\nCleanup alignment, brackets, debug string style of bnxt_stats\n\nSigned-off-by: Scott Branden <scott.branden@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_stats.c | 84 ++++++++++++++++++++++++++-----------------\n drivers/net/bnxt/bnxt_stats.h | 27 +++++++++-----\n 2 files changed, 70 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex a5d3c8660..d930aa00e 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -201,7 +201,7 @@ void bnxt_free_stats(struct bnxt *bp)\n }\n \n int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_stats *bnxt_stats)\n+\t\t struct rte_eth_stats *bnxt_stats)\n {\n \tint rc = 0;\n \tunsigned int i;\n@@ -217,8 +217,11 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \t\tstruct bnxt_rx_queue *rxq = bp->rx_queues[i];\n \t\tstruct bnxt_cp_ring_info *cpr = rxq->cp_ring;\n \n-\t\trc = bnxt_hwrm_ctx_qstats(bp, cpr->hw_stats_ctx_id, i,\n-\t\t\t\t bnxt_stats, 1);\n+\t\trc = bnxt_hwrm_ctx_qstats(bp,\n+\t\t\t\t\t cpr->hw_stats_ctx_id,\n+\t\t\t\t\t i,\n+\t\t\t\t\t bnxt_stats,\n+\t\t\t\t\t 1);\n \t\tif (unlikely(rc))\n \t\t\treturn rc;\n \t\tbnxt_stats->rx_nombuf +=\n@@ -229,8 +232,12 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \t\tstruct bnxt_tx_queue *txq = bp->tx_queues[i];\n \t\tstruct bnxt_cp_ring_info *cpr = txq->cp_ring;\n \n-\t\trc = bnxt_hwrm_ctx_qstats(bp, cpr->hw_stats_ctx_id, i,\n-\t\t\t\t bnxt_stats, 0);\n+\t\trc = bnxt_hwrm_ctx_qstats(bp,\n+\t\t\t\t\t cpr->hw_stats_ctx_id,\n+\t\t\t\t\t i,\n+\t\t\t\t\t bnxt_stats,\n+\t\t\t\t\t 0);\n+\n \t\tif (unlikely(rc))\n \t\t\treturn rc;\n \t}\n@@ -259,7 +266,8 @@ void bnxt_stats_reset_op(struct rte_eth_dev *eth_dev)\n }\n \n int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_xstat *xstats, unsigned int n)\n+\t\t\t struct rte_eth_xstat *xstats,\n+\t\t\t unsigned int n)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \n@@ -279,18 +287,20 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n \tfor (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {\n \t\tuint64_t *rx_stats = (uint64_t *)bp->hw_rx_port_stats;\n \t\txstats[count].id = count;\n-\t\txstats[count].value = rte_le_to_cpu_64(\n-\t\t\t\t*(uint64_t *)((char *)rx_stats +\n-\t\t\t\tbnxt_rx_stats_strings[i].offset));\n+\t\txstats[count].value = rte_le_to_cpu_64\n+\t\t\t\t\t(*(uint64_t *)((char *)rx_stats +\n+\t\t\t\t\t bnxt_rx_stats_strings[i].offset));\n+\n \t\tcount++;\n \t}\n \n \tfor (i = 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) {\n \t\tuint64_t *tx_stats = (uint64_t *)bp->hw_tx_port_stats;\n \t\txstats[count].id = count;\n-\t\txstats[count].value = rte_le_to_cpu_64(\n-\t\t\t\t *(uint64_t *)((char *)tx_stats +\n-\t\t\t\tbnxt_tx_stats_strings[i].offset));\n+\t\txstats[count].value = rte_le_to_cpu_64\n+\t\t\t\t\t(*(uint64_t *)((char *)tx_stats +\n+\t\t\t\t\t bnxt_tx_stats_strings[i].offset));\n+\n \t\tcount++;\n \t}\n \n@@ -303,8 +313,8 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n }\n \n int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n-\t__rte_unused unsigned int limit)\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t __rte_unused unsigned int limit)\n {\n \t/* Account for the Tx drop pkts aka the Anti spoof counter */\n \tconst unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +\n@@ -316,24 +326,27 @@ int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,\n \n \t\tfor (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {\n \t\t\tsnprintf(xstats_names[count].name,\n-\t\t\t\tsizeof(xstats_names[count].name),\n-\t\t\t\t\"%s\",\n-\t\t\t\tbnxt_rx_stats_strings[i].name);\n+\t\t\t\t sizeof(xstats_names[count].name),\n+\t\t\t\t \"%s\",\n+\t\t\t\t bnxt_rx_stats_strings[i].name);\n+\n \t\t\tcount++;\n \t\t}\n \n \t\tfor (i = 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) {\n \t\t\tsnprintf(xstats_names[count].name,\n-\t\t\t\tsizeof(xstats_names[count].name),\n-\t\t\t\t\"%s\",\n-\t\t\t\tbnxt_tx_stats_strings[i].name);\n+\t\t\t\t sizeof(xstats_names[count].name),\n+\t\t\t\t \"%s\",\n+\t\t\t\t bnxt_tx_stats_strings[i].name);\n+\n \t\t\tcount++;\n \t\t}\n \n \t\tsnprintf(xstats_names[count].name,\n-\t\t\t\tsizeof(xstats_names[count].name),\n-\t\t\t\t\"%s\",\n-\t\t\t\tbnxt_func_stats_strings[4].name);\n+\t\t\t sizeof(xstats_names[count].name),\n+\t\t\t \"%s\",\n+\t\t\t bnxt_func_stats_strings[4].name);\n+\n \t\tcount++;\n \t}\n \treturn stat_cnt;\n@@ -354,8 +367,10 @@ void bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev)\n \t\tPMD_DRV_LOG(ERR, \"Operation not supported\\n\");\n }\n \n-int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,\n-\t\tuint64_t *values, unsigned int limit)\n+int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev,\n+\t\t\t\t const uint64_t *ids,\n+\t\t\t\t uint64_t *values,\n+\t\t\t\t unsigned int limit)\n {\n \t/* Account for the Tx drop pkts aka the Anti spoof counter */\n \tconst unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +\n@@ -370,7 +385,7 @@ int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,\n \tbnxt_dev_xstats_get_by_id_op(dev, NULL, values_copy, stat_cnt);\n \tfor (i = 0; i < limit; i++) {\n \t\tif (ids[i] >= stat_cnt) {\n-\t\t\tPMD_DRV_LOG(ERR, \"id value isn't valid\");\n+\t\t\tPMD_DRV_LOG(ERR, \"id value isn't valid\\n\");\n \t\t\treturn -1;\n \t\t}\n \t\tvalues[i] = values_copy[ids[i]];\n@@ -379,8 +394,9 @@ int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,\n }\n \n int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n-\t\t\t\tconst uint64_t *ids, unsigned int limit)\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t const uint64_t *ids,\n+\t\t\t\t unsigned int limit)\n {\n \t/* Account for the Tx drop pkts aka the Anti spoof counter */\n \tconst unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +\n@@ -391,16 +407,18 @@ int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,\n \tif (!ids)\n \t\treturn bnxt_dev_xstats_get_names_op(dev, xstats_names,\n \t\t\t\t\t\t stat_cnt);\n-\tbnxt_dev_xstats_get_names_by_id_op(dev, xstats_names_copy, NULL,\n-\t\t\tstat_cnt);\n+\n+\tbnxt_dev_xstats_get_names_by_id_op(dev,\n+\t\t\t\t\t xstats_names_copy,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t stat_cnt);\n \n \tfor (i = 0; i < limit; i++) {\n \t\tif (ids[i] >= stat_cnt) {\n-\t\t\tPMD_DRV_LOG(ERR, \"id value isn't valid\");\n+\t\t\tPMD_DRV_LOG(ERR, \"id value isn't valid\\n\");\n \t\t\treturn -1;\n \t\t}\n-\t\tstrcpy(xstats_names[i].name,\n-\t\t\t\txstats_names_copy[ids[i]].name);\n+\t\tstrcpy(xstats_names[i].name, xstats_names_copy[ids[i]].name);\n \t}\n \treturn stat_cnt;\n }\ndiff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h\nindex b0f135a5a..08570238d 100644\n--- a/drivers/net/bnxt/bnxt_stats.h\n+++ b/drivers/net/bnxt/bnxt_stats.h\n@@ -9,20 +9,31 @@\n #include <rte_ethdev_driver.h>\n \n void bnxt_free_stats(struct bnxt *bp);\n+\n int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_stats *bnxt_stats);\n+\t\t struct rte_eth_stats *bnxt_stats);\n+\n void bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);\n+\n int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,\n-\tstruct rte_eth_xstat_name *xstats_names,\n-\t__rte_unused unsigned int limit);\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t __rte_unused unsigned int limit);\n+\n int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_xstat *xstats, unsigned int n);\n+\t\t\t struct rte_eth_xstat *xstats,\n+\t\t\t unsigned int n);\n+\n void bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev);\n-int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,\n-\t\t\t\tuint64_t *values, unsigned int limit);\n+\n+int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev,\n+\t\t\t\t const uint64_t *ids,\n+\t\t\t\t uint64_t *values,\n+\t\t\t\t unsigned int limit);\n+\n int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n-\t\t\t\tconst uint64_t *ids, unsigned int limit);\n+\t\t\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t const uint64_t *ids,\n+\t\t\t\t unsigned int limit);\n \n struct bnxt_xstats_name_off {\n \tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n", "prefixes": [ "13/31" ] }