Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40152/?format=api
{ "id": 40152, "url": "http://patches.dpdk.org/api/patches/40152/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/152656496221.46638.2475642927644303940.stgit@localhost.localdomain/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<152656496221.46638.2475642927644303940.stgit@localhost.localdomain>", "list_archive_url": "https://inbox.dpdk.org/dev/152656496221.46638.2475642927644303940.stgit@localhost.localdomain", "date": "2018-05-17T13:49:22", "name": "[dpdk-dev,v5,06/21] rte_ring.h: remove signed type flipflopping", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ca419f60254878b4fef9ef020587766fde44fe1c", "submitter": { "id": 1029, "url": "http://patches.dpdk.org/api/people/1029/?format=api", "name": "Andy Green", "email": "andy@warmcat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/152656496221.46638.2475642927644303940.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/40152/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 932C77CD1;\n\tThu, 17 May 2018 15:49:29 +0200 (CEST)", "from mail.warmcat.com (mail.warmcat.com [163.172.24.82])\n\tby dpdk.org (Postfix) with ESMTP id 1F3B37CB1\n\tfor <dev@dpdk.org>; Thu, 17 May 2018 15:49:26 +0200 (CEST)" ], "From": "Andy Green <andy@warmcat.com>", "To": "dev@dpdk.org", "Date": "Thu, 17 May 2018 21:49:22 +0800", "Message-ID": "<152656496221.46638.2475642927644303940.stgit@localhost.localdomain>", "In-Reply-To": "<152656480225.46638.3271983577765861155.stgit@localhost.localdomain>", "References": "<152656480225.46638.3271983577765861155.stgit@localhost.localdomain>", "User-Agent": "StGit/unknown-version", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Subject": "[dpdk-dev] [PATCH v5 06/21] rte_ring.h: remove signed type\n\tflipflopping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "/projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46:\nwarning: conversion to 'uint32_t' {aka 'unsigned int'}\nfrom 'int' may change the sign of the result\n[-Wsign-conversion]\n update_tail(&r->prod, prod_head, prod_next, is_sp, 1);\n\nThe visible apis take unsigned int, then call a private\napi taking an int, which finally calls an api taking an\nunsigned int.\n\nConvert the private api to take unsigned int removing\n5 x warning similar to that shown above.\n\nSigned-off-by: Andy Green <andy@warmcat.com>\n---\n lib/librte_ring/rte_ring.h | 4 ++--\n lib/librte_ring/rte_ring_c11_mem.h | 2 +-\n lib/librte_ring/rte_ring_generic.h | 4 ++--\n 3 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h\nindex d3d3f7f97..124582251 100644\n--- a/lib/librte_ring/rte_ring.h\n+++ b/lib/librte_ring/rte_ring.h\n@@ -335,7 +335,7 @@ void rte_ring_dump(FILE *f, const struct rte_ring *r);\n static __rte_always_inline unsigned int\n __rte_ring_do_enqueue(struct rte_ring *r, void * const *obj_table,\n \t\t unsigned int n, enum rte_ring_queue_behavior behavior,\n-\t\t int is_sp, unsigned int *free_space)\n+\t\t unsigned int is_sp, unsigned int *free_space)\n {\n \tuint32_t prod_head, prod_next;\n \tuint32_t free_entries;\n@@ -377,7 +377,7 @@ __rte_ring_do_enqueue(struct rte_ring *r, void * const *obj_table,\n static __rte_always_inline unsigned int\n __rte_ring_do_dequeue(struct rte_ring *r, void **obj_table,\n \t\t unsigned int n, enum rte_ring_queue_behavior behavior,\n-\t\t int is_sc, unsigned int *available)\n+\t\t unsigned int is_sc, unsigned int *available)\n {\n \tuint32_t cons_head, cons_next;\n \tuint32_t entries;\ndiff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h\nindex 08825ea5b..cb3f82b1a 100644\n--- a/lib/librte_ring/rte_ring_c11_mem.h\n+++ b/lib/librte_ring/rte_ring_c11_mem.h\n@@ -51,7 +51,7 @@ update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,\n * If behavior == RTE_RING_QUEUE_FIXED, this will be 0 or n only.\n */\n static __rte_always_inline unsigned int\n-__rte_ring_move_prod_head(struct rte_ring *r, int is_sp,\n+__rte_ring_move_prod_head(struct rte_ring *r, unsigned int is_sp,\n \t\tunsigned int n, enum rte_ring_queue_behavior behavior,\n \t\tuint32_t *old_head, uint32_t *new_head,\n \t\tuint32_t *free_entries)\ndiff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h\nindex c2d482bc9..ea7dbe5b9 100644\n--- a/lib/librte_ring/rte_ring_generic.h\n+++ b/lib/librte_ring/rte_ring_generic.h\n@@ -53,7 +53,7 @@ update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,\n * If behavior == RTE_RING_QUEUE_FIXED, this will be 0 or n only.\n */\n static __rte_always_inline unsigned int\n-__rte_ring_move_prod_head(struct rte_ring *r, int is_sp,\n+__rte_ring_move_prod_head(struct rte_ring *r, unsigned int is_sp,\n \t\tunsigned int n, enum rte_ring_queue_behavior behavior,\n \t\tuint32_t *old_head, uint32_t *new_head,\n \t\tuint32_t *free_entries)\n@@ -123,7 +123,7 @@ __rte_ring_move_prod_head(struct rte_ring *r, int is_sp,\n * If behavior == RTE_RING_QUEUE_FIXED, this will be 0 or n only.\n */\n static __rte_always_inline unsigned int\n-__rte_ring_move_cons_head(struct rte_ring *r, int is_sc,\n+__rte_ring_move_cons_head(struct rte_ring *r, unsigned int is_sc,\n \t\tunsigned int n, enum rte_ring_queue_behavior behavior,\n \t\tuint32_t *old_head, uint32_t *new_head,\n \t\tuint32_t *entries)\n", "prefixes": [ "dpdk-dev", "v5", "06/21" ] }