Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/37488/?format=api
{ "id": 37488, "url": "http://patches.dpdk.org/api/patches/37488/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com", "date": "2018-04-06T19:42:03", "name": "[dpdk-dev,v5,1/3] ether: support runtime queue setup", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "9a7c31c9cf1a14c9d044ed849691e6edd84b6861", "submitter": { "id": 436, "url": "http://patches.dpdk.org/api/people/436/?format=api", "name": "Rami Rosen", "email": "rami.rosen@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/37488/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/37488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E3F7C1C9C1;\n\tFri, 6 Apr 2018 21:42:11 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1547B1C9B9\n\tfor <dev@dpdk.org>; Fri, 6 Apr 2018 21:42:09 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Apr 2018 12:42:08 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n\tby orsmga003.jf.intel.com with ESMTP; 06 Apr 2018 12:42:08 -0700", "from FMSMSX110.amr.corp.intel.com (10.18.116.10) by\n\tfmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 6 Apr 2018 12:42:07 -0700", "from hasmsx106.ger.corp.intel.com (10.184.198.20) by\n\tfmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 6 Apr 2018 12:42:07 -0700", "from HASMSX110.ger.corp.intel.com ([169.254.6.223]) by\n\tHASMSX106.ger.corp.intel.com ([169.254.10.253]) with mapi id\n\t14.03.0319.002; Fri, 6 Apr 2018 22:42:04 +0300" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,416,1517904000\"; d=\"scan'208\";a=\"41293276\"", "From": "\"Rosen, Rami\" <rami.rosen@intel.com>", "To": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>, \"thomas@monjalon.net\"\n\t<thomas@monjalon.net>, \"Ananyev,\n\tKonstantin\" <konstantin.ananyev@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Xing, Beilei\" <beilei.xing@intel.com>,\n\t\"Wu, Jingjing\" <jingjing.wu@intel.com>, \"Lu,\n\tWenzhuo\" <wenzhuo.lu@intel.com>, \"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "Thread-Topic": "[dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup", "Thread-Index": "AQHTyi6w6xKoqGP4cUG3XQsCRFWJIKP0KWxA", "Date": "Fri, 6 Apr 2018 19:42:03 +0000", "Message-ID": "<9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com>", "References": "<20180212045314.171616-1-qi.z.zhang@intel.com>\n\t<20180402025935.33312-1-qi.z.zhang@intel.com>\n\t<20180402025935.33312-2-qi.z.zhang@intel.com>", "In-Reply-To": "<20180402025935.33312-2-qi.z.zhang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzliN2YxZjYtZjdlMi00N2RjLTk4MjUtMTcxM2YxMGQ5YTdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMXC9hRHloMTZrME5ZQXU4Mkp6TURvN0J0TDQzdFVDTUJcL0Z5ZzMzNUVCWGhva3NFOTJGWTF0RlMwVjRKSDhHSzkifQ==", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.0.116", "dlp-reaction": "no-action", "x-originating-ip": "[10.255.201.130]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi Qi,\nThanks for these patches.\nSee my comment below.\n\n-----Original Message-----\nFrom: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang\nSent: Monday, April 02, 2018 06:00\nTo: thomas@monjalon.net; Ananyev, Konstantin <konstantin.ananyev@intel.com>\nCc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>\nSubject: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup\n\nThe patch let etherdev driver expose the capability flag through rte_eth_dev_info_get when it support runtime queue configuraiton, then base on the flag rte_eth_[rx|tx]_queue_setup could decide continue to setup the queue or just return fail when device already started.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n doc/guides/nics/features.rst | 8 ++++++++ lib/librte_ether/rte_ethdev.c | 30 ++++++++++++++++++------------ lib/librte_ether/rte_ethdev.h | 7 +++++++\n 3 files changed, 33 insertions(+), 12 deletions(-)\n\n \t/** Configured number of rx/tx queues */\n \tuint16_t nb_rx_queues; /**< Number of RX queues. */\n \tuint16_t nb_tx_queues; /**< Number of TX queues. */\n+\tuint64_t runtime_queue_setup_capa;\n+\t/**< queues can be setup after dev_start (DEV_DEFERRED_). */\n };\n \n /**\n--\n2.13.6", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 1b4fb979f..6983faa4e 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -892,7 +892,15 @@ Documentation describes performance values.\n \n See ``dpdk.org/doc/perf/*``.\n \n+.. _nic_features_queue_runtime_setup_capabilities:\n \n+Queue runtime setup capabilities\n+---------------------------------\n+\n+Supports queue setup / release after device started.\n+\n+* **[provides] rte_eth_dev_info**: ``runtime_queue_config_capa:DEV_RUNTIME_RX_QUEUE_SETUP,DEV_RUNTIME_TX_QUEUE_SETUP``.\n+* **[related] API**: ``rte_eth_dev_info_get()``.\n \n .. _nic_features_other:\n \ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 0590f0c10..343b1a6c0 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (dev->data->dev_started) {\n-\t\tRTE_PMD_DEBUG_TRACE(\n-\t\t \"port %d must be stopped to allow configuration\\n\", port_id);\n-\t\treturn -EBUSY;\n-\t}\n-\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, -ENOTSUP);\n \n@@ -1474,6 +1468,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (dev->data->dev_started &&\n+\t\t!(dev_info.runtime_queue_setup_capa &\n+\t\t\tDEV_RUNTIME_RX_QUEUE_SETUP))\n+\t\treturn -EBUSY;\n+\n+\tif (dev->data->rx_queue_state[rx_queue_id] !=\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn -EBUSY;\n+\n \trxq = dev->data->rx_queues;\n \tif (rxq[rx_queue_id]) {\n \t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,\n@@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (dev->data->dev_started) {\n-\t\tRTE_PMD_DEBUG_TRACE(\n-\t\t \"port %d must be stopped to allow configuration\\n\", port_id);\n-\t\treturn -EBUSY;\n-\t}\n-\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, -ENOTSUP);\n \n@@ -1596,6 +1593,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (dev->data->dev_started &&\n+\t\t!(dev_info.runtime_queue_setup_capa &\n+\t\t\tDEV_RUNTIME_TX_QUEUE_SETUP))\n+\t\treturn -EBUSY;\n+\n[Rami Rosen] Shouldn't it be here: dev->data->tx_queue_state[...] instead of:\n dev->data->rx_queue_state[...] ? we are dealing with the TX queue.\n\n+\tif (dev->data->rx_queue_state[tx_queue_id] !=\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED)\n+\t\treturn -EBUSY;\n+\n \ttxq = dev->data->tx_queues;\n \tif (txq[tx_queue_id]) {\n \t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 036153306..4e2088458 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -981,6 +981,11 @@ struct rte_eth_conf {\n */\n #define DEV_TX_OFFLOAD_SECURITY 0x00020000\n \n+#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred setup rx \n+queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002 /**< Deferred \n+setup tx queue */\n+\n /*\n * If new Tx offload capabilities are defined, they also must be\n * mentioned in rte_tx_offload_names in rte_ethdev.c file.\n@@ -1029,6 +1034,8 @@ struct rte_eth_dev_info {\n", "prefixes": [ "dpdk-dev", "v5", "1/3" ] }